From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 141D6C4332F for ; Fri, 10 Nov 2023 18:15:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86C898D00F3; Fri, 10 Nov 2023 13:15:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 81DC08D0005; Fri, 10 Nov 2023 13:15:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70ACA8D00F3; Fri, 10 Nov 2023 13:15:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 607308D0005 for ; Fri, 10 Nov 2023 13:15:52 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3C62512035D for ; Fri, 10 Nov 2023 18:15:52 +0000 (UTC) X-FDA: 81442848144.03.085BA30 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id 953E7180020 for ; Fri, 10 Nov 2023 18:15:50 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=QVVgrtUX; dmarc=none; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699640150; a=rsa-sha256; cv=none; b=2nKArD0SUnmmPVlAquSdPpbME4RyhQvrlnVQiy3/IjAVZi1qsooUXu8cLR6NxxbPyFsiA8 x62RCBSui5AKKDbVJi1IPyd6ZtqlwYbErg7yW0LeTgoKe5v0qgArIfZNjI8RuvP7ggPphT YsGH4eMhLp56IHLY5s6DY1HFwGIz0Yw= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=QVVgrtUX; dmarc=none; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699640150; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9ychU8/163qVFg3NRvLxy0W+AaKY9ruaWTI4UwS3bek=; b=lehvgfjtUK+a1foTR9fRdGvzZSoBjsnpga70MAoj5U7h6fAQ09HBO8FnKZKD0o7XgClSgz P0oVjOGr9hiWkwSt5Kg4sfY+1LYfObx98ZiJ5QNmurCwDSyKnHF30vVVlIkHKRB/+QGWwz 1mPqT4ENt8qjEgA0GVYpYksMWvBB8sE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9ychU8/163qVFg3NRvLxy0W+AaKY9ruaWTI4UwS3bek=; b=QVVgrtUXxHkzv4Gs59wWtTbbds FEq1oSfCGTIpwiW8aCCyQfPKEavnv8eq8AxMGHrMc1D/SZtbYkQp9YjH68FscWdVduPugxg0FA+AJ ZkHWwShAtWhHXG2mJKHtqYrhiJoVU6XlF8iUHkEyjBtHwB3afbsu/Xzh+hjBAa9KWnmvz818+595w m0y1VRXAejQfm9zwSlOiSVVyoKazxeicWbKKRTAHmcMoMqYDsCkGzABSlUU+Za7yaxgR1moTkBkZR ZGlf6SWM05CtAc3bL/Rme6aRNor7G/iMWhFwD5OAInapRT7jPzOn5oT43QrCZtIO+4CaBM0i06Lm6 PhhiRV8Q==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1r1W2Y-00Et2C-6x; Fri, 10 Nov 2023 18:15:34 +0000 Date: Fri, 10 Nov 2023 18:15:34 +0000 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, David Hildenbrand , Gregory Price Subject: Re: [PATCH v2 2/7] fs/proc/page: use a folio in stable_page_flags() Message-ID: References: <20231110033324.2455523-1-wangkefeng.wang@huawei.com> <20231110033324.2455523-3-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231110033324.2455523-3-wangkefeng.wang@huawei.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 953E7180020 X-Stat-Signature: c5jr5bykdyeg5od88bpfdiii3oyac9ns X-HE-Tag: 1699640150-397153 X-HE-Meta: U2FsdGVkX19EhjcFMa/dava+6WiMJV8IBz6KZzz21l9lkgiKK0DP4gm6QfSs3YM+VTg6F27ReayOrrgVwvxMaO5/vsPomryW2tbjoQOIv9vct7XTWtq6vbjCxoYZmcOVJkILJZh+iW9PvC3tlpStPdfF0JQpiyozesu7LYDb7VIjVEH0p9IDjGg8IkPxCz78RHS1bjZD/769Uv2oKWTOAfFOfRBGpVhkgbfhTJLF0w9af3eU5RK2LKnskYmI+nyM15u5FN2LK+2/2Cms0TUJQOsf4YJw2RuAz+UER8mfERa3pf1P6VrKecz+z+HXAjFuem/fgu5D9Qm8Cx+WYKstnckkJV41pD9zOqqEeElddrh4/Wmca2YEn/NnsyNJQ5PQoulBXStsCl3LGeMOmgSjLHib4viXDheF9rc3mbW9Rpv+AaWOoKSOgdHlbNP5BfrBE6ClAE4MjUl/2CHBCQgIWWv/VH50q5tGU/eANiFoNM56ANT2Yp8mHvnL70uBtFq237QtZndNeoWSLzYruXinwMUx2yZEDgLa2lZuyvP5elveNlA9ewgPhIcvAx1t6cJuZC9x6Xfynst6D1oU65o8M7iCNrxEwDfmDPWb+3X6F2hYhA87UOxRUe1IV6i1y8JKaH0eqHrOWNH5xY5JhUBm3GwbK2eP4OwxHCqahBEc61SMF40it2qNUQjnrOxq6RFgAtpi0qckQHnWJu2cE2rgLECXaWKEMwPnrdxG0OkjfHkvbkQzP9ne0hOahm+UVVMbo11BIHtqdu/D9j5C0iTl7lK3m+RQgkwubCLe+35oUEyI72HDv3VOysialqxGBbapsrdDgM/nHx2hMG1vaYZmdVwDyIvcUTIrsr4OT7o3DeZFXIojw6/TDggIm3me5AR+MTArbDlkckwynK/1eowPbuyaM0TnFB99jxn6I2LUivUglIKf1ELTTRaVxLPnTjgF4xM7RmCyA+VQfwry9hE 0qkLTxep F6d31DRz9VrRf24GtwFjRjtU5IU93xdzHUrues8RAlvUd79YH8CSrFWHc8NaIVNFiKKcoV09dsLMCgMFrtWY/pAFusl00fDXwO4Gazgcb0nTpeBVz8o1tnSmnI8tNeC3eP7cySK2Nne5iH4DYHlZzu8ed52BQuCo1wufBot+l1tlmCNjDUFQPfGDJsA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 10, 2023 at 11:33:19AM +0800, Kefeng Wang wrote: > Replace nine compound_head() calls with one page_folio(). But that's not all it does. Honestly, when you write these kind of things, I wonder if you understand what you're doing. After this patch, if we report on a tail page, we set (some of) the flags according to how its head page is set. Before, we would have not reported on it at all. This was THE ENTIRE POINT of Greg's patch. And why his patch made sense and yours is nonsense. Andrew, please drop this patch series.