From: Matthew Wilcox <willy@infradead.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
David Hildenbrand <david@redhat.com>,
Gregory Price <gregory.price@memverge.com>
Subject: Re: [PATCH v2 2/7] fs/proc/page: use a folio in stable_page_flags()
Date: Fri, 10 Nov 2023 18:15:34 +0000 [thread overview]
Message-ID: <ZU5zRk+yi74pmAsq@casper.infradead.org> (raw)
In-Reply-To: <20231110033324.2455523-3-wangkefeng.wang@huawei.com>
On Fri, Nov 10, 2023 at 11:33:19AM +0800, Kefeng Wang wrote:
> Replace nine compound_head() calls with one page_folio().
But that's not all it does. Honestly, when you write these kind of
things, I wonder if you understand what you're doing.
After this patch, if we report on a tail page, we set (some of) the
flags according to how its head page is set. Before, we would have not
reported on it at all.
This was THE ENTIRE POINT of Greg's patch. And why his patch made sense
and yours is nonsense. Andrew, please drop this patch series.
next prev parent reply other threads:[~2023-11-10 18:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 3:33 [PATCH v2 0/7] mm: remove page idle and young wrapper Kefeng Wang
2023-11-10 3:33 ` [PATCH v2 1/7] fs/proc/page: remove unneeded PageTail && PageSlab check Kefeng Wang
2023-11-10 18:11 ` Matthew Wilcox
2023-11-10 3:33 ` [PATCH v2 2/7] fs/proc/page: use a folio in stable_page_flags() Kefeng Wang
2023-11-10 18:15 ` Matthew Wilcox [this message]
2023-11-11 3:21 ` Kefeng Wang
2023-11-10 21:50 ` Gregory Price
2023-11-10 3:33 ` [PATCH v2 3/7] fs/proc/page: respect folio head-page flag placement Kefeng Wang
2023-11-10 18:19 ` Matthew Wilcox
2023-11-11 9:49 ` Kefeng Wang
2023-11-10 3:33 ` [PATCH v2 4/7] mm: huge_memory: use more folio api in __split_huge_page_tail() Kefeng Wang
2023-11-10 18:20 ` Matthew Wilcox
2023-11-11 10:00 ` Kefeng Wang
2023-11-10 3:33 ` [PATCH v2 5/7] mm: task_mmu: use a folio in smaps_account() Kefeng Wang
2023-11-10 18:29 ` Matthew Wilcox
2023-11-11 10:57 ` Kefeng Wang
2023-11-10 3:33 ` [PATCH v2 6/7] mm: task_mmu: use a folio in clear_refs_pte_range() Kefeng Wang
2023-11-10 3:33 ` [PATCH v2 7/7] page_idle: kill page idle and young wrapper Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZU5zRk+yi74pmAsq@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=gregory.price@memverge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox