From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 125A2C4332F for ; Thu, 9 Nov 2023 17:06:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D9098D00EF; Thu, 9 Nov 2023 12:06:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 688A68D001A; Thu, 9 Nov 2023 12:06:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 577F28D00EF; Thu, 9 Nov 2023 12:06:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 48D668D001A for ; Thu, 9 Nov 2023 12:06:13 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B74AD40E97 for ; Thu, 9 Nov 2023 17:06:12 +0000 (UTC) X-FDA: 81439043784.15.AA684CC Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf12.hostedemail.com (Postfix) with ESMTP id B88544001F for ; Thu, 9 Nov 2023 17:06:10 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of catalin.marinas@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=catalin.marinas@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699549571; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xA18jTrVGhnfVk1X1+E4G+aD8OJepxzZ2atrcMMXKlg=; b=Yg+Ejdz1yBbjLIaGa5Uvy7VF7y4DLMCwO57QoUJz0hzV5PRp4ivbvY6Srbl35NYiwiOrJh jD9ESd8fPM6UqzjgheorXWpz+Yngj+iMdPh6bKzpoyXK1w6JTzTW83W/SjDoFDaZKklVnk xe3CkiSk4LzzSPSdS89mr9yFsXso76U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699549571; a=rsa-sha256; cv=none; b=vS5ZQmb3mtbZuBaxJxL6cwRtIoiIuvsxxX7liOdmGdw/DzxDHCCpVneUkjmfuyNqe1NdRW +w1gdm9IlkhixrGz5iYgP9RGQeNk5jIQNdpzgzguxuCvrZagUkga9dIBh2cOdeMifxe7r+ V7cv/DqnOnmVxZLi8r9zqJNDB/kAzHc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of catalin.marinas@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=catalin.marinas@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 40307106F; Thu, 9 Nov 2023 09:06:54 -0800 (PST) Received: from arm.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C61D83F7C5; Thu, 9 Nov 2023 09:06:08 -0800 (PST) Date: Thu, 9 Nov 2023 17:06:06 +0000 From: Catalin Marinas To: Omkar Wagle Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] MM: kmemleak: Add %x to pr_debug Message-ID: References: <20231108165424.8845-1-ov.wagle@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231108165424.8845-1-ov.wagle@gmail.com> X-Rspamd-Queue-Id: B88544001F X-Rspam-User: X-Stat-Signature: g8x4p3bpm3ezqm4af47bkous9j14g9yb X-Rspamd-Server: rspam03 X-HE-Tag: 1699549570-588118 X-HE-Meta: U2FsdGVkX1+34VsK84MsUn2HbBQ9bAMSYxkM1qGmB/b6lfMj0D1v5nqn8iXd4GNwrLDswCTNRY8aSsya76SUkMnxhbUdb9Y/xE754h04qzpY5RekTBVFhXYem0LzeawpRuUVEAgHR1ZL6PkrM2wON1164WA3qTvByMBO8B+Zd/OUAqdIinh9ecwmMzU9CtWXzZghgPhf6DTyDbTbtUblK0z9nwCIWpY7bHeAtn5t5zuKSDoQbwc+nEAaqtD9oRuX4c1mQpRM7+Sj49guqZhIjnS6ylOjkcSV8ifYJ3D1x22Kq2cQj4wvLGcyQWtJjfqZpd6olm6jch4KW1f9s0kquGycJE6eCARzttRoUGoZQxyq9kBs1whZc4cHSXS7eXORpPHI1gTbYTNzyNcUJwmCZvHo+5st7ulrAd1WlCNmy2ov3Hwpi27BMTk5f4i99RKuU7LDunKneB4z97CwNTGSCtlaT6Ipwtedn6zw1GieSs6iYrhEvoS02roxh4U+tfJCsvReoAj3MLD2qW79FmgHXNca6VFzipcBH3yD984dzrn1It5Jt3nr8pfiMEaS7V9K0ET3GYGwLZ8pMzamZxl8UGLHAjkg2r0z1rHiqe1Zb/NKdvNk5iybBrSNK50iXraRZKmKZKVA4gFR9fDw6qu6/kKH2fAIQbHEqXvkgtprv7S8szfyL4MVmuEIy971vG3MMKBc9rq6uBd7o4CBHbIr5Fh9jz1enjXQLvY26YJ/3Yd1aAkcaiNf7PQsPfpXPJ+yhP1TeXkSZkrvTBY3EFLznrKRFdOvsdaObJYBcM8IxHuaVHJkpk17FXrDWEp6ATpLORW1pzPxjQRPaXf8zY9+J7ZZKEjqn0IE2bExPuuZ+dUAgszPWspUmmBZYJJfShyFAemRBj8chP+yhYeCfdqkOPk2SGdFoWgDo75d2DS0soB0QhDkC4RtPcid+FVe9/3iopBOccKcsj0pkqkLXwM 48CQJafo zWPt9m15mSJCugWus7SapTI9Bdjrc3zKnZAGcT7OQ2XeneD46lyAzTSFOz4TvlQz6JL3k7bIZ8YD9r2ys5XFVv0xtbmkArp8XI3Nb2iGNJGXKk/eBiJCCi6ATBXN4jElw7DrmkywXioN6zkaMXhKPWg3ZNzyBlAOmbcZVH8Zrn6w0/ZtS+Nw+5mPbJkDN43a0qmV2VnuNGi2Tnq5ubrX6zQ22FGR2BRVRUiYbjeFhyJObRAthBdaYZffg4Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 08, 2023 at 08:54:24AM -0800, Omkar Wagle wrote: > Add %x to pr_debug to keep it for debugging > Remove the NULL check for object pointer > > Signed-off-by: Omkar Wagle > --- > mm/kmemleak.c | 30 ++++++++++++++---------------- > 1 file changed, 14 insertions(+), 16 deletions(-) > > diff --git a/mm/kmemleak.c b/mm/kmemleak.c > index a7b74dc3ff01..93b77288754a 100644 > --- a/mm/kmemleak.c > +++ b/mm/kmemleak.c > @@ -410,8 +410,6 @@ static struct kmemleak_object *__lookup_object(unsigned long ptr, int alias, > unsigned long untagged_objp; > > object = rb_entry(rb, struct kmemleak_object, rb_node); > - if (!object) > - break; > > untagged_objp = (unsigned long)kasan_reset_tag((void *)object->pointer); It looks like this patch is on top if your original patch. We don't do this unless your first patch was merged. So please fold your second patch into the first and post what's left of them. -- Catalin