From: Catalin Marinas <catalin.marinas@arm.com>
To: Omkar Wagle <ov.wagle@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] MM: kmemleak: Add %x to pr_debug
Date: Thu, 9 Nov 2023 17:06:06 +0000 [thread overview]
Message-ID: <ZU0RflNjfMaP9ppu@arm.com> (raw)
In-Reply-To: <20231108165424.8845-1-ov.wagle@gmail.com>
On Wed, Nov 08, 2023 at 08:54:24AM -0800, Omkar Wagle wrote:
> Add %x to pr_debug to keep it for debugging
> Remove the NULL check for object pointer
>
> Signed-off-by: Omkar Wagle<ov.wagle@gmail.com>
> ---
> mm/kmemleak.c | 30 ++++++++++++++----------------
> 1 file changed, 14 insertions(+), 16 deletions(-)
>
> diff --git a/mm/kmemleak.c b/mm/kmemleak.c
> index a7b74dc3ff01..93b77288754a 100644
> --- a/mm/kmemleak.c
> +++ b/mm/kmemleak.c
> @@ -410,8 +410,6 @@ static struct kmemleak_object *__lookup_object(unsigned long ptr, int alias,
> unsigned long untagged_objp;
>
> object = rb_entry(rb, struct kmemleak_object, rb_node);
> - if (!object)
> - break;
>
> untagged_objp = (unsigned long)kasan_reset_tag((void *)object->pointer);
It looks like this patch is on top if your original patch. We don't do
this unless your first patch was merged. So please fold your second
patch into the first and post what's left of them.
--
Catalin
prev parent reply other threads:[~2023-11-09 17:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 6:27 [PATCH] MM: kmemleak: Removed coding style warnings and added a NULL check Omkar Wagle
2023-11-08 10:41 ` Catalin Marinas
2023-11-08 16:54 ` [PATCH 2/2] MM: kmemleak: Add %x to pr_debug Omkar Wagle
2023-11-09 17:06 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZU0RflNjfMaP9ppu@arm.com \
--to=catalin.marinas@arm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ov.wagle@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox