From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A289EC0032E for ; Sat, 28 Oct 2023 09:23:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC9ED8D000F; Sat, 28 Oct 2023 05:23:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D79878D0006; Sat, 28 Oct 2023 05:23:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C416B8D000F; Sat, 28 Oct 2023 05:23:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B488B8D0006 for ; Sat, 28 Oct 2023 05:23:40 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7F9DFB647E for ; Sat, 28 Oct 2023 09:23:40 +0000 (UTC) X-FDA: 81394332600.22.3DFA8E4 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id 4CCF040008 for ; Sat, 28 Oct 2023 09:23:37 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=dO9JxZYp; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698485018; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W/g9f7l6jIflfVTO6azM776jOoL43h29jYipA4JfLSQ=; b=u40GL9V7SNXEtcvbRkJn5sVIK5usJGurRuscvw6ZI+phaEYXXlpHam+QmBHerCcF3RlHvD NU1F3Tf4sxztxc78vb2Hr/MlZfi98VZ4aoFnRLEYLjPC1qnSgwv2laXr1GoKgnCsRb4QY7 euTmmlKxLnSuvUKdEWzaXHaTNsbgseE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698485018; a=rsa-sha256; cv=none; b=oOYmkcfgmes4VHgA6eXr4SrEEtjTSvrmy3hdbVuiyK95akFAph2ItH+vM24hvQApC3w4BP YtATvT08WDN6Qvyrr51+QwfA6tSpmN5+7GQ+XMlAeaSv4MXtfrn2jCtIVerIMppD6/F4QG flIHu+6/9V8In4Jjv8nODUfXje96aEQ= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=dO9JxZYp; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=W/g9f7l6jIflfVTO6azM776jOoL43h29jYipA4JfLSQ=; b=dO9JxZYpYH4BpOkhUAK66Nr8Ry 4JVEXtJAbmqTrioNKBRZIZgJYpfbgdrWm3K+Gnw7nnQyUcvQ3unkJYiLw5FY7HxXYHxkN4bN1IV21 Y/xqGBrSXx0EON+zFR2qTiIpZOwOqzF5Cfr3xCBHB0NIbkA2xv6/H5JTSjGifCTVGrsQvbTca5oet gaMB7nDizXDxKncMTbzBsG0g+31Yc4Tw0swA5teDXHZvR39DEn2UxhX8i670tPhZ9/U0ttEQ8eJ5V pjH8XpTxQ6l7mRIlLbbV7W4foiv+BdA0do3kqfswBAR7hqXQ2wiD3WpPWAWXe1O98meRLYnlWGvhK NtJ5zSbQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qwfXJ-008dUX-ME; Sat, 28 Oct 2023 09:23:17 +0000 Date: Sat, 28 Oct 2023 10:23:17 +0100 From: Matthew Wilcox To: Mikulas Patocka Cc: Mike Snitzer , Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= , stable@vger.kernel.org, regressions@lists.linux.dev, Alasdair Kergon , dm-devel@lists.linux.dev, linux-mm@kvack.org, Andrew Morton , Michal Hocko , Vlastimil Babka Subject: Re: Intermittent storage (dm-crypt?) freeze - regression 6.4->6.5 Message-ID: References: <34f6678e-6460-f77-73f4-fc8d3652a8e5@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <34f6678e-6460-f77-73f4-fc8d3652a8e5@redhat.com> X-Stat-Signature: ebugsdxoxm74qen4gxmgms6adqshpzak X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 4CCF040008 X-Rspam-User: X-HE-Tag: 1698485017-261759 X-HE-Meta: U2FsdGVkX19iia4tIB6QgfMA/RRxeWnEX5b0KD1cofJRiRI+wF099qdBxBsPwTgMFPjPN0zyehDO0TrMqzaCi0eR3arT5O2RN79S4e1er16nT3uh7Yz3Tnlaw5M6SgMQSSVmnAiDPtWA2bUoUBdnjmcllqV9KihBL9/vNYmg45icXSOJdJpK12dE1MK2zdm/+eHtVAcRmu4MWRYB/YcFcbSweo6rYN/Y+xjOiN16iB6NVF2hazQ+PYKEDt0JfI1qO1suWMZ9OM/zclUXbErtVl7CL//c6ApvoLVbTvuRL+xgs+VVBTmQW3zvJusalUSWDdIs0TORDUUeeasZ99LqRuflLi6pPLmn3uYgFckqXLLlIQdNP9hjjDc4gfe6Mm69wu9jDmtG1SiSzp9R18EDLUxcahUxVtB8ef6qronXje2fa1AXNPnnFKDUbjy7pf4QQzmmoQ/TVS8CqwlLmygpMpVeCUYuLbvMB7cu1a5XEu+MrYT9VfKas0qoZkaLSl5jPXQP1Jpcdbb4rOQtniPoY9xW3Lm9oeTW+P0xbjTPSUES5q/EFverb+35+N/XwBg7BazfXsEdQRKIZN9+iFvdvLRIDCVAlALJhHph8ydJ5Lj2c2BAkpZ6ET+O6JbTVaXKxO222H/NdvjCBNfnis30aFlvd4yamu1oS2ZUxlQ1Ht5plsh5zHPmUXWSCUIjS68pvnKE1aQK/wKT91TFa38PivYawc5SuwZMy2fHAmG3Bn4wJfRwYlVgfwfwk0PWrlYQOm15jc5BFyAdBPchFGr/A/07WxJwQoQca/0lNN/TfXC6PaWouOZlG/aL1O3UC0frJRsCQiz8NMbvzc/sWglLi6lbOtD0NYGdmfeJAADKuwIRg8b9sMqrELBW1LgC2DqlH27mrtVSLUxBZxugjJUUYH0vt1zqILf9cLk9AUp1I/r8NzsZv3Pg5/Myjv3qgE/unSiZm9RRqKwYg+Tgat5 lM29B9Fw dV6tiIxV7pVnFmfG08wiBndcTlRN+OizVWIXk5Xc8m1e3zmX4brOb4wFZoe+hX07OURFHwSU0v5NHmh20wlH3E4F+5am+WKijQjDhzhDTSarZBAI2TKqPkRdotD2KBPLkFE5YHnv6M7fi627u37B4Pcc6xZLQ4Uar/tELltcLsP0ihdpxxqxhalQdiWcZgbi/aFxdcsTV5bs4fxV7JSWCxdu+NMkZOyv/zxjhR80iGrAFSt7tCcrEWqpZqDn+eBWgxDNrznI/4GQ9JXDrN+5f2z5xWPaDSKWZEks/3uCqAaSH6BwN4As0ot3wsLr1Hp+6+I10mazB2+WAV5lQzaugt/smjH3zv0GESn6J+G1ka1E15dCEAadeZGPWQb2b2SkjQvxPOqt+6T4gA9nPC8HYKV4OPKIMEA81VnrctizLcOzp5t+Nzo2v3/vA0g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 27, 2023 at 07:32:54PM +0200, Mikulas Patocka wrote: > So, we got no reponse from the MM maintainers. Marek - please try this yes, how dare i go on holiday. i'll look at this when i'm back. probably. > patch on all the machines where you hit the bug and if you still hit the > bug with this patch, report it. > > Mikulas > > > > From: Mikulas Patocka > Subject: [PATCH] dm-crypt: don't allocate large compound pages > > It was reported that the patch 5054e778fcd9cd29ddaa8109077cd235527e4f94 > ("dm crypt: allocate compound pages if possible") causes intermittent > freezes [1]. > > So far, it is not clear what is the root cause. It was reported that with > the allocation order 3 or lower it works [1], so we restrict the order to > 3 (that is PAGE_ALLOC_COSTLY_ORDER). > > [1] https://www.spinics.net/lists/dm-devel/msg56048.html > > Signed-off-by: Mikulas Patocka > Reported-by: Marek Marczykowski-Górecki > Tested-by: Marek Marczykowski-Górecki > Cc: stable@vger.kernel.org # v6.5+ > Fixes: 5054e778fcd9 ("dm crypt: allocate compound pages if possible") > > --- > drivers/md/dm-crypt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6/drivers/md/dm-crypt.c > =================================================================== > --- linux-2.6.orig/drivers/md/dm-crypt.c > +++ linux-2.6/drivers/md/dm-crypt.c > @@ -1679,7 +1679,7 @@ static struct bio *crypt_alloc_buffer(st > unsigned int nr_iovecs = (size + PAGE_SIZE - 1) >> PAGE_SHIFT; > gfp_t gfp_mask = GFP_NOWAIT | __GFP_HIGHMEM; > unsigned int remaining_size; > - unsigned int order = MAX_ORDER - 1; > + unsigned int order = PAGE_ALLOC_COSTLY_ORDER; > > retry: > if (unlikely(gfp_mask & __GFP_DIRECT_RECLAIM))