From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7610C25B48 for ; Thu, 26 Oct 2023 23:18:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0CE4C6B02FF; Thu, 26 Oct 2023 19:18:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 055FA6B0301; Thu, 26 Oct 2023 19:18:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E11D66B0302; Thu, 26 Oct 2023 19:18:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CE7E26B02FF for ; Thu, 26 Oct 2023 19:18:29 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id ADB4DB6152 for ; Thu, 26 Oct 2023 23:18:29 +0000 (UTC) X-FDA: 81389178738.10.DE7DA42 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id C27F81C000A for ; Thu, 26 Oct 2023 23:18:27 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SOmr3SGp; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698362308; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0k7pol6Ox9Lg+5J8guMydD0qxLzYw54p+yc1TXTXwYg=; b=s6oVc47vCcUuJj8WfC3psVRUyImoOgKk46lfIJklK1kGiOzh1qFYZMgu5aJ7sTUWe21kmR RSwcXKTJtg9dE7evPOKocqHkQTCDslW8tTVJkhjylguU9v3GEl2GPcIsNi03Us8pr2Qtv7 ZrNFD2zr/oKh/ZLjJrg4L7BLb1SDvTk= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SOmr3SGp; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698362308; a=rsa-sha256; cv=none; b=cx2iwG6T/L+SQ7vCZ1taXPwtGQrUL0QpkyCAv5jOim1sNqrtJreyPNbvVbFfAKHKZ5tNPr T+cIKZABe0im6DC4HuGJZ/7Pf8mkiucP1RslHwSZ1bXW/V6knk34wZ8ulqGyTNXzXAfzWw HtZssyhkyo03L5HsODD+9VupxYpPifQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698362305; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0k7pol6Ox9Lg+5J8guMydD0qxLzYw54p+yc1TXTXwYg=; b=SOmr3SGpXkQx5IzkfKZDKp7z0H8wKFyM4Lo+7RRwGi2x+vk2a/Y/5t7dqqwREjpBkArTnR I/W2cG+B6y9T5Xo3PyADOv4+/2U45o3Nf9oQhF2DCjv4kTBZS7/bMqPMwUoAMWLZtQt1un NJiX9bw+WbtXXL20Kbh9RQiltiqwBNY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-9-PWo8HKZGOeOYXY8-GQq6lw-1; Thu, 26 Oct 2023 19:18:20 -0400 X-MC-Unique: PWo8HKZGOeOYXY8-GQq6lw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A35C784AEE2; Thu, 26 Oct 2023 23:18:19 +0000 (UTC) Received: from localhost (unknown [10.72.112.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 692E92026D4C; Thu, 26 Oct 2023 23:18:18 +0000 (UTC) Date: Fri, 27 Oct 2023 07:18:15 +0800 From: Baoquan He To: Jiaxun Yang , Andrew Morton , Arnd Bergmann , Thomas Bogendoerfer Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, mpe@ellerman.id.au, Geert Uytterhoeven , Luis Chamberlain , hch@infradead.org, Florian Fainelli , deller@gmx.de Subject: Re: [PATCH v5 0/4] arch/*/io.h: remove ioremap_uc in some architectures Message-ID: References: <20230921110424.215592-1-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Rspamd-Queue-Id: C27F81C000A X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 4bkgx34pgn6gfgsijsnyyqy3cbnpy5m1 X-HE-Tag: 1698362307-526904 X-HE-Meta: U2FsdGVkX1+wr1hvnf4AUSIX0zO6Wmcr/KyOlOL64JAoap29Jp2FRPqRyBQB49JHjkQqwD7bDPdlsKK8HGwXgxhAMMUEm/LonRlJuYpvmFC54jnXc0l1mVuuS/oa5AcVLd/W5cBBJiTNGlxmGBlIwo1kcxgtYr4BqQs/9CtQ3rDwiG9KZeG2+uoMHOxEgiYowxqH+O/28X3UFm635Ai7ryrJV7LzmXKsXU4kpCP7frH0sBXa3Kw62WXI1u1oRtpHO17GJLWbMMO1xaCz4N7AFG/A25ISfDzJLNbA+GOqJvMq7HadtIP6ZRzK+4MoIRjkP/4G6INJOKzOC0o63O0L3zksPOg/Zd4ekSOn2JnNH8p0FCoqszQhZU84qH6iIDdNZAyhvqeu6SO4pVWt3A62t8tMorG4Y/bNsH1j0nTyyMRInMm+k853tMtiE2aQk3yJ4a8Sm01rrAqV2yhy3tswMdx8TJXgXkRzcGvsCdppNhNQYT9niAYZwclhnGtDBuYMJ4WfvoKrFh7rrrIBhdj5HskJiBPLDNZJ4hurNh1QoqDVehiYZJPNO/2BpmS8x0o8MW6zu1cRmYP1Hd8+69HLiRzr19r9njUZz0M/uvBHNJmthaU1C//ocIzeWIjsplWnBzBdVttu0pvBo6Z+iPkOPhAbUY8XfqL8xJ3yaD73sZ+6Zx24CaOmuAbBEkRqcDgZjlN7UaHotupm85IOaMjDVIgyJcrp13pN262QylzpHdESyJQ6GbO6rHClej12Q3tUNmb6+zn5l2JRXw5VrYFpUzmcpuGwRwXhUZ7L8ojpbiOe0jMFomDIR/WQZiJSwe9Tcr1cViCrBzTdWa9k02dUxsk+rVzjVNJFkrXTh3Hpqf/9Lj632TcPbDuCN39c2SfjuwlA94jdc7SI6oPgqPP2cIdDrnLhT7QwalokKj9kuiqzYQpyVkEgFt8HbAkYEP9fmCVYuTee9MqiWJxd5CL vTovtuCf JHnHxPN2IdC2tauqAWTvnZ8X/6X6/5zWpSAIgJF968p2i62TVe++InztO7zcBdRO71lyfqQ4ac2SowenSXCh0RxA3gSkGuAWUHLb1Ia2PLSLKyWVuQ6kdL5pT/HoXzBmhQYfsOArcVFD6vBt0Mr6IkqIIblE4cZsGjaxyMkBJ11Ulyk+n/uRrQ63VatO1AcgcExokDdE6QGAPKtQdkQrMItrt2cApr5HtVVdoFScTJo/TYUocEUSEF8asyRg04IfFPe3DnXcLxD1rs+V2dAbabcJNpgjzG5yM9yDX9kMGh3bdjzmHYeu5rYd7VqTAAY72Ekg+gGvwkIA27zGtkIe/Ru0m8w8/VtJ5ojTcsKtYozMsPJjOARdXREGnJP+7cOdw1kXc+8YIs4yGo9GaA8QlzYDeTmpSjzJEHm8ZwW57GPKuMOuMatQHKa2PvATjIrpC9qkeIZ5t+zphUKSmAAr3kYZ6rCLeLP7PKm4NA+n0Ks2n1MTP2bUSiO6y4A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/26/23 at 01:36pm, Jiaxun Yang wrote: > > > 在2023年9月21日九月 下午12:04，Baoquan He写道： > > This patchset tries to remove ioremap_uc() in the current architectures > > except of x86 and ia64. They will use the default ioremap_uc version > > in which returns NULL. Anyone who wants to add new > > invocation of ioremap_uc(), please consider using ioremap() instead or > > adding a new ARCH specific ioremap_uc(), or refer to the callsite > > in drivers/video/fbdev/aty/atyfb_base.c. > > > > This change won't cuase breakage to the current kernel because in the > > only ioremap_uc callsite, an adjustment is made to eliminate impact in > > patch 1 of this series. > > > > To get rid of all of them other than x86 and ia64, add asm-generic/io.h > > to asm/io.h of mips ARCH. With this adding, we can get rid of the > > ioremap_uc() in mips too. This is done in patch 2. And a followup patch > > 4 is added to remove duplicated code according to Arnd's suggestion. > > > > Test: > > ===== > > Except of Jiaxun's efficient testing on patch 2/4, I also did cross compiling > > of this series on mips64, building passed. > > > > For whole series: > > Tested-by: Jiaxun Yang Thanks for testing, Jiaxun. > > Hi Arnd and Thomas, > > I've got some work pending based on this series, however I'm unclear about > which tree this series will go since both of you give acked-by. > > Given that there are some tree-wide modifications, I guess it should go into > Arnd's asm-generic tree? Previously Andrew merged my below patchset. This patchset is solving the left issue during reviewing below patchset and discussing. Maybe Andrew can help pick this patches? [PATCH v8 00/19] mm: ioremap: Convert architectures to take GENERIC_IOREMAP way https://lore.kernel.org/all/20230706154520.11257-1-bhe@redhat.com/T/#u Thanks Baoquan