From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A693C25B6B for ; Thu, 26 Oct 2023 20:00:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E15388D0030; Thu, 26 Oct 2023 16:00:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC4048D0001; Thu, 26 Oct 2023 16:00:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB2428D0030; Thu, 26 Oct 2023 16:00:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BDB518D0001 for ; Thu, 26 Oct 2023 16:00:17 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9FB3580D42 for ; Thu, 26 Oct 2023 20:00:17 +0000 (UTC) X-FDA: 81388679274.03.E39D25A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id 519C7100020 for ; Thu, 26 Oct 2023 20:00:14 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="kRfJ/Tcx"; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698350415; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RvOXwandeVYtdokqifAIU5QghzlMJsS3czqYn7Psq7E=; b=me4L1PFoQ3yXWcpflieePHHGN8qIBCViUs9ihaMhm/8eK9/vJbwBVpcFk/HSmL7rFFcyuG tH1bvTwsF/DaXTcyoPOkeLJsgnlr5S9Gv2nXWg5BsFUXnFe/jjNDGYRTMozrW5T/mCL01S 0ZEgtaq+mEZXzBmSqB/yckEIxKy+abM= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="kRfJ/Tcx"; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698350415; a=rsa-sha256; cv=none; b=FqErPMespBhvnOPuwIZlZNWJCR6dcHxy92eGivD6PuNcrYlE7g9qNiQGME/YvKB8dbncHY EVzoim/f4qLdbp6hGyKM1xVQHRtDXW4iNljyfMhkactCtE3jY+6VpCzkSIQpHWUm+0gT5a 9NbBs0I/g6oGOJvCX5tXxYo49kXc60I= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RvOXwandeVYtdokqifAIU5QghzlMJsS3czqYn7Psq7E=; b=kRfJ/TcxIaEyeZwdVqfX4UvqrI aY2pRl9eiyXEJrUSsDRRXOn2/hlT7BCsqe/TLrJjdQPqdBafYpuuPJupOgHXFH341YSRFk7j072K1 6zFUdJwNjVCMZiYM+gYrsqMq2K1ukBOiz9ddpwwpI8g+oQ7g9H2HC62bi1bobZctV8YqZfkLzx58R wdJbaeGZAcx2MRd4Hhy2ClAHNIyRoUM5+j7G1QuYmOX0u5DPDeKJ9DubQl+lYHEwsDjy40bt8JJvC 5nPJ22TU/FNOR1xCxGoYKY0vzpahOetj5K68dWUe3qFpip3B3bRJX34JS2+B/KladbvQSwcLngDz6 lK917kEA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qw6WX-00GtAR-D5; Thu, 26 Oct 2023 20:00:09 +0000 Date: Thu, 26 Oct 2023 21:00:09 +0100 From: Matthew Wilcox To: Gregory Price Cc: linux-mm@kvack.org, akpm@linux-foundation.org, david@redhat.com, vbabka@suse.cz, naoya.horiguchi@linux.dev, linux-kernel@vger.kernel.org, Gregory Price Subject: Re: [PATCH] kpageflags: respect folio head-page flag placement Message-ID: References: <20231025201237.948993-1-gregory.price@memverge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231025201237.948993-1-gregory.price@memverge.com> X-Rspamd-Queue-Id: 519C7100020 X-Rspam-User: X-Stat-Signature: acbqa8cab56h8u5a6twfedq98ie55yrw X-Rspamd-Server: rspam01 X-HE-Tag: 1698350414-436011 X-HE-Meta: U2FsdGVkX18gkmNWF+3JIZydaP7lEdTswJVPJy4ibm+y/iZmpGxi/9dxf3wBk7zzvvE1HopRCiu6+BwjyMrx2MqFWiQitpEAOwcJjF44sARHsmpFE6JCv6eS0nxrQiMWSk0HAnuMbdkgotV+dkQZ/ElkCM1TYePDSNnZWU1gnHzcGQL5oXOHDjIKbrIXge1fmld1s0IwYC/Ei1rQtMS5aPFh21ccYZdGiPMoRH9oBSdtUKOZPRSOUQEgfJQ23ox3h6gcjjJpMwfsq8QBOIiTJOwyy2TuItDTqWS6cjhWcYDfrut5fQPz/5szT8Fa0c48Ji6poLlKDu75TWgNpYwmLpEzox+9czFHBZg3Uaww252Nani76PuyBpphI5XoHPfbwPkIw7bAoW6XY1AfGy/P8l5mkmaOM8fNrR/9qd6Oi5TXeTcPM9TUD5U/VnwN9vgyomJ55uD+47d15boUQywXeKSeZYLOTidWfhn5coOTDsXdkgMc9fqGzzlHz0tYLb39LN7VfWeIy97GcnT9MypplIuL0LBXtmNNxpW6bwi6OkIP2u5aEsbeBJTz2dI0AAxJ8zWPW3r2f6rd7ryCyRhb2slDLKP8droLo5bPVBekAMXpKoVDHwxG8iy2LRQ8lR44RynOUtbr01JRG7uwX7tsPkCO0zBvQC4DIf6mvgzMDt2GtCyLHiDOA1+dzbzlHnDMc3Eu/uN4FlwITnZ+w3cMKlxkfpFtT7tvy9wTdPWJ6LgI0wfUQpDvB6beEugMU5w4yUEoRWTk6E03it6xSPybNsDrSY9FUeiCvVRgmRTX5Ze2cAYx/dYGm49uhECJqZRAxoy494poYvue6N00JzgATk++9R5lwGIUxOwZdNvOGGZRN7NgRxnZ+/QUPbLrD86eA+A3S/ngIzXN1zuKbZN7mufsrUhBh7CQklXXx8EozOrxXqTKW8BpK0x9mbQydxjmlBvqIhB8Msu1ZhGDHTH EIvnsrx6 wZGuZ8GFDgns9Zd8RJynVoysSNvmjd9RlHsdZoPIcLCbFd6OZlsvLp4PqiLaMGTtrHwMZDmPkvww/lcjG7Hq+wK0Z4/0EtpVuf786536r6qhmFxnxUinDtj6ms4poth8PeKWrKiV+GrzgcpD3uQQ4g+Xqnl0oNqXZZoFGVNJW9rsA7MwrI00mlEJtSdFi7zwe5JR2d9yiro64UzHu0mEgROe/UfNrMR/FkV+fstTR1i4YAtA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 25, 2023 at 04:12:37PM -0400, Gregory Price wrote: > +++ b/fs/proc/page.c > @@ -188,20 +188,31 @@ u64 stable_page_flags(struct page *page) > u |= 1 << KPF_SLAB; > > u |= kpf_copy_bit(k, KPF_ERROR, PG_error); > - u |= kpf_copy_bit(k, KPF_DIRTY, PG_dirty); > + > + if (PageDirty(page)) > + u |= 1 << KPF_DIRTY; This is not the way to do it. At the beginning of the function, add: struct folio *folio = page_folio(page); Then use folio_test_XXX istead of PageXXX().