From: Matthew Wilcox <willy@infradead.org>
To: Gregory Price <gourry.memverge@gmail.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org, david@redhat.com,
vbabka@suse.cz, naoya.horiguchi@linux.dev,
linux-kernel@vger.kernel.org,
Gregory Price <gregory.price@memverge.com>
Subject: Re: [PATCH] kpageflags: respect folio head-page flag placement
Date: Thu, 26 Oct 2023 21:00:09 +0100 [thread overview]
Message-ID: <ZTrFSeG16WCoak2C@casper.infradead.org> (raw)
In-Reply-To: <20231025201237.948993-1-gregory.price@memverge.com>
On Wed, Oct 25, 2023 at 04:12:37PM -0400, Gregory Price wrote:
> +++ b/fs/proc/page.c
> @@ -188,20 +188,31 @@ u64 stable_page_flags(struct page *page)
> u |= 1 << KPF_SLAB;
>
> u |= kpf_copy_bit(k, KPF_ERROR, PG_error);
> - u |= kpf_copy_bit(k, KPF_DIRTY, PG_dirty);
> +
> + if (PageDirty(page))
> + u |= 1 << KPF_DIRTY;
This is not the way to do it.
At the beginning of the function, add:
struct folio *folio = page_folio(page);
Then use folio_test_XXX istead of PageXXX().
prev parent reply other threads:[~2023-10-26 20:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 20:12 Gregory Price
2023-10-26 1:34 ` Rik van Riel
2023-10-26 19:12 ` Gregory Price
2023-10-26 20:00 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTrFSeG16WCoak2C@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=gourry.memverge@gmail.com \
--cc=gregory.price@memverge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@linux.dev \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox