linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Gregory Price <gregory.price@memverge.com>
To: Rik van Riel <riel@surriel.com>
Cc: Gregory Price <gourry.memverge@gmail.com>,
	linux-mm@kvack.org, akpm@linux-foundation.org,
	willy@infradead.org, david@redhat.com, vbabka@suse.cz,
	naoya.horiguchi@linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kpageflags: respect folio head-page flag placement
Date: Thu, 26 Oct 2023 15:12:41 -0400	[thread overview]
Message-ID: <ZTq6KRn9tKp5KOJA@memverge.com> (raw)
In-Reply-To: <3ac68b3be0f62cfcd930ee84b87fbdc8244fe45e.camel@surriel.com>

On Wed, Oct 25, 2023 at 09:34:15PM -0400, Rik van Riel wrote:
> On Wed, 2023-10-25 at 16:12 -0400, Gregory Price wrote:
> >         u |= kpf_copy_bit(k, KPF_SWAPBACKED,    PG_swapbacked);
> > 
> 
> Aren't PG_locked, PG_reclaim, and PG_swapbacked also maintained only on
> the folio/head?
> 
> Would it make sense to convert those over as well?
> 

I see them registered as PF_NO_TAIL in include/linux/page-flags.h

Certainly i think there are other updates that are likely needed, but
I wasn't quite sure how to handle ONLY_HEAD and NO_TAIL and other
conditionals.  Should the bits always be 0 or should it refer to HEAD?

Just not sure at the moment.

~Gregory


  reply	other threads:[~2023-10-26 19:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-25 20:12 Gregory Price
2023-10-26  1:34 ` Rik van Riel
2023-10-26 19:12   ` Gregory Price [this message]
2023-10-26 20:00 ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZTq6KRn9tKp5KOJA@memverge.com \
    --to=gregory.price@memverge.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=gourry.memverge@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=naoya.horiguchi@linux.dev \
    --cc=riel@surriel.com \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox