From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65A48C00A8F for ; Tue, 24 Oct 2023 18:29:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B05DB6B02D8; Tue, 24 Oct 2023 14:29:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB66C6B02D9; Tue, 24 Oct 2023 14:29:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97D6C6B02DA; Tue, 24 Oct 2023 14:29:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 87C336B02D8 for ; Tue, 24 Oct 2023 14:29:37 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4E0D1C067A for ; Tue, 24 Oct 2023 18:29:37 +0000 (UTC) X-FDA: 81381193194.04.0D5D74D Received: from out-203.mta0.migadu.com (out-203.mta0.migadu.com [91.218.175.203]) by imf16.hostedemail.com (Postfix) with ESMTP id 4A3C2180020 for ; Tue, 24 Oct 2023 18:29:34 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=qxmyiqZd; spf=pass (imf16.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.203 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698172175; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cJvtH1RU485LotJpakrbV9U/UfyKsr5ptSPtEPeho50=; b=fLHaQXZ6N2/ndXGWwU3q9skmVVWmCimWV778oOT+bINO2hdgt4hlxsLpGcWnDST4yS4MG6 0RTAyIHx/nspKVWFivYq8Ob9meva1NUk0SqLFrexzP6AwSXPFQE+/Hcbsgf+lAnx5/991/ PH6l/bVOmNzrEyOvqtjp3LjUZqs/STk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698172175; a=rsa-sha256; cv=none; b=mIeAEsG0wmde+/IQ3jNr4CWCKzFEgk50KhZaqRrpruWnYlloyfkhh9f3A5rJng9kmSJzsm JIbfR+ZkUl1LBLYKhG0hNVsdtozZl9U2xmP/F8i8ngnzj3qmNs1ZRrWDu4BVxo9nHfalRc cUZeNZhNiIkvedgyA/arlT06Co5nZqQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=qxmyiqZd; spf=pass (imf16.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.203 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Tue, 24 Oct 2023 11:29:03 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1698172172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cJvtH1RU485LotJpakrbV9U/UfyKsr5ptSPtEPeho50=; b=qxmyiqZdvUbSc5OX8sJ5B56VRDGRIypt0m2ZexyNmyd2CWJuUlLqxDCgQmiWZxhgLrnEJP Q3PacIpe5vXTiE86jUv2kcvB2COry3b6xKIlN2wW5y2pG9dxxNOj26Rwsg8w9wjXki2GwQ /5zO2TFTFVb+ghWrRC0JLTshCp62Kqo= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v2 00/39] Memory allocation profiling Message-ID: References: <20231024134637.3120277-1-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231024134637.3120277-1-surenb@google.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 4A3C2180020 X-Rspam-User: X-Stat-Signature: 16spcgim37gs8ouoexfaix1i1ewepde7 X-Rspamd-Server: rspam03 X-HE-Tag: 1698172174-519456 X-HE-Meta: U2FsdGVkX1+NPJNhW7gv2R11d+WMJGHiw1EIZ4TCUlwGM41lq5Os5jhIt3MYAW9WajTdruNyTATV0disK4B6WkEUPPws4GB2SbuRDrpDvFjpifFyPCMvgmHRo+Ooamn3sWv0YABnaTte666QOKO7OW0282t7VcVqAosq7e2293XeHGdc2VaFAdc9hH802QvY53SSgthKynim/GO0HdCfWVCB6SiqGXX5pb+ZD0w8Klku9NwFq1UTln117MUecTEWUAXoJ2q8Y7/9Pih4wDqbpUGbNvb1zmMgJmJow6WBG2ypocruqXpDc9Xrn2trBzSaXH8DLfuFqX5uiv3fykLV/OOdl/Kzgi9FNsKdJCRV/BuTyAgiZ8/ZrFewFF7atz7V+y7rFjxtHNz6zu4KPzzpWkbzwy+QiusYl4Z2g8+js6rOooTaIeHG0BPF+ZZ70BJMVxSrxTbRcVyBB1s8UCAXUQfzFUduow5Xe20BMOqxlPVyzTX1P3O+HSbfGW9m6lmIScl/YmD9K1dBTprkHk9nd+6bucc8DUBZT3yseKEV6zcrQ4McTyJ9/HcwFsRsH2t74TK1ytqEJi0FbqUlycCrjrSAJNAfZDzvvWJqAqk6pV4hm1jhwRy50fffoHB+VN5+nZjBYBthW/7ofaFR7y+fot2r3OVnYVFpq2biR0KO+sIkJ4FAgesluLERkGblENLXAol8bD7sWFIIniHcURTyzrH1n2tq8adEs4AQkPHKHZwxK1i66FT6qAtZr/wuxOUeVeFPHnzyF9l5zz+5QRfmRjdtsR+lt0s109sDwGNPRKmCUwuAK9NMTMhTrk7EGdns3QeCrWiIHoyosAQu9iNog3VEHwHXxLwXIdVmUiAOFIhkCPujcTJTvWMojayNM4vp8wcP1NZJM+JLdK5Ty6NPjwVJuXer22YANF6FaEsHPgtZYyfSOkOrwcSQSPlmpbkRS7cDGf7HRij00p93McW k4Nn30Fc UakBF3VAbH81uoxeKy/RoiEYJG8vkAPAnP68FYExD0l4XtUiXD9hOYMMc7oqf5XWvtp7LrE5NImgmnH2e5qFZNGkTpZ3PkKCLcx+y/+k+7y2E13blqCVPjTjz25qeXw0oKQonWQwz43masPfvDU1lC7zi4cyggiYxuJpZfPl5F7vdcMg2OC0ru5Ok1moE0LIIRwH+xM3wloVDHdyEqjUztUY+0g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 24, 2023 at 06:45:57AM -0700, Suren Baghdasaryan wrote: > Updates since the last version [1] > - Simplified allocation tagging macros; > - Runtime enable/disable sysctl switch (/proc/sys/vm/mem_profiling) > instead of kernel command-line option; > - CONFIG_MEM_ALLOC_PROFILING_BY_DEFAULT to select default enable state; > - Changed the user-facing API from debugfs to procfs (/proc/allocinfo); > - Removed context capture support to make patch incremental; > - Renamed uninstrumented allocation functions to use _noprof suffix; > - Added __GFP_LAST_BIT to make the code cleaner; > - Removed lazy per-cpu counters; it turned out the memory savings was > minimal and not worth the performance impact; Hello Suren, > Performance overhead: > To evaluate performance we implemented an in-kernel test executing > multiple get_free_page/free_page and kmalloc/kfree calls with allocation > sizes growing from 8 to 240 bytes with CPU frequency set to max and CPU > affinity set to a specific CPU to minimize the noise. Below is performance > comparison between the baseline kernel, profiling when enabled, profiling > when disabled and (for comparison purposes) baseline with > CONFIG_MEMCG_KMEM enabled and allocations using __GFP_ACCOUNT: > > kmalloc pgalloc > (1 baseline) 12.041s 49.190s > (2 default disabled) 14.970s (+24.33%) 49.684s (+1.00%) > (3 default enabled) 16.859s (+40.01%) 56.287s (+14.43%) > (4 runtime enabled) 16.983s (+41.04%) 55.760s (+13.36%) > (5 memcg) 33.831s (+180.96%) 51.433s (+4.56%) some recent changes [1] to the kmem accounting should have made it quite a bit faster. Would be great if you can provide new numbers for the comparison. Maybe with the next revision? And btw thank you (and Kent): your numbers inspired me to do this kmemcg performance work. I expect it still to be ~twice more expensive than your stuff because on the memcg side we handle separately charge and statistics, but hopefully the difference will be lower. Thank you! [1]: patches from next tree, so no stable hashes: mm: kmem: reimplement get_obj_cgroup_from_current() percpu: scoped objcg protection mm: kmem: scoped objcg protection mm: kmem: make memcg keep a reference to the original objcg mm: kmem: add direct objcg pointer to task_struct mm: kmem: optimize get_obj_cgroup_from_current()