From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13F5DC25B6C for ; Tue, 24 Oct 2023 15:14:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D6256B02BA; Tue, 24 Oct 2023 11:14:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 986056B02BB; Tue, 24 Oct 2023 11:14:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8756E6B02BC; Tue, 24 Oct 2023 11:14:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7B31F6B02BA for ; Tue, 24 Oct 2023 11:14:48 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 566FAC0204 for ; Tue, 24 Oct 2023 15:14:48 +0000 (UTC) X-FDA: 81380702256.20.8627CB7 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id B32F14002F for ; Tue, 24 Oct 2023 15:14:46 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="MP/sNQJ7"; dmarc=none; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698160486; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qpmLAMe3UIUUFs6yiDrqQIACnDygj9UeXkkyfRKdiWA=; b=xieuDi9VcgpZ8amt9iaaLD8oFH3XMXjsl8ebIc45vvnQA0jni8GhNGPMDXeWVAPOmrOFaI pQC+GNhtKNfIV6eBkCM6C9iFg1yRp5ltZ46MC02TaIuay42358URiPb5BwsZar6ApOFT/r hWoCtdEbJuvdiW+fy/WUSPt6sP+AQL0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="MP/sNQJ7"; dmarc=none; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698160486; a=rsa-sha256; cv=none; b=SCbXUWFUXXQN7la46Ia7NlyFfhkut0hBZkVqiNvO1U6M3b/+1tOq/hqBIR/gOQlBGPQ8hK Qd4lsxfneKRZISEeSrITQSafR8kI0V1CXSNrRllLldoDN313KXCwy3h9JRNkezR18w7uVB lYK06VemsNVvM/5MNCmS9K4pgIAN3Ak= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qpmLAMe3UIUUFs6yiDrqQIACnDygj9UeXkkyfRKdiWA=; b=MP/sNQJ7Oj5bKDcaH/zYzk9b5J XJxHdA+lP/zEfA0tHclyq0C6at32laH3EkiCarOa9+mPovCKu8OCXzqk8BZtL9OMuYhylfjQlTEhh fpHYd2/nka1it6G++Jm13WWShHNNO81UfVEf7+VWE4VizuayJAQwpsxezeDNdhbBuHs+R/i2HK0O6 HjnFhzLWlDQdCqjEuLHir5Gwys9wvbLh5wCAeYmKzn9t19zo/ygagFNJaE47wYrpsw0SQBdci6Thp EoZPjTGXts/kIbik96TAuyy9mP0JoxWgAKqj21RxKs19czqCODP8ExZelyS/wwtte7Tg4IZuuIjMM qJl+Bm8A==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qvJ79-003Bjb-PR; Tue, 24 Oct 2023 15:14:39 +0000 Date: Tue, 24 Oct 2023 16:14:39 +0100 From: Matthew Wilcox To: "Darrick J. Wong" Cc: Christoph Hellwig , Jens Axboe , Ilya Dryomov , Andrew Morton , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/3] xfs: respect the stable writes flag on the RT device Message-ID: References: <20231024064416.897956-1-hch@lst.de> <20231024064416.897956-4-hch@lst.de> <20231024150904.GA3195650@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231024150904.GA3195650@frogsfrogsfrogs> X-Rspamd-Queue-Id: B32F14002F X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: g1ubbh86o4a1z1m9co96zoajcj7irj9z X-HE-Tag: 1698160486-141662 X-HE-Meta: U2FsdGVkX18Tl25A6v8OC9vs50nbxOvQqrS4hXaWuraJycKQn1PEpp0GhY/MqSMn4ZhNyCMzFCHYK+S4TV+neAV5KPxj2WPbjt4syiMZ23oPFQ70VOI/OcTvgFyGALD4paqV4HHL9t89zgAs0NV0wViwbwRmsqcuQanyB1c+U1OMoFryc9G4DlvYwUTVjjQA6hVi/wmoNgPe4y7YP31z1UiFTtXlsAKr+EOxdvHUVJzS22WNlKyq0qtMbyvVto0vzxo8cZI0U3CenWHR6/ZG4GXKgVZLTIX/Ailzsv1L7yaS6nQqatVFj12l9mZ+9EQEQRsDaMwVhOHSg3BEfBcLR7I3N4FLedM6msXre5XKAvHcIJcrFB8Aul84e5D5Er3ZLhAoGtBm/jfGYsSOX2gilXTcn+Fddq/n+tNOxDWBNv+mis+YnfdEvFzA+eAGT+GPeFETIIlZ3E8vmH+t8rMB9O9B4Q1xVrBjThjufGEcHlPfXBuG9f5s2pV7rFqiF5dbG7pcgN6vH6OKS+1LKlyKuG8pQ4b8Uf023ImwFm2zPC98eXhCmc4wJqCl000U9428yu5aT2ROF4EEWCzx9AeksuYjGFMmVyETYhtodewZe6ohvHaq7S3OSLP5sCKc2jZ1fVh+q9eaNXyvGPmRDotbQDnSdXtZRoClUmkyuw+Zpecc+AOHcDehp6FKIUKwmSXERKrYlluFCroB3csLxd8Vfdasd5hiUJMvB3z8mYk4wOrjMKgDw/Z9keI60mynQPvMTveVt1/JyEX/7SGrVkNMj+bTA7yJjt+tyVaCARtlzEIj4SlUOzAG2LBYEHczYa5AP/brtTPS12c/uMpU+vmsjbN+LGkrZWdx96JVjtG39lv3hOfRN4g6JdNzgE3q/4Ozmj+Susqx5XAckwy3fhe4Cg1mdPBszBrzBqQHkSs33MoRG+iV73o4LENtlOyNuC1/kFdYOY/wAK2v1u4daNS EouS+WPr Mq8ddNj/cbRlF5EdNBpwUbr7sR5BTiOlMVd4cIBzwGh+ZH0AdguAyFQcNpaJSmC5b5B47G1+GvIo/OzecNrRdbff9wJId3Y1vGCIfO6Q5bLSXhCamGoQyC+5h5N/xNEgXnyXPWBKgSm2yiN8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 24, 2023 at 08:09:04AM -0700, Darrick J. Wong wrote: > > + if (S_ISREG(VFS_I(ip)->i_mode) && > > + XFS_IS_REALTIME_INODE(ip) != (fa->fsx_xflags & FS_XFLAG_REALTIME)) > > + xfs_update_stable_writes(ip); > > Hmm. Won't the masking operation here result in the if test comparing 0 > or FS_XFLAG_REALTIME to 0 or 1? > > Oh. FS_XFLAG_REALTIME == 1, so that's not an issue in this one case. > That's a bit subtle though, I'd have preferred > > XFS_IS_REALTIME_INODE(ip) != !!(fa->fsx_xflags & FS_XFLAG_REALTIME)) > > to make it more obvious that the if test isn't comparing apples to > oranges. != !! might be going a bit far. Would you settle for XFS_IS_REALTIME_INODE(ip) == !(fa->fsx_xflags & FS_XFLAG_REALTIME) ? Although none of these read particularly nicely. Maybe XFS_IS_REALTIME_INODE(ip) != ((fa->fsx_xflags & FS_XFLAG_REALTIME) == 0)) Perhaps we need a bool helper for (fa->fsx_xflags & FS_XFLAG_REALTIME)