From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1482C00A8F for ; Tue, 24 Oct 2023 15:10:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B8F26B02B8; Tue, 24 Oct 2023 11:10:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 369796B02B9; Tue, 24 Oct 2023 11:10:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2582B6B02BA; Tue, 24 Oct 2023 11:10:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 12FB46B02B8 for ; Tue, 24 Oct 2023 11:10:39 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DDF78A029B for ; Tue, 24 Oct 2023 15:10:38 +0000 (UTC) X-FDA: 81380691756.04.4AE5587 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id 2DAB81A0015 for ; Tue, 24 Oct 2023 15:10:35 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=d0OntYfe; dmarc=none; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698160236; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ql2eltEQ8DJZApzT9fh9fzvtNpsHZrs3XNxvxh5UtMA=; b=lasm/P+DFwJqaKmzTxlNNRJG+71P/XIfolPhMFzYVi9KTpYDcCevS6XEEioGIJaQiB5yt/ jkr4pxBrc6Km7uFHHxzYjsQj8RTSnnouqgqvn59aJ+9G+/fjg7jQuv9SGPPfdtvo0jLP1T HF1LbnvUkZ59yGDxV/MBtcXcF8Pw2s4= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=d0OntYfe; dmarc=none; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698160236; a=rsa-sha256; cv=none; b=VlRuDhfo6leF6U3vCGdaGi0Uo+z03+VmV6zai2o67uWU3vNrDPg3RQhHcNTBXrt2s+eMoX zPz4y9zXV7+023X2wxOQFBDQVItmBdsuEJ1aaXXZvd5ObgQrc5rlFdDaq+lzN9pG56iZ+p 1tWhhtXlcOXGmGZgid6KytGXiTpKvkQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Ql2eltEQ8DJZApzT9fh9fzvtNpsHZrs3XNxvxh5UtMA=; b=d0OntYfe0ymPyU6quYfPhRqgcF OJxFCZ5PfPy9fB8HnMowNXML29uvEblIoET9udJzrwy3YZNOSsCcVkDS0LucMMqBEVLLiD10NcX5e I/xRRf+bmH+76vuIlWn/kMLFmrZjvjcGdbCSf+EOJTcR8TTNYr6h75dXk0j//BJdNgN1od94Uk9S3 64Y1a2TvoE8Fll/xUUBIjP/3MUkVG7iixoNXWS1+M/koff/mE514g9i13gkaHcPiwUScwKBMgMgSW o4WN7pu1SJ9RLUvGq4V28TCcm/xcfitWI36hYIpYm5sXYf3R6z11gWbx6ALlpmiIm9HQlTeif7uo5 86yxe23A==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qvJ35-0039Gq-9s; Tue, 24 Oct 2023 15:10:27 +0000 Date: Tue, 24 Oct 2023 16:10:27 +0100 From: Matthew Wilcox To: "Darrick J. Wong" Cc: Christoph Hellwig , Jens Axboe , Ilya Dryomov , Andrew Morton , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/3] filemap: add a per-mapping stable writes flag Message-ID: References: <20231024064416.897956-1-hch@lst.de> <20231024064416.897956-2-hch@lst.de> <20231024150053.GY3195650@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231024150053.GY3195650@frogsfrogsfrogs> X-Rspam-User: X-Stat-Signature: 3mrbw4g54as98aoydwh8j41q9sof61w1 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 2DAB81A0015 X-HE-Tag: 1698160235-58186 X-HE-Meta: U2FsdGVkX19FV79jQnjSbIwnDHQb/PtxJ/CLGg5nj7u1tOEDiYjr3nC1iaSe0FKic7RPG0kgJhAhMfHh1zdQzFKWdyqZsrH48rBsXuHpu/RY8AnGgOjhHH6wT7ysvysMxhbPBcbgXweu8VP3uPqhE0blpLQyRUioZwcxIWvDa8YHRteq8iGO4pGt90+dZB/QZOJWNq7mMdzKdjvrIiNCzHjbjss65m6LM+c6TYbHtpWf0XfGY0h872cyIskO1AF5svhByCmZzxVqgByQYanwL+X8XNxXFy3rOerUaL5puRvjZLgEwFn7FNuL8CKjFv1Oz3YSQwPSwRrCSnfSup+AZYsmNUO4FJRPNpSpdb+v1kpHh5oxs7EUcYEea881MqszWKy+qy9M3Q7N/glRJQL5Ido3xShd0ecoeO9p/sf1bUfnaHQOoZXxlb/RQk5rg+/sh1pHak5t+S6XG4nmORJLwZdGKyyA32jvaSJ6qRtwyUeHDAmco8ywmYTRaKeWaeKcyY2cF26T21Pq4iOtOdbX8Pl+JiTt25ELuAnk8NlMxQhI/gfe/n8NI0BGMvDPeave303cl357vlpR/kS6ixMGnGXOYyOmxSKqD+5ku1lg9WwxKEv1SNX1LL+5pOv7rm8/0EiFpktGk0ADDo/2JBx/AejVtYJaeyAL+AT3EhQaIRNQyM8snOmLxrqvRu8ymXL3NwUPGSjnRyzN7NrXQLVnDwGssdONRvlwc3YKR5ZauXUYqxMv9qOSe/7zQ5A2CqVo26xNrFGqqtMS62G1ocYlunvv25tZMrKxf3c0MxhmnQrS54odlSl5i4GoT8dHIbj0XE6ryGb31nAYji2q1LQ0deY6pQc3Ve55zoZHoyGJ85PHP1j8is6L+BgRTXVo1XbD5LShs3EiEwsy4hbeAvlSIJhirV2YS/TEwyL+G0RVcRQfXL58sgjIvUqGaWjPwPxPv2jZaVoayLr1ppe0Yfs 30vIjcTP 2iWEKqQJXyJiS07MFTaHi39LjSJD/BeUHWiOToWK/keMC/FbJfZSCQZFs5h+4fQdzWS3yPhM5aMvz2ELZTUomThHV+zTNcT0bO4LQaHbcj9GVQGHMoib156nx/HzK2VXX67VijNG9pdvedJw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000055, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 24, 2023 at 08:00:53AM -0700, Darrick J. Wong wrote: > On Tue, Oct 24, 2023 at 08:44:14AM +0200, Christoph Hellwig wrote: > > Add a per-address_space AS_STABLE_WRITES flag to control the behavior > > in a more fine grained way. The existing SB_I_STABLE_WRITES is kept > > to initialize AS_STABLE_WRITES to the existing default which covers > > most cases. > > For a hot second I wondered if we could get rid of SB_I_STABLE_WRITES > too, but then had an AHA moment when I saw that NFS also sets it. I mean, we could if we're short on flags, or it just offends our aesthetics to have it. NFS (and others) would just have to call mapping_set_stable_writes() in their inode initialisation routines. I don't personally find it a big deal either way.