From: Matthew Wilcox <willy@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Ilya Dryomov <idryomov@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-xfs@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/3] filemap: add a per-mapping stable writes flag
Date: Tue, 24 Oct 2023 16:10:27 +0100 [thread overview]
Message-ID: <ZTfeYzvFV7QoVT1z@casper.infradead.org> (raw)
In-Reply-To: <20231024150053.GY3195650@frogsfrogsfrogs>
On Tue, Oct 24, 2023 at 08:00:53AM -0700, Darrick J. Wong wrote:
> On Tue, Oct 24, 2023 at 08:44:14AM +0200, Christoph Hellwig wrote:
> > Add a per-address_space AS_STABLE_WRITES flag to control the behavior
> > in a more fine grained way. The existing SB_I_STABLE_WRITES is kept
> > to initialize AS_STABLE_WRITES to the existing default which covers
> > most cases.
>
> For a hot second I wondered if we could get rid of SB_I_STABLE_WRITES
> too, but then had an AHA moment when I saw that NFS also sets it.
I mean, we could if we're short on flags, or it just offends our
aesthetics to have it. NFS (and others) would just have to
call mapping_set_stable_writes() in their inode initialisation
routines. I don't personally find it a big deal either way.
next prev parent reply other threads:[~2023-10-24 15:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 6:44 add and use " Christoph Hellwig
2023-10-24 6:44 ` [PATCH 1/3] filemap: add " Christoph Hellwig
2023-10-24 11:43 ` Matthew Wilcox
2023-10-24 12:03 ` Ilya Dryomov
2023-10-24 12:09 ` Matthew Wilcox
2023-10-24 12:45 ` Ilya Dryomov
2023-10-24 15:00 ` Darrick J. Wong
2023-10-24 15:10 ` Matthew Wilcox [this message]
2023-10-24 16:14 ` Christoph Hellwig
2023-10-24 6:44 ` [PATCH 2/3] block: update the stable_writes flag in bdev_add Christoph Hellwig
2023-10-24 12:04 ` Ilya Dryomov
2023-10-24 15:01 ` Darrick J. Wong
2023-10-24 6:44 ` [PATCH 3/3] xfs: respect the stable writes flag on the RT device Christoph Hellwig
2023-10-24 15:09 ` Darrick J. Wong
2023-10-24 15:14 ` Matthew Wilcox
2023-10-24 16:16 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTfeYzvFV7QoVT1z@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=idryomov@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox