From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BE7AC25B6C for ; Tue, 24 Oct 2023 12:09:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B451F6B024B; Tue, 24 Oct 2023 08:09:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF5546B024C; Tue, 24 Oct 2023 08:09:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E50F6B024D; Tue, 24 Oct 2023 08:09:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8DA356B024B for ; Tue, 24 Oct 2023 08:09:55 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5B69AA0EC9 for ; Tue, 24 Oct 2023 12:09:55 +0000 (UTC) X-FDA: 81380236350.02.FFB4D3F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id 165DF14001A for ; Tue, 24 Oct 2023 12:09:52 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=pHo0uJ5G; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698149393; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cirv4ndqjxPdzRBdPJic5vaz9dOLi3WYy0YXH6TCVi0=; b=6K+s+Pv6/gXLMDqBD/J1z1rlvVonxbkU10hOgcmtZSczwIcGmJxIjyuEyPLNMHsuZWFPNp GvjZfSh0LFyRglyzPJeMRuKbfA/r1OkL0pAYNt++OX5cBmOdCJfa0O8uy7HT6536YeG+8E nMnRAxJfGza327tRt2ZWjha0zXtxXSU= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=pHo0uJ5G; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698149393; a=rsa-sha256; cv=none; b=nT/e3bKKLc2KPkgFoTAODwGN/JxzAZ6312CfqRFcn+mKlXsflHrlhx5fPkOtLORYuHvCnI 9/BQ0mc0HKl71nzX6S8/hoirbajI9+X6Q0G3Hhx9Bc5SiG/g2I6ZWU9+gGJcMbmdxAcQcR /EQ7J5GCqcS/INYI9FrjjNxBW7ISybg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cirv4ndqjxPdzRBdPJic5vaz9dOLi3WYy0YXH6TCVi0=; b=pHo0uJ5Ga4SZ4iq+fNOeCu2Fuh kthT3tF81ELkOCP0cRABWYjp+7x9icLmh+tcYokQOrc2tb3XPY7GH+8w599Uuc/GzeRvIcaZ3VM4g EH5WfRUincNOpQJxLwS9NOEU2iHloEIZOHUhM2nEhA0tbrfpaI2uAEKLVDUozd94I62JSggGGEYjO VSqWBbQM9pAKg7TudzHnun+nukAl5X72P1I+1Y9ejtnB4zHugb8fBDK572NqOaI26VX7AFOKOKX4a urmWo//FZWKNBUxXHmnbzBtV0bnaSZZEtyLiCVe0x3zUAC/9ArBKn2OSYq4bDHKihn2XrctpfTa3R dEBVHitg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qvGEF-002M4u-QL; Tue, 24 Oct 2023 12:09:48 +0000 Date: Tue, 24 Oct 2023 13:09:47 +0100 From: Matthew Wilcox To: Ilya Dryomov Cc: Christoph Hellwig , Jens Axboe , Andrew Morton , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/3] filemap: add a per-mapping stable writes flag Message-ID: References: <20231024064416.897956-1-hch@lst.de> <20231024064416.897956-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 165DF14001A X-Rspam-User: X-Stat-Signature: 9o18faiutthtgegowfnca1mfrxp4uqny X-Rspamd-Server: rspam01 X-HE-Tag: 1698149392-533306 X-HE-Meta: U2FsdGVkX1/Cpe1vP2t3IE5eAhzwB4epnPbmuNr6OBAqv/A/kTwEYAgtG6v8zR8GvOVQ62Z0TOQ+V8VjZvoU5myIBZ63qM1OgEh0qddiJewGAkThkpdhkpgu7jR2n9ZIzDrB061Fjk0vAo5VscGNf++Z5A+cEr8lQR8MucDBEAPEAMoB6dzdswLkD9haY5wFNKKZxRVk9YTKWcRPFXYKAoT8H8tF6sP/N97YuzQtKODB8wM+5IfVcZNTj3d32SwR4tqYbin1WBzOK1iQTSw5fsyw2PteRFF75NdwouaUQVh4V67TKX81DERQrbH9udokhO5ot/0BMI4cmcUywo5uu7qg0oSiHnT2T5iZ+rjQvzjge7LQ24BuuvIeXkWhNss7F3jIdsvZ2R3exJQTL2yaiQNM95MY2tkW5X9rIqap9JQnI/NqbrrE0xKFDSa50LDcqxEIC0Ar01jFa2xU9IEydmSXJS9Bz1hi2bJHHWuWbtXsbl/P5XVPuLVCNLDt9u+SmoOug19nr/LU2AxcUsvvYlrjOS8QYgv2XASCCfESDXX6NPd/03wLu74oyM8MdhxeaHpcHNSMrDtvxf5KP+3Pz9+44JCfyDWgbaTS10ZCNclZSH2pnFy8JAKWbZmvVzJEGKVKx4yp+5TMjwsBBX7+So4V5vf5y8CO12SzURtBkO2Jc4EVCjHEeLugBQuWRM8tUOtnIvlto5CtEwWYCuQz/0vUVpyYNSxvPEax8J3N8h6vj03E1eJ0URm/5iEnDh1Tbu5H42rTStVDN2cF5RQKeZtAqe4/qoQPMNqxarn8rzsyGYqiQryFRMOpcn8gxdLgAezjJCwjmRfis5L9VjqLCsvGLaq9T/nOJA4L0QxUz82WP3T8udOBZG0C2y5WWLOGn0XdpIiQRpFXAsCNR/LZB8YyzB0sW6XiBMHGcLG/tXBNXiXkUOQuC86oFeTP3uGKVjF/dGlae5GdG7mTUKv zzxF0G7E 4CoGCRxfSIgoyJ16XzGNyQshInbs+daHecbjlrmTtkvV5s+uVlbfY9U4Nz/IV7nfeQaN2+wA+0osXimMa9IC5F9vVHqKf5NhOKlRzgBBtC6/QNnFCNtBFmJsIAe9vsb8qP7GRMgtOzBbQMvA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 24, 2023 at 02:03:36PM +0200, Ilya Dryomov wrote: > > +static inline void mapping_clear_stable_writes(struct address_space *mapping) > > Hi Christoph, > > Nit: mapping_clear_stable_writes() is unused. It's used in patch 3