From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84CD6CDB474 for ; Mon, 23 Oct 2023 13:02:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F00E96B00CF; Mon, 23 Oct 2023 09:02:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EB0746B00D0; Mon, 23 Oct 2023 09:02:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA0A56B00D1; Mon, 23 Oct 2023 09:02:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CA8526B00CF for ; Mon, 23 Oct 2023 09:02:22 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 97C5240A45 for ; Mon, 23 Oct 2023 13:02:22 +0000 (UTC) X-FDA: 81376739724.30.A5E9F52 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id 4DD8310006F for ; Mon, 23 Oct 2023 13:01:57 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=O1nHYnwt; dmarc=none; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698066118; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B2lHdII7y0t9EFQrBPYsBPbjRefoYBOVWqu3w2mnv70=; b=2DVBDWBlCQFID0Kej6q+ytN5nWlgUOczrxX2PHNrrhIRlp09pr/TBwZnRN0LS32+hNUIJG 7p5mNIuakfxsONweiogzoYtCxhbC3twq/bNOnsUd8V8K4d0z+7iyl8qNGfuLFfvUk0h0Qt AWOxTfWmAv6wQYTuCYAxPqfJ+/gDbbg= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=O1nHYnwt; dmarc=none; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698066118; a=rsa-sha256; cv=none; b=qnGtXi8lmEboCrfpCgM9w9B7GhvvhcKurc66uMgC6HG4+yv53Sui91hw3puBELSTD/E8Wi uFFdvCDUURJt/V7S+SsgOEhC3qCoSIOH8gfi3/IH5RImJaiH2oG+5SIDibtSDic3HGgxeB LipLN7yOH4FM4gQEuODDO4aN4KFD8qA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=B2lHdII7y0t9EFQrBPYsBPbjRefoYBOVWqu3w2mnv70=; b=O1nHYnwtr7ojshj97P1daE4UEF nb6CYnenT2Dp4PzgY1CYu/WsX40Oh/1fRNWVRJP/GQF47FhDSoHDzowlFVIpoY28GxYHoyooq62ox zwlEbStLYVMTCk55e+ip/2VdpvtV/K4e4Vhx9QI/UCvPmseIfjKTWiHgNERgfSUe4z8Y1w4+aRX1x BgfBESIhpyHHHfhQxxNObjKZc35se6y1c7tIlBFDb+nPoLElPHagD4voM8wN2I2OJTMzCtgjND/6O sNaRdjXzcQ+BcPiQFgQ5uqsNvZlMZlekvzUuDdO305V5TUY6XEkyWxB1a0gf1gXCpRfWszttwCkgX 8W24FODA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1quuZ0-00DvI4-AA; Mon, 23 Oct 2023 13:01:46 +0000 Date: Mon, 23 Oct 2023 14:01:46 +0100 From: Matthew Wilcox To: zhiguojiang Cc: David Hildenbrand , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com Subject: Re: [PATCH v2 1/2] mm:vmscan: the dirty folio in folio_list skip unmap Message-ID: References: <20231019131446.317-1-justinjiang@vivo.com> <20231019131446.317-2-justinjiang@vivo.com> <2d847d76-2e33-4296-992f-1a6d00c66ff5@redhat.com> <02e73251-33ff-4632-9d2c-bc268f397202@vivo.com> <380bc753-5ee7-4bc7-a76e-a804d5179d87@vivo.com> <4eacc9e4-65ba-4fd9-bd30-575b0f23b63e@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4eacc9e4-65ba-4fd9-bd30-575b0f23b63e@vivo.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 4DD8310006F X-Stat-Signature: 4d4cie5pssqcuq4i7gk5bbe6rkrd67a1 X-HE-Tag: 1698066117-413663 X-HE-Meta: U2FsdGVkX192N5wNP71siNfNVnNIEAOeSicYkzBUObU6E6TgrCZ2YvoZWSRJ6HByiU3ObXC6bgky2hY4leLngxSoot5DgdY2d8umytl+sEOy1rCWiL2AF0kJcCeZDEAhe7aL/vV6gsvIiK8tX5+8Myd0J4ddqUqbaUeuiRqRV8gLJ75zbDmTY71YLDWRVgARl+KtVjT4hV4bT560Wv5+QFIAjiK63KHay8tXgaRX2/eOW6Wfn5g2LGp4ggZNCiReOgULelpTVQntUdYPVTMxM/ikxL/fFgk8/E3zpoTdeE2/y31L1qTRA6A0P2w9+1Mv8LU/1ho6fiot04la83rWO5zDFW4DCyvSJWTLJMVMlUHKVEgFwMMDUSf8KJmkDmfqP59STRUlQIilOkViZuhMHD1k6dnRnqFHIAjUCww5EQoZZ62YqdMucCAhwG7C/UGIVbVQg7VduEtr4CHA3laCOfIVKAkqp7I810uOLBa4VF8N2AVCkzAjmuZqKdlJKtnUPOIlM1idc6VeMJFlRwMQxaPr3PlO0ffoJx52fM//mS4gOQm52JK4SeHHbSdM+PkVzwoDw5wjDq6q68zA6Af537vM0mSU+bj/hycmM8g2MDuatH/CWAWQRXASOn2XCFlHNICPijH7GRCZ0b4wIXpzexq7S8Gq3Xbx6GjpRik8h9XtyXJceqr3n6NCn8JPVRjikGCe7I59UPf/Xu62s5xtQe0j2L1/9IomRoBOuUVmD6NlzRPTpKxEC2kFQh0eOKhkwmyQJ63VB1kEjy9KPoc3LY/L2hI/9ckHFO7U6NAfiiqdU5AvzK8LxqtbgBbxnxw+4oJ/6LjK0boLYrYvvMZK4mMoNxKqqIGMlgH62G7OB62bo9DjHylDhiXFA9hqdJkI+eQm3yPFqeDp7LxonthZAhR028E2+kJgxzumzTEyXA0tqsPhwijELMBa3Eb/47PqNEVA5WmERTtNGSFhKm3 VZiw69z5 tq1ksaiMIjIcMcWBHI5sDVddnILsfuB9DbyFTKqu9H40Nkavb537NOSrr1KfI22NVwWeDY65rqjCNkY0nmvk039gOmxI1asbQQuePRSdpvLPIaeDXzd0Kk7bS5wpOgALcxpuTwoLcxGbVyyrng6NjNDL/0t843tK0/wvtOmkumwbLP2gbXgovkFd6fQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 23, 2023 at 08:44:55PM +0800, zhiguojiang wrote: > 在 2023/10/23 20:21, Matthew Wilcox 写道: > > On Mon, Oct 23, 2023 at 04:07:28PM +0800, zhiguojiang wrote: > > > > Are you seeing measurable changes for any workloads? It certainly seems > > > > like you should, but it would help if you chose a test from mmtests and > > > > showed how performance changed on your system. > > > In one mmtest, the max times for a invalid recyling of a folio_list dirty > > > folio that does not support pageout and has been activated in > > > shrink_folio_list() are: cost=51us, exe=2365us. > > > > > > Calculate according to this formula: dirty_cost / total_cost * 100%, the > > > recyling efficiency of dirty folios can be improved 53.13%、82.95%. > > > > > > So this patch can optimize shrink efficiency and reduce the workload of > > > kswapd to a certain extent. > > > > > > kswapd0-96      (     96) [005] .....   387.218548: > > > mm_vmscan_lru_shrink_inactive: [Justin] nid 0 nr_scanned 32 nr_taken 32 > > > nr_reclaimed 31 nr_dirty  1 nr_unqueued_dirty  1 nr_writeback 0 > > > nr_activate[1]  1 nr_ref_keep  0 f RECLAIM_WB_FILE|RECLAIM_WB_ASYNC > > > total_cost 96 total_exe 2365 dirty_cost 51 total_exe 2365 > > > > > > kswapd0-96      (     96) [006] .....   412.822532: > > > mm_vmscan_lru_shrink_inactive: [Justin] nid 0 nr_scanned 32 nr_taken 32 > > > nr_reclaimed  0 nr_dirty 32 nr_unqueued_dirty 32 nr_writeback 0 > > > nr_activate[1] 19 nr_ref_keep 13 f RECLAIM_WB_FILE|RECLAIM_WB_ASYNC > > > total_cost 88 total_exe 605  dirty_cost 73 total_exe 605 > > I appreciate that you can put probes in and determine the cost, but do > > you see improvements for a real workload? Like doing a kernel compile > > -- does it speed up at all? > Can you help share a method for testing thread workload, like kswapd? Something dirt simple like 'time make -j8'.