From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF7AACDB474 for ; Mon, 23 Oct 2023 10:56:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E54A6B00BB; Mon, 23 Oct 2023 06:56:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2965F6B00BC; Mon, 23 Oct 2023 06:56:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 183F96B00BD; Mon, 23 Oct 2023 06:56:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 05EB26B00BB for ; Mon, 23 Oct 2023 06:56:08 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D0FD480516 for ; Mon, 23 Oct 2023 10:56:07 +0000 (UTC) X-FDA: 81376421574.14.38192C7 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf27.hostedemail.com (Postfix) with ESMTP id EE54C4000D for ; Mon, 23 Oct 2023 10:56:05 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf27.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698058566; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vp9jWmYZpkvc16waNCb0NLyunTdwIkO5xOxb3mychHY=; b=gFWkI+BQkfU2QGO33zIjim69rQ9Rz/9WnCJp5AyCkscI29gtVvfERqKV3xM87AdfUBHrJH X76bqPY736EPNlPK3H2M3e/NhN9JAqFeF0xjh4tdTSl5SfMYusUzz+YT3LmnuAjn4f8CZf oafMJb1eNoxPhNJE/3k8fDyDSLtw5FA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf27.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698058566; a=rsa-sha256; cv=none; b=LEO4uaJZUdvJ9/5nXc14JtN7QXU/1QfVw8UV8HtLGDwL6iREDXszYYcrbORqH42Z7eYhlG X5bWHDDbVxgVXcuMmsd6m0m1C+5EqUwcvEL6cBkbnnG4EfoGdtrOouA8OIE3rMUxgZ07oy CHY3jCbwNNoIP5mhHwQn48lQZdpeYgI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id F2165B81A2E; Mon, 23 Oct 2023 10:56:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 143CCC433C8; Mon, 23 Oct 2023 10:56:01 +0000 (UTC) Date: Mon, 23 Oct 2023 11:55:59 +0100 From: Catalin Marinas To: Liu Shixin Cc: Patrick Wang , Andrew Morton , Kefeng Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] mm/kmemleak: move the initialisation of object to __link_object Message-ID: References: <20231023025125.90972-1-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231023025125.90972-1-liushixin2@huawei.com> X-Rspamd-Queue-Id: EE54C4000D X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: p1h3eaencbhfs5embpuqbbbu8is41993 X-HE-Tag: 1698058565-432769 X-HE-Meta: U2FsdGVkX1+Oa1NLbuU6Q74jhGTNOE9jNrdpUcTZ9thGuOjgQR4MaqVQpEQW/u0oFj+pioAZBM/2lA/opEgt6yYzWSsuHA0FGErzL1nx31YOaiPkS0dKrShYGTfsozZnezORDxxr36fu9ZnFBOe+shsCMUE29QzXLiOwWbgrDGpb4J6/HMlWVq9NPNOa/9iC42SN7Cy5fHRgsPkEMYZzIswwk4wDN9EQ4oG5ONomoKrdL++fK3jbVaSDgb5TYcCR85LzY3NLWUzhtoJ25nQV2TensGbyOr7I/E1ZGe9njkL0D3bA2PflWfcqsaNyadOumUPiBLN5JLRNlgTfuyuWvUViDo8CCoJBpqyyVB9RTsS/S7zIOktvErpaGZBaXtjWBdZjndVEG5QTqCH/I7ozXFxznQ5rtHN6kcDhGwbm0GlUXZ1oEtBbRP/FZUpycVs8AQn3+j43f1EhGrAIJ4EQDZ0rjUNfGBJnhB3ooeJU2LaKQ/8yoRkv5jnypjJCzx0BE0Sd6rkV81oaK6uvfZgg5nRPYYGGhtHJRKSuoKC5Eduxynx/UENTHRcUfOwDm2yWGUQ5iKW2Y9tfgvQm2g9gNypyR2VC2qxuUes6yKqXBgp0Bkk5lyIACPL1pU6OGAvcqSLQh+PD0jAFQMQp50uJk+WspsqA17ksBT/ZhTmm44S2CSBvA6Tx6ocFV7aft3TwOEQQsAeE8SwTV5GXu0f11A687Ep66Tg8eGd+JPf96eTkwMuednzxWeB1kUhvKKgXe4Le1QNH6TeTWmofYLP1VNLWPqwFSrP4EgbXVNjdP30S1SubDWmYpg1liv/zmYVd8gGbjyXxWk4Lixx4kpcbduW6dc7CfYpW9R9ZZnG/o3z6cnaBeFR7ebVM8PcA0VMRXz8oD7ryYuTXBs4BPWD9JXGF09uX3/04jZs7NwIzcp0Sc1SVXk3W2ly5OGwXZCAvfgPjMOvfTLSNYUNDtfz UuwzPTsG ggaZVzEwx2HEaaUoRQzXvSpAqCELI3pAXNZvscf/xX9IqGqAzJ/l/nsIJ4ZDRB/ODekgGxbObd+2STPEgMteNzQWFiKnb4SdM15IXTfxPlXEMwQB19rmeXFJ0mS01j3mRJmqG0UxBElq/M9GL37s4f0Xx/HnUj1g4zyOOMLjiekBqIgo/UMFJwszq9dmfsGiHA8PQ40VhC/Ctn0hNF7Z9qoG/hKgail6p9wSMvDoY+UsxlG2xksParg/HuuN3Ty5s/EAKVo5ltfZrkol3OkZjbWkd1aZok/wb5ns8GCZN0pa4X4rdyL3NlN/xxt70ZtS5B7A6sEyTtJWE0NfoI+5NJsTe8e0uA4t1s2M5nFkFnx+sPLW871JdhpSxF4sb+d5CcPpAKYuAnkUJVeDA8IwBv6TpKpm9XTPnzxKY8EJOSQqxw9H9lF3ClzKxzBtXgi6QGLOxUqK+T2Xscix2PfP6W0V5UpQP0sx79W6oGjzherxb3L6PRJ1NflVY4A1R3E5sXdBT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 23, 2023 at 10:51:25AM +0800, Liu Shixin wrote: > Leave __alloc_object() just do the actual allocation and __link_object() > do the full initialisation. > > Suggested-by: Catalin Marinas > Signed-off-by: Liu Shixin It looks fine to me. Thanks. Reviewed-by: Catalin Marinas