From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F8C2C001DF for ; Sun, 22 Oct 2023 15:46:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 10C156B0075; Sun, 22 Oct 2023 11:46:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BCB76B0078; Sun, 22 Oct 2023 11:46:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC5E26B007B; Sun, 22 Oct 2023 11:46:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DCBFE6B0075 for ; Sun, 22 Oct 2023 11:46:46 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9993C120928 for ; Sun, 22 Oct 2023 15:46:46 +0000 (UTC) X-FDA: 81373525212.15.07D7081 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id A10504000E for ; Sun, 22 Oct 2023 15:46:43 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eqGNzCm4; spf=pass (imf27.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697989603; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UGgrk7U7ziyea5cunTO+IloGn3qNk/rZsIkV0TfaQNg=; b=ITW4kZz/aMFf/eGSiPnUXmLpg+01KRkMVoGLWU5CFWuQX3euYuyesRs3WrnDh5rXntHqb5 NX2up2rqwwVMTYOL7tmufUUa47uQqh4ARNEf3s+UVAJxzrHlnSJCVCQe4S8FOWDzpOjTti rvZYCRdnyU2+KOLlvJMEbuYvygcLONA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697989603; a=rsa-sha256; cv=none; b=mdE3knJwvtL5XyUVyOFZmtqCz62NUBdct8DfwLz7uH37cwWV2eXQx7Qzb1XnRfxjUXDGV5 IevslyrMa0nSa6v+izxeWBtsEHnUKrfs3mtkby1k6CHCE/C85CfamXuqjp6d+qJy1n9vRa arwchbWSU/6UmhH0kqcEK/wHJu76Ius= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eqGNzCm4; spf=pass (imf27.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697989602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UGgrk7U7ziyea5cunTO+IloGn3qNk/rZsIkV0TfaQNg=; b=eqGNzCm46pOiRBdQh4/5XTzitDNT5KI+VKe9JTq0koDxCCtojOsV8qAfCWCqQ39M5qjR4W kZkhjtB9Tonc8nQwCyClz6YdkvtFavFr9uKbbDI20U0FRlLYRoGeVggpIfK9uHdqCtowZR ic9v+d5Y+MRRX00zmDgtfXaPhlOmrmI= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-296-t2uD0jzaN8uxc4sjZBbhWA-1; Sun, 22 Oct 2023 11:46:35 -0400 X-MC-Unique: t2uD0jzaN8uxc4sjZBbhWA-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-66d3f71f49cso8867046d6.1 for ; Sun, 22 Oct 2023 08:46:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697989595; x=1698594395; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UGgrk7U7ziyea5cunTO+IloGn3qNk/rZsIkV0TfaQNg=; b=ZE283ssqD5yeYlshrf+M8Uzxr9rb464Ul0e/J1KEw2xiDXnu3zeW0aCo5KwJWqCK6a kSdomlJjDMNuU/75E/Ws8lZ/rUiRqMa6U5X6jUOPwbuo0IskRcPieNIhsBs9AVPUIRNJ VaZXHos4rivsteqRioDntVLTsVED9+x3vYc1gLjKzqEE7Ibmg5vloHEWSCrRDSYFFg5g YLxTjY2pKcukO8a1MybdbrVqfbqiggQbH11w+ziY3vJVhbBJrxhF0E7PXs80RWHWUTan bhf2Ep252wdFsFhXTaOvWKRkHzrk2n7XabKTR1HeMuLWBfXP/Va3LmaDnEo44bCm+XHr 4slg== X-Gm-Message-State: AOJu0Yyed8FblZ+4fEOWI/Vf9AgCd4st1VgJpZTQyciLolm1AOQK9lKF z5AC/guLAUj7LPlw2BsebSHmnRp/uumSryYo+Qg17MjZWkWelXb4OCYp6YH10+OgNscKqXrCZUz dqsY3B7ERcAU= X-Received: by 2002:a05:620a:2b4d:b0:773:b634:b05a with SMTP id dp13-20020a05620a2b4d00b00773b634b05amr6696819qkb.2.1697989595293; Sun, 22 Oct 2023 08:46:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEWN6AC503edm3tNF4Vnyfigq1+yBTgZzdwoQzZvT6nDeUnhRhK8Btp6MrUdseV2H9geWSwow== X-Received: by 2002:a05:620a:2b4d:b0:773:b634:b05a with SMTP id dp13-20020a05620a2b4d00b00773b634b05amr6696793qkb.2.1697989594852; Sun, 22 Oct 2023 08:46:34 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id o8-20020a05620a228800b0076cdc3b5beasm2100836qkh.86.2023.10.22.08.46.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Oct 2023 08:46:33 -0700 (PDT) Date: Sun, 22 Oct 2023 11:46:31 -0400 From: Peter Xu To: David Hildenbrand Cc: Suren Baghdasaryan , Lokesh Gidra , akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com, hughd@google.com, mhocko@suse.com, axelrasmussen@google.com, rppt@kernel.org, willy@infradead.org, Liam.Howlett@oracle.com, jannh@google.com, zhangpeng362@huawei.com, bgeffon@google.com, kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v3 2/3] userfaultfd: UFFDIO_MOVE uABI Message-ID: References: <12588295-2616-eb11-43d2-96a3c62bd181@redhat.com> <8d187891-f131-4912-82d8-13112125b210@redhat.com> <81cf0943-e258-494c-812a-0c00b11cf807@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: hcms63wkoukzhmxque3mho63fj86kxdw X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: A10504000E X-Rspam-User: X-HE-Tag: 1697989603-899933 X-HE-Meta: U2FsdGVkX190PbGeonr9XsC6H7TNpBc4sQCZG6vP46ZbAfMpeM2gcLUi2tLOA7PHRrtHJnXWfukEPrQITfajxfTk6MUKdA/JgtRMzD4cT6XkiguA8kP8d+U2pLtzMaznXq8Ns5VTw2A8/LgX0SCkC/UMEzsJZYhLN+zMouz8pDU8Xw71uWBr55BsMaVJOQ68Rljn2K0SLTllcwY1YqeL6MzEvQDe3YXdZibRZVil4zXjMKHIfOBbdWIELH8EPMJeeFV/hCeVwwHJxRMjAkZ717jhyMJLIVejLOmE/TEyNIjbXL/O6a0kIacqcEkhPbUAyAM4QbY7Z0aY6UVvDN0yqS4sqFNGxMHrAYk+9nTD68Kmt60WrC3PsgpjWhDAxzUilsZr28XwJTQ2SBZDXJ4hHKsOf0rDU/Iu0y16TEyL7iDVYg9kXkKxxkfR3t2RTpU+kX1+BkGKqlFQnvRwpacJzC7juLhZmwpP4KAe3P2eY9/kE1JsAx0jj6egp+7/181ZwNC/u9WjNY6NyysNkG+P/g5aoQmpsFx9nccSZLBASodN1piP2VWeLiAHpKbUk3Cx+QzepicSJnKuPPdi4NQctw+CFoCRaMs4rRpNU2DMB69AcxH5AIT1sSXpoXjz6SsTA7Yl7UBtI5h7uR02rLRUHiw6027j4X9xw3BPDA2ixP27Ct577SmL690+Knkkfr61E9nLSI8fjX+6n7X6qoxBzw3T3ART8sWje391gGsynlHqKWnX1NsEYaCpUgQgWVfDBWKf/uyFEPFuSHgYZz6eRp+24eXRqFN4n1UuwVpA7xq7w0eT1YSgOe/mDmQlLhMRAnvAMXVKYwYpxxntaZTTvP/deQrdPU9+g2gHaJhBDTnMiIPQAv/MW+VbeS9eEK73VLu579fVJRPnx3HeUiQnWXv5KF29pW0b4pzChDzwOWz3h2Kjb21whSt9Md39ScWaYBH2CMcxZnaOjcT6mBb V3OVmEC7 cYlQMgFOnqwWGsiITHQ8EKupY3eZF1I6uQq9jfMoFLvChJqe2TnMXskmBa4HStzES4fq7uJQwbgPh5TC8Xb9Y8ecoz/wmWFigc2+nir2N7/LwaeiF5UrQbGa2eXdjBekzzh2kzIxS5klZCAk8yILuby0q4dkSTdgzQqh+Fhz2m/V3bgD8R98aft4Qi8ougT8Yfjgj1EgjeGvsRBN70+flsyTmawBgTGN4lX8tBI2qDbJmBzQhpZA2nVJOV/KJebXWflTsM6wo3ojNTp1Br2dn0kBpgWI49H3eY/We0kLDll9M2QzvWsgJpAj/AOmWsl7YKPTrCPfv+T6ho887jxMJkwMs/o7IdBrY0o44Ifnfs5BUStX5ez8GQ1O/is/8Tn0O/mQZza6WfhXMr1bCC6Cr/SfKaVxAuSq4r57J X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 20, 2023 at 07:16:19PM +0200, David Hildenbrand wrote: > These are rather the vibes I'm getting from Peter. "Why rename it, could > confuse people because the original patches are old", "Why exclude it if it > has been included in the original patches". Not the kind of reasoning I can > relate to when it comes to upstreaming some patches. You can't blame anyone if you misunderstood and biased the question. The first question is definitely valid, even until now. You guys still prefer to rename it, which I'm totally fine with. The 2nd question is wrong from your interpretation. That's not my point, at least not starting from a few replies already. What I was asking for is why such page movement between mm is dangerous. I don't think I get solid answers even until now. Noticing "memcg is missing" is not an argument for "cross-mm is dangerous", it's a review comment. Suren can address that. You'll propose a new feature that may tag an mm is not an argument either, if it's not merged yet. We can also address that depending on what it is, also on which lands earlier. It'll be good to discuss these details even in a single-mm support. Anyone would like to add that can already refer to discussion in this thread. I hope I'm clear. -- Peter Xu