From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3ACACDB474 for ; Sat, 21 Oct 2023 02:03:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 27FE1280012; Fri, 20 Oct 2023 22:03:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 230268D0008; Fri, 20 Oct 2023 22:03:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D1BA280012; Fri, 20 Oct 2023 22:03:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id ECDF98D0008 for ; Fri, 20 Oct 2023 22:03:15 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B9F2480B96 for ; Sat, 21 Oct 2023 02:03:15 +0000 (UTC) X-FDA: 81367821150.04.8E47013 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf02.hostedemail.com (Postfix) with ESMTP id E7EDF80005 for ; Sat, 21 Oct 2023 02:03:13 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TgBOIzzf; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf02.hostedemail.com: domain of htejun@gmail.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=htejun@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697853794; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E4BfpSktvbeUKArir1bRj5PHVyuN50VNESHk8dlYnFI=; b=YpgUi4/M5O1SFpY7i8f3E4VmqzDl4g6Z9C7rtbx6C27ZzlBRgRU77jLqWehJz639xvRFNB gm4vRjOfB/qLxMKbAsiVOVMKPwKNoq+yc43AAH5VZhzt5OX+u2ST05QbyqmfjZaZtVwz+L 4eRhbZGG0fPOar6YkPLC8IlBW89xpOs= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TgBOIzzf; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf02.hostedemail.com: domain of htejun@gmail.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=htejun@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697853794; a=rsa-sha256; cv=none; b=gE3dK/fqsC2mLsj3EKwE+tRGA0sOBPF8XzJg4SNGP8khoxNVnLPIbux7xbfzQ/oRa3Gz/D IWd34821y7rhz78L3KiNbuRI1O6wFlS0MfWiB1ZCeliKaBtrfQwOejqrO2prh32hL9DCpd 3cIKKuZIWU+F0Grwkr5GRG/n/kd7Yw4= Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-6bd32d1a040so1391810b3a.3 for ; Fri, 20 Oct 2023 19:03:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697853793; x=1698458593; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=E4BfpSktvbeUKArir1bRj5PHVyuN50VNESHk8dlYnFI=; b=TgBOIzzfg3YMyYbFESI32lrK8XgfJjoiOAX0FBpx26yKoGM+ZaW7yRDjc2g4SNGFh9 100V8+bqaZAryX5hyWfHUKyST7mLCgP6VIHHESl0tXCgaEHhhkkZuII64qNSOG1038BY dvdUOwz6P0VLYJnIKQgaHilDKdnnCRz/+5ox0/FMxOaTx+b7rfgrXM94SuwN68MpUYrE DXyRMIAXQ/rRS0FYXuuew3XARnzVpdRBIlCH4CWNfs6/n65pdje1yoyrOGI81eoVJPKo 1j03Vf3yvkKc1S0UAa9lKCo+enhHfJY39VYRyyGescBcBORkZVOGZ2YLg6tjCcyKx+8m xp6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697853793; x=1698458593; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E4BfpSktvbeUKArir1bRj5PHVyuN50VNESHk8dlYnFI=; b=NfZ5VkFTHIZ0tG5gF4XJ+BfunRHaLK2qqPh1adD95XNp0e2TY8siIhOgsmzXfldST5 t7AUx0u+31914bbhbZlvYXpPDHonaYR6Ml3A6oZKAjq1DxhXzmg7q/cqvgFpi5XTbpfH yU5OtDmt3X21wtnKEA4LCAABIBxsAkByAriiRncb/36TRqdR0hYKZqKMayvil2PotOv3 qEWEpVFSNbbdB3DgdlglpHJraWGuIsE7oiK1b1xqVhmYjYXtRRbDeoLxR8zLeVelVf2u C4DoeTEBdyVWQJrYYrHynoJAW9rD/xbb7nNuVxZxZfX9EyrM0nObrQvxbxEXktatNKbO xpTQ== X-Gm-Message-State: AOJu0YygmDLhz3lP6uYUJdxEM0yQS6bwqMuYAJZJ4FjmgRtG9KZbqm7l 3ThyF0dhxfv80SkVOJrtMxo= X-Google-Smtp-Source: AGHT+IErUW+BgARy7CTYpTCHlLimvLL8d+UwcpVOFMaZGL8SWqCavOGXY9zgrCCFvRMxPu/yeMrR5Q== X-Received: by 2002:a05:6a00:10c4:b0:6b5:608d:64f6 with SMTP id d4-20020a056a0010c400b006b5608d64f6mr3817371pfu.20.1697853792518; Fri, 20 Oct 2023 19:03:12 -0700 (PDT) Received: from localhost ([2620:10d:c090:400::4:a906]) by smtp.gmail.com with ESMTPSA id h29-20020aa79f5d000000b006be7d407a11sm2242657pfr.178.2023.10.20.19.03.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 19:03:12 -0700 (PDT) Date: Fri, 20 Oct 2023 16:03:10 -1000 From: Tejun Heo To: Hou Tao Cc: Alexei Starovoitov , Dennis Zhou , bpf , linux-mm , Martin KaFai Lau , Andrii Nakryiko , Song Liu , Hao Luo , Yonghong Song , Daniel Borkmann , KP Singh , Stanislav Fomichev , Jiri Olsa , John Fastabend , Hou Tao , Christoph Lameter , Andrew Morton Subject: Re: [PATCH bpf-next v3 2/7] mm/percpu.c: introduce pcpu_alloc_size() Message-ID: References: <20231020133202.4043247-1-houtao@huaweicloud.com> <20231020133202.4043247-3-houtao@huaweicloud.com> <12196815-c2ed-b5cb-4bda-bee794d8d082@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <12196815-c2ed-b5cb-4bda-bee794d8d082@huaweicloud.com> X-Rspam-User: X-Stat-Signature: 5uwfmbogowyry8ojn5rf7ar1nduqnxw5 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E7EDF80005 X-HE-Tag: 1697853793-361763 X-HE-Meta: U2FsdGVkX19ueKf5atNqasAzpf/VTTehat75ezVJ6GAviObuJOk2BUHjvIZA+DWNfA7KSuylBMs9DWw9RBH++ob90olxDyN17ncONjfW8NexAdPtY1t+K4wWhnSdQ2beTlz+DTrL1u3RqtJv2xGpM/5j4U5hhsDjaZyT4xNgCmkM23hIUZLh6JJ/HKEmUV0PnDd5daF4GbI513S+Zun+ItOtHh37Zi44nl03causmzVfaXWEpm2lp/hUb2wyNXlpQMmvPTzLywFpd+hfqL2F674vW0viKr+Py63EnA2f6/F2/gBXUuRI/X+MMeQwdI9xvi1Dw1jWWGvTTDeeNmpDswZOTEaxBYFKZ+y1K+zmhu0hSSUBMwYGwYMqIwNQuy2SRWODeu4rXV7/TCmSdA6F7w57mZ2GCIGKsZi+EmAhwre6Y7PWSev6lOcq3Vt3073XGBafdEg6Ow1YtokJwFAmqoSiY1QfgftT/m8HSCC7GY2JZ0aoOvMgGL0PrPR69ExklqQEP3m8hv4n9B3pgPqNtEepXOHuoi6Qevh2aeW85BEQT+FDDwx7DAnebjpdj9xqZkk9LWWs9y0iRgqek9lghrjIb7NyUzFpTEJx7UevtFoi/+kxGFCNZRTzwuAnzV6l4jrXDvVsljClvC9JZeqvfhmpYwvE7qXOfoaQesG6XDwfoXvcCXTT5LaaUjJd0iz3diviEooSraTrWG+SBwVeLWZ9pqvyGDHc+eUaVMM6kDMTXqwOAj3lweAJoEq8ncI/SPAwHTFUI8TzAMyh+yza+0OBtUsoLopLenV8NH/UIbuwqJgfycAyj534REWY2SIA9FqlNwSfLzCZLz9Iu9/zXGtiUhPysmE/kFmg3ygAWB/MBunNXYitWC8h3jsT3P7pJ9DsRy49/Y3Xnu/qv1EsVeyMaFKLbbIiXXQXKDDsf5Qm6+PZs42U1LD0UCBY71Xk/wMVaWQgzfMT1FfdmwP P3NpwjGR o1P3fUibqazJwzvgG1TVaVtqCoXNPoEKWE5vZBZuO7vJaPfpESsFtGdhmmM47jWJqzUcFefL2GN+8rbo5sqWC5nC1mPAPnArZ2cKbSTkD93Z1WwfvRjcR7CiR6BDZrMV47g4CNRUkRav5lkExDJXU2ohjXRiVH1D8snUgcMeg958h3H8phKQxJg+MQlkW13KeiEQLCl84MPM2VS/3V1jZmvcsGTQuI49xyBtqSR2ROIvdM5KhA6vkgNM2wnNpUcNfV5mbXe6TPosiWxl6s2dznDN7YAglQxsFens37rrp7aAMcYQ0ky8cWCQlBciL+11lW6Vfjq8poreQ3h0rK4JCrqQzcIZspADOHAzD+PI/SrIRem4WJiyT5Ux3VUKc81KUTVka7JmKFtJs/JC4A71c5CAgB2wenNdGc2ZQoYGjrMxGT+5rLfnWcjcxHwQ2woIMQ5cLSoJgzxKfTNF1QzeGy6x6kvYqdpY598GfplwbJXmYnsTLgwKCAQfUcmfJaQFfraX3Lngdi93e53p0BKOX7fAi7g3glWKDWQMGBR91wVhbODwoPO/TfvSbdb7M2vbPMxzMEb6fIxzzb6L+omEKMkwomid4c60MH2X5ge3o7saE6MD9U0K/IHIhew== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Oct 21, 2023 at 09:20:29AM +0800, Hou Tao wrote: > >> Eh, if it's trouble I can fix it in the future. I know single space is > >> more common, but percpu was written with double so I'm trying my best to > >> keep the file consistent. > > Ok. Fair enough. > > Force pushed with double space. > > Thanks for the fixes. When I copied the sentence from the email, there > was indeed double spaces in it, but I simply ignored and "fixed" it, and > I also didn't double check the used style in mm/percpu.c. Will be more > carefully next time. FWIW, they are double spaced because emacs used to default to double spacing and would never break single space when flowing paragraphs. e.g. If you write "asdf fdsa. blah", it would never break the line between fdsa and blah, sometimes leading to weird flowing. I just accepted that as a fact of life and got used to double spacing. I did change the config quite a while ago and now am using single space like a normal person. So, it's upto Dennis but at least I don't mind gradually losing the double spaces. No need to go through the files and convert them all at once, but if the comment is gonna change anyway... Thanks. -- tejun