From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5811C001DF for ; Fri, 20 Oct 2023 18:03:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 730CA8D01D5; Fri, 20 Oct 2023 14:03:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E14A8D0003; Fri, 20 Oct 2023 14:03:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5AC8E8D01D5; Fri, 20 Oct 2023 14:03:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4A7058D0003 for ; Fri, 20 Oct 2023 14:03:38 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1951C1A0851 for ; Fri, 20 Oct 2023 18:03:38 +0000 (UTC) X-FDA: 81366612516.09.74CB22E Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf30.hostedemail.com (Postfix) with ESMTP id 41D7C80019 for ; Fri, 20 Oct 2023 18:03:36 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697825016; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XpII6b9oaZNjQ3tCIXcHqka8Qic7Krz7uMGzb0VJeiQ=; b=iBC0F80200nuhDm0FjCXPjfbJIv50D3YecUJDVDaxu+wVIS+oZllqS+DNPKzvIFmOVIrXE nlLnd4JeaSYlzM35046DHKgAZPEr7vAGrvQVJw+PeJdsvI9OS40B8vfZaLBuoIH7QnIxNl VCxR9dNbQ1LFV3QNZCFL4PgEYBNUId0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697825016; a=rsa-sha256; cv=none; b=AgqrHCty8dPPXopAroI1EkRi5HyLB/BL4VyIsUnZZoUaP2Ia1nzhx7KteGUDbqC4oNnZn7 mTmMcM8hImzuMtlCxOYRWx10jiy2nCsItiYPFsTNIWxDW8gfLj7DNClrHI+zP3Or58i0CT rfCRPHZ4SvXy/5PXM2dk8Jd7wUS8PLY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1c9e95aa02dso9062505ad.0 for ; Fri, 20 Oct 2023 11:03:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697825015; x=1698429815; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XpII6b9oaZNjQ3tCIXcHqka8Qic7Krz7uMGzb0VJeiQ=; b=dJsxuK4kQspBuU90cVr01jTj8jqWCiyn9R/76utAThar4XMgrv+h1U/6QKr6Vc3jk4 2kpxCoeFF1IhvtKFTvlG6tIJ5zvbZwGEHZ71vE0sDazUwa+UoEikTemR+4mJlwOAYxyA Gl+qnxidA3fOpN8RB3doFv+Z4m3G1niWfBdG6bzw9K0vHn/WEEU6Jqww9LhjA/EPQHF9 AmyBQv+4Sgf9jxBGeF1NJrVkfHNNTe3nhc1RJUifuf+Fz6j8KTlsyNV1yS/nxCvnuzFX 7P2EPHwLjJFJY6PCSgpGlhK8vohZh9hg5zVSAIusi1FlpKpGxFdqVLppgVRADxVdOazd ZutQ== X-Gm-Message-State: AOJu0Yx5CPvYrVbFNl1g3JbTzxnghN9jZIwHXqhROAFgL8J0OOy3Wavg e2Ql0Ume/+KbU/RR9hluC/4= X-Google-Smtp-Source: AGHT+IH9has0vvBvKB7gt/ycVawFyKqF+p+rd0E80S6fa04jM38bTfD3gU/ycmLy0/uNYwt2X03uIg== X-Received: by 2002:a17:902:e841:b0:1bc:edd:e891 with SMTP id t1-20020a170902e84100b001bc0edde891mr8878263plg.1.1697825014875; Fri, 20 Oct 2023 11:03:34 -0700 (PDT) Received: from snowbird ([136.25.84.107]) by smtp.gmail.com with ESMTPSA id z11-20020a170902708b00b001ca4c20003dsm1812068plk.69.2023.10.20.11.03.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 11:03:34 -0700 (PDT) Date: Fri, 20 Oct 2023 11:03:31 -0700 From: Dennis Zhou To: Alexei Starovoitov Cc: Hou Tao , bpf , linux-mm , Martin KaFai Lau , Andrii Nakryiko , Song Liu , Hao Luo , Yonghong Song , Daniel Borkmann , KP Singh , Stanislav Fomichev , Jiri Olsa , John Fastabend , Hou Tao , Tejun Heo , Christoph Lameter , Andrew Morton Subject: Re: [PATCH bpf-next v3 2/7] mm/percpu.c: introduce pcpu_alloc_size() Message-ID: References: <20231020133202.4043247-1-houtao@huaweicloud.com> <20231020133202.4043247-3-houtao@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 41D7C80019 X-Rspam-User: X-Stat-Signature: owye3y16kekdi5wcnay8gezo3uwfxp7t X-Rspamd-Server: rspam03 X-HE-Tag: 1697825016-281913 X-HE-Meta: U2FsdGVkX1/rgY4GsHS0LpJ3tFXiNsTVoei8Ta6HjZR8MUF1RYXNZPpTpx9qfEkcc+WtSD+hw17LJN2Tak/MQppV2ykzCxnCgjsTsT6u1uLX0V/stkvie9rEH9jry3h3/j+mMY/P1ATzATLtj5ME2FVm5kEOtZiIH6yP4SQR/Tbcbkclj7QLtitlDDKtmLpi9eropZQT8Rs+zI0U1ls0rDZqmvLm8Cjr/oSYLuKBmuerIdkhOkIyirIj5Ccb++In27hH1GrtTirrE9aDV2QpRRZu0/BFgpZR1+SED7k76azRJRgzyzUmHT0Om+wHrP5I10gIipapxkV8SSYUqgKXsHeX+XWrEhuiRFa4HgNUXTCk1mAKADBr0DcEYGBYBPDrNTmgKY+m5RbAP1q69Z1YOQfjsGNMnzSyxpkla7cTyCEOnwZGbd6LbDVmSdbRN+JtMWk29qCpa1VnctalxVQzUHexmZgKpZRF09QWeB0O6P0A/QcF+cNVGLevtsROz/j5hkOvGMgMPKvuiCg8WrWmpAxhZ3juF2jyHgJQ3s6Az/wxpe6jFr93rqH+xgvmIOdQRSoLiOG6vneaeNcmkl9pmz5epp025PTbBZjvaCJ7WX4uRuo2BoIXrTj71nZ8a2ZMZ8I3wscX6XN6jR6EKzPHOlX4WQ737Y14j+OeCnxwCU4xEaXd0FnMBZuIGMW/5bkOHGt4Q0SqiFh8TrqFKV9dVuIsSfC5IM7xnn1Zew5U/54lz0P74ZRHu3SZRJs0VPXy3Q00S8xJkl/e0l+Gj5GKOW/kRiCbXEntDoFacUR2vdn58KXFoYt4nLaZtVAIF8cK1q1nJ99mbdK9Wn6Zi0qvD4iU310eQ9Nz5DA6tEFv3NRJaPfJribrcMvQFH04GZT+WL/U8N29eRZQoHdrgOpYvBPk2C2Gq/4xaliIDJw2QZ3mLX3QN1N0MQX6JuuUpm3Ih2zuYVa7k9ZRM6h7U4S ouVFm6kN zAntuTJNRrIl6eR66SDxusyqgW7szzexDm4H9PdaFvdTk8tMZ3iutisQKGTFKeBYZ6pq+EC7Vx//Ffgmw+nWkzp+0LJopWcOg3IH28ZBCp0F/Trf9EE+cEPWc7Ke0zDst2t/SLN6LwIJP56qpenN9iiGMiHr55K09YAZZU5IUwX5xFwFypTGqf6vu1vIM795vM9/LiYnewpPCfJgCjfLWH6cigvPpPO65gB8TXQXoqv1IgZO91h9o86c/V+k+ID7HFOePwX39nDQzz8+as8cklvBryDWrfDJt8rNjubf0ZVPRxvbc1HDSPlmsJ9sLx2abUw3BCOxKs1b55JYslhADXSgZr+Rq3isKOX8SrlrYEi/B5pmvO78zM+Ul7ead9uNS1UuzK1MjQVjudAbNj5pUFMAadedwMs2wHR10foAg7aXKXTVORgA2Of6o0R5AndwMOtF1CGHrkLaVa3FFy8R4SQNNGIAVZwfle9iewj4WlVcV+WvJCyWe8ycN4UknC7xIPPD9bJgjk2tMHMR2Fh5ie5b32oGv45z8eHJlufRlOyma6kXa/tO8nreSS6rWACWkr7kCdwjK8k1Qb7ajMw9wyzmaUX+V+6kfURQUZ5Set1LlPydAjryWnCjeCujLSz4/U/e4RHTj3wX5/hRrG2Gzm9MC1L+1RyPakryu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 20, 2023 at 10:58:37AM -0700, Alexei Starovoitov wrote: > On Fri, Oct 20, 2023 at 10:48 AM Dennis Zhou wrote: > > > > On Fri, Oct 20, 2023 at 09:31:57PM +0800, Hou Tao wrote: > > > From: Hou Tao > > > > > > Introduce pcpu_alloc_size() to get the size of the dynamic per-cpu > > > area. It will be used by bpf memory allocator in the following patches. > > > BPF memory allocator maintains per-cpu area caches for multiple area > > > sizes and its free API only has the to-be-freed per-cpu pointer, so it > > > needs the size of dynamic per-cpu area to select the corresponding cache > > > when bpf program frees the dynamic per-cpu pointer. > > > > > > Acked-by: Dennis Zhou > > > Signed-off-by: Hou Tao > > > --- > > > include/linux/percpu.h | 1 + > > > mm/percpu.c | 31 +++++++++++++++++++++++++++++++ > > > 2 files changed, 32 insertions(+) > > > > > > diff --git a/include/linux/percpu.h b/include/linux/percpu.h > > > index 68fac2e7cbe67..8c677f185901b 100644 > > > --- a/include/linux/percpu.h > > > +++ b/include/linux/percpu.h > > > @@ -132,6 +132,7 @@ extern void __init setup_per_cpu_areas(void); > > > extern void __percpu *__alloc_percpu_gfp(size_t size, size_t align, gfp_t gfp) __alloc_size(1); > > > extern void __percpu *__alloc_percpu(size_t size, size_t align) __alloc_size(1); > > > extern void free_percpu(void __percpu *__pdata); > > > +extern size_t pcpu_alloc_size(void __percpu *__pdata); > > > > > > DEFINE_FREE(free_percpu, void __percpu *, free_percpu(_T)) > > > > > > diff --git a/mm/percpu.c b/mm/percpu.c > > > index 76b9c5e63c562..1759b91c8944a 100644 > > > --- a/mm/percpu.c > > > +++ b/mm/percpu.c > > > @@ -2244,6 +2244,37 @@ static void pcpu_balance_workfn(struct work_struct *work) > > > mutex_unlock(&pcpu_alloc_mutex); > > > } > > > > > > +/** > > > + * pcpu_alloc_size - the size of the dynamic percpu area > > > + * @ptr: pointer to the dynamic percpu area > > > + * > > > + * Returns the size of the @ptr allocation. This is undefined for statically > > ^ > > > > Nit: Alexei, when you pull this, can you make it a double space here? > > Just keeps percpu's file consistent. > > Argh. Already applied. > That's a very weird style you have in a few places. > $ grep '\. [A-z]' mm/*.c|wc -l > 1118 > $ grep '\. [A-z]' mm/*.c|wc -l > 2451 > > Single space is used more often in mm/* and in the rest of the kernel. > > $ grep '\. [A-z]' mm/percpu.c|wc -l > 10 > > percpu.c isn't consistent either. > > I can force push if you really insist. Eh, if it's trouble I can fix it in the future. I know single space is more common, but percpu was written with double so I'm trying my best to keep the file consistent. Thanks, Dennis