From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F15A7C07480 for ; Fri, 20 Oct 2023 17:48:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8180F6B00FF; Fri, 20 Oct 2023 13:48:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 777076B0101; Fri, 20 Oct 2023 13:48:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EFB96B0103; Fri, 20 Oct 2023 13:48:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4A24D6B00FF for ; Fri, 20 Oct 2023 13:48:34 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 20DC1B5925 for ; Fri, 20 Oct 2023 17:48:34 +0000 (UTC) X-FDA: 81366574548.24.85666BB Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by imf08.hostedemail.com (Postfix) with ESMTP id 5C9BB160018 for ; Fri, 20 Oct 2023 17:48:32 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697824112; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SCauBUJb5xOc/EPdCberHFtTQ9ZSrWxT/nrVc/2V/FU=; b=wyd1TK3lTFKae8FV9QKRFd5+tRyenEXg9+x2R82rd/u+7O3b2hmwgrCilkfmjCvS/cr1JA qht+pVULvR3ywhgSuZuIhSIwlJjXOQB/yZPVnI2P99bZfacYw7xcvL1lf0VkMPQ/XcvIfG AHEJnA6FhbGmOqWXvCWbGk5K/M1w9Is= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697824112; a=rsa-sha256; cv=none; b=cAKFcWOKrFcYlUg39fGSDDLqWv+7v6uux3lfyAFTRl/lM5XVcnWvHZNMjk3W5f/ft4yond QPWE5UH/qpGPRp5XIFhhnNB9Agk4cGI+pph87CoH8EXLTirJ3r1HZ5iw168BONlgBInoPt 1plL/pIfkq6qzEmuqavU2z3flBp8jxE= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-27d17f5457fso1739978a91.0 for ; Fri, 20 Oct 2023 10:48:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697824111; x=1698428911; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SCauBUJb5xOc/EPdCberHFtTQ9ZSrWxT/nrVc/2V/FU=; b=caXTB1t4ubhqw8xKGgm+o3H4nMz0OJ3KWSLTZY6qcMiRlGKQ80nzq4ocZ9vTIC4VOG Z7UxNfb+C0ukk/k3ejRN8GJLzCDongn0dnwNSUpuanNzKsOB5jarMoX9qMLK3/ve9wXI 1lcad5wRTRcD0aLz8RkfnTFGF4hpQ26Kk0Xy7LH8v2G0LyebE1x2AaepykR2ew1AMLee 2HK0vTSNa3Gu38xrQwBUsKIwQDhSqR+zu1MlDqpw0pC89n9j2qhIGptO1Y0YZxhRPHUf nC5v+rb5rJCGyS/AH2Fn58rLbPCXYUipiriXabAYrsy/EW5MuoXWgcVpXsE0a+k/zJjg 1k0Q== X-Gm-Message-State: AOJu0YxPK3Ad+1bofsA2GJ89ScvSuyrauQf2crB38FpJfH0fO64s9gql Q8/HYDQGcKCjSSQDiKi2Dlo= X-Google-Smtp-Source: AGHT+IEHj+lz3Ix8M+JITQXr54AgAIZBdPmCCLDyZr6Hmv+d3G5g6JueVWdWU7saSwbUww8DuiKSxQ== X-Received: by 2002:a17:90a:6b08:b0:274:8951:b5ed with SMTP id v8-20020a17090a6b0800b002748951b5edmr3672577pjj.20.1697824110905; Fri, 20 Oct 2023 10:48:30 -0700 (PDT) Received: from snowbird ([136.25.84.107]) by smtp.gmail.com with ESMTPSA id p20-20020a17090ad31400b0027d15bd9fa2sm3474346pju.35.2023.10.20.10.48.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 10:48:30 -0700 (PDT) Date: Fri, 20 Oct 2023 10:48:27 -0700 From: Dennis Zhou To: Hou Tao , Alexei Starovoitov Cc: bpf@vger.kernel.org, linux-mm@kvack.org, Martin KaFai Lau , Andrii Nakryiko , Song Liu , Hao Luo , Yonghong Song , Daniel Borkmann , KP Singh , Stanislav Fomichev , Jiri Olsa , John Fastabend , houtao1@huawei.com, Tejun Heo , Christoph Lameter , Andrew Morton Subject: Re: [PATCH bpf-next v3 2/7] mm/percpu.c: introduce pcpu_alloc_size() Message-ID: References: <20231020133202.4043247-1-houtao@huaweicloud.com> <20231020133202.4043247-3-houtao@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231020133202.4043247-3-houtao@huaweicloud.com> X-Rspamd-Queue-Id: 5C9BB160018 X-Rspam-User: X-Stat-Signature: nkyoj5sddwzoaq9w6r3xxkty9mnf6qj1 X-Rspamd-Server: rspam03 X-HE-Tag: 1697824112-939979 X-HE-Meta: U2FsdGVkX181JYtm8np+/Q45sc0ZON5WJcAd16zjlCNLReHNLNitb01c/LPPH72EuiN1OpubbSuLGEXP4Qm+04Fu+FmxBk629XtQKeCYz81VBk0O+YIAj1rHDWejjhdFX3+GCZgmYKtN0L7E1+y1BDVFSZSxqJjJg2QE/CZYsK9AXSy0qpsduMHcvDdLT6LbFftNa3Bdoq5ppo6lqGVeahdTS2mVLXC5PJG+8c72AnetXT6WqOm8QBbBgxc51VoqQHzIceBxybHpAUCdnbULepnak9wREevbK7bppFhEC5XUSZlKMAWbCS4VZCBqFXWEuKZI6aaTDvAMImMBq/u0+CXv3mmtUN2OvrZx9Xmn4KPYE33/iK80APJ64MvznmidNnfwkzpZdnbNyLSYKz6apgWWNiQMvLh0Xqg3PKU8twebMVPAsenBXFWi1/yXKwmUGqN01AKgz3Yu8eVl/+8DUx7oa5GWwia0flWoq2LWF1MQf3WOcDxagNwxRDjn8aZHg6CWzpl24AAsJTwi8ubf+9VzlC5nPnS2a3FqA9huBuhE1rnyP/O4cmayM4x30fRYQQIiUFtq3JePXaRZydtAffKwfmmyppJKsxpGfuRDi+/mFn06y0UHr/zZV4scqfXga1auBkqgwJwVaFBBz6RuB1zlNJOhf9d7I0zYQFZrv8uycO5ALHizkqDSFOyx6A5RFnC5MLNRj9Y7I2eQ1vl+4O0fGA5wLco+Z5QuA7TiNRvGynlYj/9rnMKlCP6CqJo06pfz1G0XqRIS5jgbQhdOmWcTQ7gRS6hyMfCbFa1wwmp9Lo65GrpfFw4XyL+ehsZye/4uwYegOOhUMM1JocqvkgKgsQcmWUIEmSOQC/flkxUcXf0aFvu8URy5QYlfuJS1NkdeGbUAKgjgNPWBMXLW0BfDlT9mgm0Davpm/t6jSoUbfmbCMeNiAFneIbuVGzQJqhX3WsFJyxcPlQSNjd+ DgduFM/T zavuV/xP8t/Kt2F9Go5vYTomBSAi3fegg5MiLiOo1pSjlYQhz1TOs24XbNePkp2/jnH9W8xqq6U1R+HDy7InPzhI94YaIMYnrikVntsu2eb2SKOj8yEqb+O7D2kMM13l6+HljUj7QMOmRd1d2p0mChdC4DjcNwxV9Kps7pg6WOB48QSpMHimCIh7AqvMP65n6FpQ6/L1mlo+JA6ZwYswjUH0XCSbtYl/X4mia3ZtNLSEVsaH+pVzfUhCr2JfcT7TY6XW+9opxd4i9FDxcVlYt1cWpS8DrH4pbEVvx27n6BQHw4YM3bdWFPxWewmpYDTonhoieZr/BAfc/qvPN4Au4ninCvtelAb4yB6wkTPNktV7lfyTUujv7nyVzyFtbrbQL0EAdp4CVtxeEFqKQl7OH3EVC1UahyqnYFAdFuz1S8LnGbmMF3JRKZ8z+RRXMY4Zop7uZaZEVYY9hUnMxbAMfdfaxX3an9/LBGIfTp7To78Rd38oi/pikOaTg6uAPEaUpmiwZ0kdPc0RSht2D0Otetnmwdmw0t7CoX7qSQbkZkSS6JCVAPuipvLlF1PbU0BVf+968u/FC8mQjkwzScFOw7GTkreoe40H1ampu/v8UhIz4dd4UVtWTDjloItrDFsT1rrObYGnhqC14StXdPzv3Mb8/PgM+TqX3kPMz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 20, 2023 at 09:31:57PM +0800, Hou Tao wrote: > From: Hou Tao > > Introduce pcpu_alloc_size() to get the size of the dynamic per-cpu > area. It will be used by bpf memory allocator in the following patches. > BPF memory allocator maintains per-cpu area caches for multiple area > sizes and its free API only has the to-be-freed per-cpu pointer, so it > needs the size of dynamic per-cpu area to select the corresponding cache > when bpf program frees the dynamic per-cpu pointer. > > Acked-by: Dennis Zhou > Signed-off-by: Hou Tao > --- > include/linux/percpu.h | 1 + > mm/percpu.c | 31 +++++++++++++++++++++++++++++++ > 2 files changed, 32 insertions(+) > > diff --git a/include/linux/percpu.h b/include/linux/percpu.h > index 68fac2e7cbe67..8c677f185901b 100644 > --- a/include/linux/percpu.h > +++ b/include/linux/percpu.h > @@ -132,6 +132,7 @@ extern void __init setup_per_cpu_areas(void); > extern void __percpu *__alloc_percpu_gfp(size_t size, size_t align, gfp_t gfp) __alloc_size(1); > extern void __percpu *__alloc_percpu(size_t size, size_t align) __alloc_size(1); > extern void free_percpu(void __percpu *__pdata); > +extern size_t pcpu_alloc_size(void __percpu *__pdata); > > DEFINE_FREE(free_percpu, void __percpu *, free_percpu(_T)) > > diff --git a/mm/percpu.c b/mm/percpu.c > index 76b9c5e63c562..1759b91c8944a 100644 > --- a/mm/percpu.c > +++ b/mm/percpu.c > @@ -2244,6 +2244,37 @@ static void pcpu_balance_workfn(struct work_struct *work) > mutex_unlock(&pcpu_alloc_mutex); > } > > +/** > + * pcpu_alloc_size - the size of the dynamic percpu area > + * @ptr: pointer to the dynamic percpu area > + * > + * Returns the size of the @ptr allocation. This is undefined for statically ^ Nit: Alexei, when you pull this, can you make it a double space here? Just keeps percpu's file consistent. > + * defined percpu variables as there is no corresponding chunk->bound_map. > + * > + * RETURNS: > + * The size of the dynamic percpu area. > + * > + * CONTEXT: > + * Can be called from atomic context. > + */ > +size_t pcpu_alloc_size(void __percpu *ptr) > +{ > + struct pcpu_chunk *chunk; > + unsigned long bit_off, end; > + void *addr; > + > + if (!ptr) > + return 0; > + > + addr = __pcpu_ptr_to_addr(ptr); > + /* No pcpu_lock here: ptr has not been freed, so chunk is still alive */ > + chunk = pcpu_chunk_addr_search(addr); > + bit_off = (addr - chunk->base_addr) / PCPU_MIN_ALLOC_SIZE; > + end = find_next_bit(chunk->bound_map, pcpu_chunk_map_bits(chunk), > + bit_off + 1); > + return (end - bit_off) * PCPU_MIN_ALLOC_SIZE; > +} > + > /** > * free_percpu - free percpu area > * @ptr: pointer to area to free > -- > 2.29.2 > Thanks, Dennis