From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E02CCDB47E for ; Fri, 20 Oct 2023 08:32:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A3868D01C4; Fri, 20 Oct 2023 04:32:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 92D1B8D0003; Fri, 20 Oct 2023 04:32:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CE668D01C4; Fri, 20 Oct 2023 04:32:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 690368D0003 for ; Fri, 20 Oct 2023 04:32:20 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D0A071A0795 for ; Fri, 20 Oct 2023 08:32:19 +0000 (UTC) X-FDA: 81365172798.02.2C8497F Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by imf07.hostedemail.com (Postfix) with ESMTP id EEB764000E for ; Fri, 20 Oct 2023 08:32:17 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JCEttsn8; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf07.hostedemail.com: domain of mingo.kernel.org@gmail.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=mingo.kernel.org@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697790738; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tqRU8lrO5DdEsJ7yzHOjWhQgZG94Il8pn8Nsr/6qC54=; b=xQRlBEIUAczKR3mfyQYDwIZQsUvD5X7sJCNSzhSgeN/wYJv2DCzHfgC3ogFTFqgDrvM1fp 03rbFnwLn28rDRF1j9/u7ZAdjkAIWOpfgs7uDZKILBZvNFyMMaKudA3r8HHl5jp/x11Mnt WyX6861S0U6pPvmuT6Mbo34DurdCIio= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JCEttsn8; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf07.hostedemail.com: domain of mingo.kernel.org@gmail.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=mingo.kernel.org@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697790738; a=rsa-sha256; cv=none; b=vMBU62J1P11g+w3e8fynfBkSrHHvAHoibxv1Vp6LIPGeWsmA101aFVwgmP0GOiqfo+qjF8 ium4R12JVMD+tVK4FvhDvNtipr7vTqmCRnnWQAgJfGjeR4UWBUOk7qxu3b76jaS8g5YTwr YobAeGBUkzCwDj+22WFcZKs9yXmTNNs= Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-53e3b8f906fso731105a12.2 for ; Fri, 20 Oct 2023 01:32:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697790736; x=1698395536; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=tqRU8lrO5DdEsJ7yzHOjWhQgZG94Il8pn8Nsr/6qC54=; b=JCEttsn8t8Zcbd0kFLPbibmDoMtQVZkSjp7saNFl8Q3JTAAsNG0adkNQ6y+nDP8iRa jre2gB/ePd5WsnPcXiqoLtZ+mP1mXBISsSRUkBXbfLeLXMtF5jruuW2ecl9lT2eXtoWW 2SSkyfF7Sft3M+TzCK8IX9t1/Yyialw/lJ/TB/vfxz/AcJWNYZ/WumTII2alPgS9Tob8 TF6nYvTT9IyDrfad4LpnVDy+vbf81tR1SiFGFXXAErWFBMytKVeo19Ayp32NmLRsHUzR DyhVaHhjKujsOmcZ+xr+NhMaLEpCAg8lDntJyXc1EL+C6hwVhXxmihPM88ht6FJg8axq ZQ3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697790736; x=1698395536; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tqRU8lrO5DdEsJ7yzHOjWhQgZG94Il8pn8Nsr/6qC54=; b=KYzoMOPKP36p8KkEu61R44u4PLwLLPlaEJOx6LJUWIs+NB1PJbaacXCj3LRy7Y7t7g INP7aJ5mwB6wRS1m/GwylR+sJ+9w3hN3PKsACYx9zabzZpfFZkCw6QyGN2hAIwt0vtLQ JCtPgvkZNJs/IrOyeN+nWYFUBlcWGgO2lHYv2BQ5tpQV0QUsuDuZVpIFmY/EcImd4u0v iGaQn/cxD/6LDUKtwc/pO4LsTCIqK2dZU+XCHklVYhVnKssdgpqo4zIaNtbZYcOBq4Ey X91bGg5M5laWDBeXbr2/4UY2AGUnV95KObCY0NxfoG4CSE1y9VxYgiiYqzquscxh/pUi TYFQ== X-Gm-Message-State: AOJu0Yw+SmclNUKDKZZ+1oMqVsUw+EGfmKDlS3SU62KixSZpT5Slh1XW v0BNZeAjyTpUaW5TYrXoM5k= X-Google-Smtp-Source: AGHT+IEb6xP1ALmiI0M4CBQddyaawn9u+DgDcAxnAtAukvVxZEk28V3a98gpRRqFGFqkycesRY2RjQ== X-Received: by 2002:a17:907:5cb:b0:9bf:b022:dc7 with SMTP id wg11-20020a17090705cb00b009bfb0220dc7mr772906ejb.48.1697790736212; Fri, 20 Oct 2023 01:32:16 -0700 (PDT) Received: from gmail.com (1F2EF7B2.nat.pool.telekom.hu. [31.46.247.178]) by smtp.gmail.com with ESMTPSA id o14-20020a17090611ce00b009b29553b648sm1001362eja.206.2023.10.20.01.32.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 01:32:15 -0700 (PDT) Date: Fri, 20 Oct 2023 10:32:13 +0200 From: Ingo Molnar To: Qi Zheng Cc: akpm@linux-foundation.org, rppt@kernel.org, david@redhat.com, vbabka@suse.cz, mhocko@suse.com, willy@infradead.org, mgorman@techsingularity.net, aneesh.kumar@linux.ibm.com, ying.huang@intel.com, hannes@cmpxchg.org, osalvador@suse.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 2/2] mm: memory_hotplug: drop memoryless node from fallback lists Message-ID: References: <9f1dbe7ee1301c7163b2770e32954ff5e3ecf2c4.1697711415.git.zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9f1dbe7ee1301c7163b2770e32954ff5e3ecf2c4.1697711415.git.zhengqi.arch@bytedance.com> X-Rspamd-Queue-Id: EEB764000E X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: zz1n8i7cn8jdwdzgzp9oigugjnxw6hcz X-HE-Tag: 1697790737-261690 X-HE-Meta: U2FsdGVkX1/B+6pb3wVnFNX1GBnAuaEdqbP04m5xHTidSUb32rl1Cxygz5NW06z5rep5OXzdqxCWcU3rxoT5/EgNlCS7e8Z7Vu5zs1u+QZ6UV46odmcvSTT1os/rZwGMpekPvrL65VrLHHlTgUTjsYTPEXj7/Hmgp281Hny0Fts3yct0LNBPEBvVtXkjrnza845hwAj27dKg5UZC3BiKES5DvvAP+Cy/pbC2pYtD1MazXlw/jMIXGnxclMe2PCDuVh8qRJpumbRgp/5BHT+PJ/SmttdG9Oaa6LaBDnKnguLB8fNzCjEnN0oKzs9NvHPXtjrXOlTC01F+mGaETG7C4WnnBKFfZg9Kw/av2Fy7pHL8jR69WUQH4furrDfYQNv/viP/Op86N7qyEjIQdaKR6S+QnfSX6SXpkw+qDjYhP1mzw5XojEYST61kjm4jrymeLeW+wEU8UgermLr/4qLFe2LcFbiQWLOl61iBJzlTF4XEw8meO9jAr2wG1uIKpxdyzlx/DkSIRFOr3FfVi86cQCdNscbErtHHtgt7rQyCHh3ZCEmc+yBFHxlV4XNlgsY1qPyamBaGR2H/gxBSM30DuZvqrEJWMpCWug1utduYAnSfh3HvIXFR4vjvdsbj4udiCHEqtooAjGaYJpp2ikUc+moYpQ+/2Zxl2jEm66WHDsSYTuKLfZjw88OyFCgDmnThBZUN0jT5ODgirdun8GsPw9jccgYqi/0AejK/cn1qDZG5Hp5dm2ZZ+pwTFaQ+NVKvdpTU8ZsQUAN66jRJVb8HKYsTiieZuWojTP1CXBC8LSYziVbyeoLbGQEHYSjlUKJJzduLaQZLPa4owKt62DKeWAuRXESBemPKeNbwuHnYakJx4HyT05gKTccoGY5mnK0ukka3rXxXfdiKKttInqUIJEmvC1wP8DWhGbgbi9UgLT1mLFnkqqtbjzQOFy5q9BGMDCALIyyBcMj2IxieycU wiWK6CHn RVJmzRYztArboJ0t5EJqGjfkoCs3bQl4oxY03PfiPw2/AAp6gesJ63s8aMn7y11PLKMT97g1xHa8DearP4n5V4po8CuRmOUE+cOxjI9W0czJLokxicTJ9VBGw1bKZQWvSmocC5S5EYLqDrJm6Z+oyp2ptxFoj0TYhojABnm5YHa65egMK4JUCfbYmP4//l2LsyLE15Eh31R6JVTpQrO1w0sVvTJERHaVUEkPLCypQdjWFtbenrG/R33fzNHyhcruQOQtxGBp5ON1Joe2Eq+TPM9D3jMuEMvPDzjm6rWiRBAFeFwrCQOfzKlSaCtZzcEsdEh9sW8u5w4t8RpnG1UkRfFmITX7ujfyYDLQ8NwT7J2ycm/0NswVFFLUcFjYGFbZHaYQlpCrpAytnWXXqHjqG7Oc+WM86nXIyoc6eLhaPlO0PpNTkzKB8KG/s1UH6c9iuw2HRRQhWGtplPxFrYhvChmTXAs3VVojf2ztfhz1mtLpizO+j4B+B00mVQfW5FtSkWdADQT2FIx5j+2/Z77Px4M6rUSszWBun/APZH6K5Wrwzi/WS4MjPl+f7/LBcsGYGrgmdYhk+Na2GGpeLI0j6NBZEJRK7HVnczcqQC4aMfbmH5e9olFlfpbTrHaZcFI255dCYOFqS9VQ7viOVMCNTURSIRitiA7ErILgVyLkya17PG5AH5yaKJ5Ro9ZY6gnmyfmLXE3xWqkjL6Bo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: * Qi Zheng wrote: > In offline_pages(), if a node becomes memoryless, we > will clear its N_MEMORY state by calling node_states_clear_node(). > But we do this after rebuilding the zonelists by calling > build_all_zonelists(), which will cause this memoryless node to > still be in the fallback list of other nodes. This will incur > some runtime overhead. > > To drop memoryless node from fallback lists in this case, just > call node_states_clear_node() before calling build_all_zonelists(). s/memoryless node /memoryless nodes > > Signed-off-by: Qi Zheng > Acked-by: David Hildenbrand > --- > mm/memory_hotplug.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index d4a364fdaf8f..f019f7d6272c 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -2036,12 +2036,16 @@ int __ref offline_pages(unsigned long start_pfn, unsigned long nr_pages, > /* reinitialise watermarks and update pcp limits */ > init_per_zone_wmark_min(); > > + /* > + * Make sure to mark the node as memory-less before rebuilding the zone > + * list. Otherwise this node would still appear in the fallback lists. > + */ > + node_states_clear_node(node, &arg); Acked-by: Ingo Molnar Thanks, Ingo