From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82981CDB47E for ; Fri, 20 Oct 2023 08:46:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 148E58D01C5; Fri, 20 Oct 2023 04:46:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FA2F8D0003; Fri, 20 Oct 2023 04:46:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F02A88D01C5; Fri, 20 Oct 2023 04:46:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DC2928D0003 for ; Fri, 20 Oct 2023 04:46:40 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B421DA069D for ; Fri, 20 Oct 2023 08:46:40 +0000 (UTC) X-FDA: 81365208960.09.A06A4DB Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf28.hostedemail.com (Postfix) with ESMTP id D19F5C0013 for ; Fri, 20 Oct 2023 08:46:38 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZQG56LY9; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf28.hostedemail.com: domain of mingo.kernel.org@gmail.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=mingo.kernel.org@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697791598; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Msl3mVmSy6+Gq7AtNX6ffagUflryyN28BFdYCytPHMM=; b=zI6UN11hMCif6nAAsqE6AMpDXctYVStW6MFMvkDqFLP2r53uWC1NzS4tDlM03RRir80Ih5 BrGOua4NfKCND+ocQeFqK32mr3OJhE+hpkwnOd2AcvNmXEYp/efbniCfEd/G8PX4cTIB+B bip+ozGXcIm0uBhDkRUM/WObNXbrpv0= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZQG56LY9; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf28.hostedemail.com: domain of mingo.kernel.org@gmail.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=mingo.kernel.org@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697791598; a=rsa-sha256; cv=none; b=PzK4FSmo2GGKIlaR/UC8SXwtDmMEmrqR695vrvOHvDPNs9GLUIUXpmvKaDchw0yPVIJhkm 73Namdbqwm1RWuKpMUtdjeE25/mgh75LdBF+cLlWDzx0mLz89M/v6O0cNiKK0WbmQbxlVF xRupVex8RghsAW835aUdlZJbc7QWxjU= Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-9ad8a822508so90426066b.0 for ; Fri, 20 Oct 2023 01:46:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697791597; x=1698396397; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=Msl3mVmSy6+Gq7AtNX6ffagUflryyN28BFdYCytPHMM=; b=ZQG56LY9MAUf9zwwmdOGhy4AsklQY85UtdkH7i98GE5HD4LnPVMu3xbCsxz9taGDL2 zv3KmnAGmUVQonflAFFD9QhJApeq3WeDA0GPnY6HEbzGdFU+Ue3cTu0dwdnR5VNEAyNB ZSDg9mhkIImO3h5py3/VGUUqBWLVVN4GUYxCBSJp7Y2Pbw2RhcIl5GD1Cw+nlJZKngrk +kYZbmhw6+4iosJ0mfZ3QPqYgLiqxhuSjiSHYVkOLASd5zd6hZzcpJBRjsjsHZs2qyPy QcYvBf9p5S+kqOEbUQLyznicBehtMhIym32adho+QVAMofcroIgrFXPRP0Mgw37yts9S NHdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697791597; x=1698396397; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Msl3mVmSy6+Gq7AtNX6ffagUflryyN28BFdYCytPHMM=; b=Us2Ph3R2/cacsuiXD2/FbcIu1Vd0pAnYtXQwSNocFuIV0p+UOQWy+mZ1Qhe32NS0oo z5hyYkkHaROeiQ7feg0suxqUEJrMkSY6K1JI/1Hu+aymyx6rr5dZS7ZqAFarqLtWFuFX MyyryeYdh6FvNJCuVhkTeLFByJF76W0isFKFu28zWH+fU4tfHs1uyvSbUTz8QWtrwWSD v/mskpPzXV4Yymwz3B8BDiMRvR4jnbdsG0WLqQlRlHuLAF9XtOTcex0hXt+BsToeI4X7 R9lZ2Ad75xSlST13c9m+Y/ypfBOWaw4IOJ3kWKZrX0kCeWlUkNtyaBo+AYTV3dsVieCq 1byg== X-Gm-Message-State: AOJu0YzRbSTylX4mzzOepgXZXiJ99cyXZgIh6jrryloDliPnJgqEFzvB Spk8i+YGkQdn7glm+HJJhLc= X-Google-Smtp-Source: AGHT+IHgJc2e0pa5iZwqPSKoPrb9P/cgXaL8EZrLoMZi9f7Db/sqCcC75jerHDXM4/xGnaNbQx/21w== X-Received: by 2002:a17:907:9623:b0:9ae:6da8:1819 with SMTP id gb35-20020a170907962300b009ae6da81819mr789653ejc.48.1697791597177; Fri, 20 Oct 2023 01:46:37 -0700 (PDT) Received: from gmail.com (1F2EF7B2.nat.pool.telekom.hu. [31.46.247.178]) by smtp.gmail.com with ESMTPSA id n27-20020a170906119b00b009ae587ce133sm1043294eja.188.2023.10.20.01.46.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 01:46:36 -0700 (PDT) Date: Fri, 20 Oct 2023 10:46:34 +0200 From: Ingo Molnar To: Qi Zheng Cc: Andrew Morton , Mike Rapoport , David Hildenbrand , Michal Hocko , x86@kernel.org, Andy Lutomirski , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Ingo Molnar , Peter Zijlstra , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2] x86/mm: Drop 4MB restriction on minimal NUMA node memory size Message-ID: References: <20231017062215.171670-1-rppt@kernel.org> <605cc166-e731-e7d1-25d7-b6797a802e6f@bytedance.com> <35bd1d51-35ac-3ee6-e068-f50dff7774bf@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <35bd1d51-35ac-3ee6-e068-f50dff7774bf@bytedance.com> X-Rspamd-Queue-Id: D19F5C0013 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: you8ocryi78gjmi5eyzdchqa91zo6i6s X-HE-Tag: 1697791598-287822 X-HE-Meta: U2FsdGVkX19gtVxRTKJAJMqTrM2txvavAgLYaZbADO16Cu6KSKwJvlgpfeoB5IfQRxrzT1+nZLDaci7/lQPjmQdmTOCwW0+y8aesiacUdD6yHYhXGFEvTonk4VpYd08wnzTUaqNiBRV3q79gp/mHtl3UIN/w66Y2eELWOFiR/4Wfg0vcms3HSeXDcbgNHLbRibCJP08qunIVMqoZreQbyeyrkvRljZD7q1Y+DJdN2VuEyMRpTmTSt0Lyiv0rvcUU9sdjYStfpT5bP0XZ+ngCjxrhtxJaqTISuZutK8pkrOccHivG6ezr5EVdGAiqklgz0445jDy3qbNu+3tKJq7O6ibkBlPFq9mIZlJkJFfNh/1zRntvLRXnO76QKso0LdmFofb6Plw/u5yfLMt8w01SHEWA+NDS+HS1ukpJHfRsl5DKvnDB633oI4PB3RpUrRp7ic3OdrFDEOwANYe48MUlj0ycOn270vI+/SoaBMiKRk6EszJe5/I8I9vbyo8YaPV58OMluOtvt3alwii+cOfD/wr1f/2SWiN3fr2MnpM+kFdg77zxQMM19+GpdF1VwrZ4poBTpMs9gUd89LJhqx+9YeusroFKPEa1xFzHjJ4MtGlKddDMMURFkbs44QpoJWBnZ9fDrmIBu+yuqa3ulA+bRmMbOR4PlLcXXUI2QAGIKiGX8u8a78ctV67Cv9k7zCpZWSB6ZY/sdxt6VxhT2ev9vSqDwxHVtQNsTHdImXoImQ2wWdEKCADcl1YpB0kZCHjaVQAQ0U0mSkBgR23l6jCunIz2YIA7ugQ9TiRUMdNoshL5YosZvgnZ++2FvS6ovNxWw+H3IAhkUgOoNvEs1+O4EWu1DJJfLzS9MqO1Hokn0lHr03zpsfWUurrC2P/6jFWN4On2921JG0ZnCd3Wkxvq9KuKoPR81CuGic0WF86ErvYoKWo7/HLewCMkMs80XkYIqM7iGe+sDtb1gdqlDWT 3vlRV5XF fce9zSqyi0J1cAxo8KzKhwD1QeL/tTrXBXfJYXOaIMaAd5AiMTQSbU4X7pYlSLwKJfEpa9RA89NRdgsVaKoII2JRqiQIIkmzR0065MrF8x126FYFrxoza07M5HGLGw+sVocieE0vQtU4zoDISBogPhvvI7Ie7cW4lrWO4YojfvG5P9FOGXm4I3CR9to4owasY5VFRVDd06VNpglShP/2p90CpEcTcFGYNpM3uOd1F3KNSS0s3J+f3xZ/YPm1CbPSaOzXBCDbql6QpcBWwvwAC8dYNcAKVP8sPiblVCrcCyBkA/zLh9qacOmh5ehmD34ch0XDIW/wc7WcVG/2GetWy064CzlBs8rVQ9mp1h0dEEodD9QZ2sJ+KZNQ0UJSy5sBO4GtpCHT0zravhCC3e2ay5FiP86DflqtU82OWcl6PE3x5mHwdmI+848H3NIYrCcyDLgqUBMljy6AyKHf1P/H7MblfiZZ5RpNP6LoSYz96sz8PRBZJU73xXDXOjDm1gqrsQIFtiZt1ZZyiRPwHeHJKB5vdOIa3vKHr98S5tukV6yLMWugr34IlZ1S89wrvmgL+C2wCG7BcE3ThXA95Vxd2o8SqNIdOw1HNziAuY8NUoLixYqP3JuM0pOV8WAdBZM75KKOf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: * Qi Zheng wrote: > Hi Ingo, > > On 2023/10/18 20:44, Ingo Molnar wrote: > > > > * Qi Zheng wrote: > > > > > > While I agree with dropping the limitation, and I agree that > > > > 9391a3f9c7f1 should have provided more of a justification, I believe a > > > > core MM fix is in order as well, for it to not crash. [ If it's fixed > > > > upstream already, please reference the relevant commit ID. ] > > > > > > Agree. I posted a fixed patchset[1] before, maybe we can reconsider it. > > > :) > > > > > > [1]. https://lore.kernel.org/lkml/20230215152412.13368-1-zhengqi.arch@bytedance.com/ > > > > > > For memoryless node, this patchset skip it and fallback to other nodes > > > when build its zonelists. > > > > Mind resubmitting that to the MM folks, with the NULL dereference crash > > mentioned prominently? Feel free to Cc: me. > > OK, I will resend it if no one else objects. :) Thanks, much appreciated - and I see Andrew already applied your two fixes to -mm. With that background I was able to apply the x86 fix as well - which can be backported without the MM changes. The current commit in tip:x86/mm is: a1e2b8b36820 ("x86/mm: Drop the 4 MB restriction on minimal NUMA node memory size") Which should hit v6.7 in about ~1.5 weeks, unless there's unexpected problems. Thanks, Ingo