From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1D59CDB47E for ; Fri, 20 Oct 2023 03:29:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F03168D01B6; Thu, 19 Oct 2023 23:29:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E8D0B8D0003; Thu, 19 Oct 2023 23:29:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D537E8D01B6; Thu, 19 Oct 2023 23:29:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C1B528D0003 for ; Thu, 19 Oct 2023 23:29:14 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 79F1540749 for ; Fri, 20 Oct 2023 03:29:14 +0000 (UTC) X-FDA: 81364409028.27.CA990C4 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id 918FA40004 for ; Fri, 20 Oct 2023 03:29:11 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=OVYJQjQN; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697772552; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o7uVj+BWSvci11+EmzgxZowQ4BFh6afGOeAd/iYFtNE=; b=iZv+m9SPmrB8l4GSqdpdIJWWhA5HPHmMc2Hb4hasPie4CKRf5PBbcBIpnJAO03hQOFB6cf C7FFuyzlNs3vv8O7b10ymUM8NScxTTW+bHNVoPTr9DUCR4JZHBJZUakAH65tIUTR5jNsU9 Pi/JA4R1Nkmg1eYjGXVv2G7vTiK4Vxw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697772552; a=rsa-sha256; cv=none; b=HC223HKC89FxttBmXas1UVsE2uDlvCbjdvQ0BPiWbTh3gh7n1GKwh17olWcwI5TXn5/OCF 7JLYcyBH7c7hgSRaW5DQ5txeO1ipR8kT7wnAAFSEGFdfhUrFT4vOdQcJhUG3uuDkvu5MpX 4v+FlerI4US7cIiGFFZtFGz65FDs+iU= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=OVYJQjQN; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=o7uVj+BWSvci11+EmzgxZowQ4BFh6afGOeAd/iYFtNE=; b=OVYJQjQN5amrALRJRDc+biqABr gqr5ViWVPUS/uQzT4vXazunLCY2fSGOsUP1jsSxf2TSxcfVFWEJzWOuUwdG+5P8FqpS/lMXiFJa0H 1KWrPg9zZG1/ARnkgdD3J+UIdHqXA7ZH5vnzxMPo3acAfgQjZQnmiMBd6+MrH3eSTqKqYcS5QBQVH aqLJp0Tuv86iKJWGCV/mq2YmndTYlS0WA20GMoCCfsESxHGTBbpdsiZxcpFremM8vGCDiZwqWtiNZ BHA4AZkrq8S8OpqjJnodOO5PefhhVir5d38fOeOi7mX3rOroUAR6rDStVisuPe4C3qrDAmEMZlbww sa9ojvRA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qtgCA-00AofD-1b; Fri, 20 Oct 2023 03:29:06 +0000 Date: Fri, 20 Oct 2023 04:29:06 +0100 From: Matthew Wilcox To: Zhiguo Jiang Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com Subject: Re: [PATCH v2 2/2] mm:vmscan: the ref clean dirty folio skip unmap Message-ID: References: <20231019134211.329-1-justinjiang@vivo.com> <20231019134211.329-3-justinjiang@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231019134211.329-3-justinjiang@vivo.com> X-Rspamd-Queue-Id: 918FA40004 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: u85bkgkniteyf96i4cbjqf7j7keqt98t X-HE-Tag: 1697772551-240926 X-HE-Meta: U2FsdGVkX1/YaBwv+56D1cugQVqrXLT3aUcL2d5aXExHNi7p4SnSMthhZ+/a3ewvJXmLO1ppbrXm8FwQhflqj+wqZ+B0HO0bPudSdA/wtjS8te9nK+Mhi5aXf496xwNMjPpXwZAKpvJmG/j/IveRKStiJ8LVV6oRB0Rflj2/rmaM5Gx5mld3OEFDuSAzdJQ/LjWByntffI+tO/2J0HlrYOhnvn1UJvPLh1ZAEV4mr6gnmJX3JElK+c346PkCY5FrrgcafDCP7AyImRKy/BHxsNv/q7tVkAaNFRXkFrkIMnl6LewwnCl5HMUi1othvHmAu3pnIVGgadnzzM2eGWG+oGMxn8aUXZSrf6xDuBHsU3UoVelFHpzLP+rNAaDLvxxLK94TMGFDg/G3Fynh7iMT3kvhGlWf/03vmOmVWplwCfRgZ6KokzfLstgb4jw2oiBipZsfyJ5r7cuFovJOVxLC1g+rrZ0dNRgXy8CPaJ7xXMybFoehxWuR27zCWNaDE4PlHW+lVjtKL79r8hWBrqJCWS9PK1b/tKNNJEFSVYdrL0frS4KN97b8tbpotlAiaXlPxfxGO+c3KrFylRvtR6aZPGb8sy/G9YaE9aeNrbKHZuKAfdqi5OI5EfLV9kOsfk/0O8tx8pbPsNrxcvG7PqW2mqComyWqRcRXrJ1jGXDQcYZqC0bH1UuZ8AY3nAmRNqW2u2jsyvkauAsvITtSi53XETlZ106TXKldVYgFB5UAz5vZliVoyR+t/ykfpkRGFN+y4HH9swR4d8ACwaz9kCAo/beszW64U/whgl6HjfYfHzSyW8JEV66BYoQSxHWK09i48/mx1p1ZUa8VXxMEH8e97CSS5lQn9NoLwEq1cVUD71IiVO+BIHItIHypchWivqr9Ui0nBhYYoLL5iy1IPgYccqwdZPcA/Id0WZcGBbm5Zp9EsfXe3Cv6fQCy9fio7AJ84aYeMXu1PhX0/Me1Uqh x1KuNlgP Ze6JNWw9sMyg3DuAEZPbwExN/u6ZXXGdI+ZDj4GeX/C+0YRl72daGiRvZF8egtzs8A+zcu6MIvZy8Z6aZfx7BrQF+0AgHyo59UhVLtSosRLEzqL7PJXV7IKwgIGcJ6WVGFRw5scZnShTN8PFzbEsszdbXI2ipEco35O3s8e6LsL7NdrR8yPo2bMKRaQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.006935, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 19, 2023 at 09:42:11PM +0800, Zhiguo Jiang wrote: > +++ b/mm/vmscan.c > @@ -1225,7 +1225,10 @@ static unsigned int shrink_folio_list(struct list_head *folio_list, > stat->nr_ref_keep += nr_pages; > goto keep_locked; > case FOLIOREF_RECLAIM: > + break; > case FOLIOREF_RECLAIM_CLEAN: > + if (dirty) > + goto activate_locked; Why activate_locked and not keep_locked?