From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 025C1CDB465 for ; Thu, 19 Oct 2023 19:53:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 917B8800B9; Thu, 19 Oct 2023 15:53:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C819800B8; Thu, 19 Oct 2023 15:53:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 768C3800B9; Thu, 19 Oct 2023 15:53:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 62AC7800B8 for ; Thu, 19 Oct 2023 15:53:12 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 31E961A11AC for ; Thu, 19 Oct 2023 19:53:12 +0000 (UTC) X-FDA: 81363259824.11.60C3817 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 2527C18000B for ; Thu, 19 Oct 2023 19:53:09 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YTwshDVH; spf=pass (imf06.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697745190; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xsesIdim+wPTdU/RUNRWHqvYIZjYuIVW1UPJdK5PEjw=; b=4ifvepUNTSEpTcHSGbuWyeCb/Tdqs5mwLE8XJcqk/C1YuJh2Tyu3Yqs63g/ewVYqThwhPt 4sIw2greKTAq2VqEGcLB7aQzKgjpnv2ktS4Ti50E4iOgvs+VLKSb5umfCLOpjbL38fEfn6 UhmHlq9LSh6528YadmPQUmMZpDSKFhs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697745190; a=rsa-sha256; cv=none; b=f3X6UXtRsPODVz3vNY3UqbaImI2A6o8XdPJmVPx9HKDy/3OSzdxxrsJ3mm38X30h9n/V3S IFubyD5WnfgI1MfyyJlQH8thr1eEVF0n4iWbGMScWLessk2NuB9bUYVbhi4U/wns0Rg36Z g7XEDG12Lnf11TTeXOFZPp9FucqQr78= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YTwshDVH; spf=pass (imf06.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697745189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xsesIdim+wPTdU/RUNRWHqvYIZjYuIVW1UPJdK5PEjw=; b=YTwshDVHLMt1f6PB5jNyOEse2QhgLmKFq5S3eYcJDkQ8sIuPk70CSrM7PCnIHdLF2CLoda xbEdJayYTdg3sXsSIFXuyR/n/VJZ6q1mOW06bOvw5sNMrwQSgz6yMH9LSn7ic+giU941kj JHt8pc7lsRUV3frVoshKENnLOBy4pcw= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-195-gwRFEXwGM6ygoU79_8R9EQ-1; Thu, 19 Oct 2023 15:53:04 -0400 X-MC-Unique: gwRFEXwGM6ygoU79_8R9EQ-1 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-775842dc945so914885a.0 for ; Thu, 19 Oct 2023 12:53:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697745183; x=1698349983; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xsesIdim+wPTdU/RUNRWHqvYIZjYuIVW1UPJdK5PEjw=; b=QCT+av0I5CDu0pDixPo1OlXLOjUuVsFSxMji1t/WKfiswGzz56ejAzOl6Gl9AUTpYL eUGni/Ciqnb/z38M2xMm+eXZuJ8n5tPIQixaLsOcHui2YBSQMCWBVeSFBwRLDz51jcKM 4coNIAxWnpd2BLyKDlOe8az5pI9D3AFinp49US6Cvydz48M8IOXOLPh6H5xZCY5fxhbY G27znlM1qPbBOm+utFkM5gPCK9KEdKSK1Pv65x6G+H/r+sDdxN4sV3otz1d+iYasVOHd itZL3z3Nzw9mu1pg09YFoLpLvOFVtVekZDnT6Vdi1VsfP1o2718s/WJIZMa5lCbLDobU ViwA== X-Gm-Message-State: AOJu0Ywt+aJqAn7qjWsQXEAestRfsh60dqAta+dYKqpS0ymblCgUBKh0 9gC0CLSv51onDLKdSd9voZYn7NEUu474SB1ZaEwHjPAid9jbpJZ+bbJQ5areKHFYTP0Z+3pMPHg w9FGJEdjA6k0= X-Received: by 2002:a05:620a:1a87:b0:778:96e8:90af with SMTP id bl7-20020a05620a1a8700b0077896e890afmr3341462qkb.5.1697745183641; Thu, 19 Oct 2023 12:53:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE6lM3hjpOvbZ85Uma0UlRsQCBxfq3qPNAwSumdJHciqDnKFJqXdgnennQ8IWt6btGoUMNwrQ== X-Received: by 2002:a05:620a:1a87:b0:778:96e8:90af with SMTP id bl7-20020a05620a1a8700b0077896e890afmr3341429qkb.5.1697745183351; Thu, 19 Oct 2023 12:53:03 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id 2-20020a05620a070200b0077413b342e9sm53812qkc.128.2023.10.19.12.53.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 12:53:03 -0700 (PDT) Date: Thu, 19 Oct 2023 15:53:01 -0400 From: Peter Xu To: David Hildenbrand Cc: Lokesh Gidra , Suren Baghdasaryan , akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com, hughd@google.com, mhocko@suse.com, axelrasmussen@google.com, rppt@kernel.org, willy@infradead.org, Liam.Howlett@oracle.com, jannh@google.com, zhangpeng362@huawei.com, bgeffon@google.com, kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v3 2/3] userfaultfd: UFFDIO_MOVE uABI Message-ID: References: <478697aa-f55c-375a-6888-3abb343c6d9d@redhat.com> <205abf01-9699-ff1c-3e4e-621913ada64e@redhat.com> <12588295-2616-eb11-43d2-96a3c62bd181@redhat.com> <8d187891-f131-4912-82d8-13112125b210@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 2527C18000B X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: fifrt6kuzqfqy6zig9zye4iq5y8p33k1 X-HE-Tag: 1697745189-414203 X-HE-Meta: U2FsdGVkX19Ftp9G0TSwp0Vk7Z2yJburaxg8FLu7z8+BkDPBMOxDoSovdFYMQ1nn6dtqlm6jmu10qS6aeOMiKfhsaVCnKqgra+Pb+jQ9sExafZCadP5LLcgCOKrSwC7aMV/FzuxzMOMYsHxnX0LJNn8AP0f0NypooIQZr7gEmMpicnv0N2G4zATCvkkDeKHigRTOWAsDktxeeXF5IKq1kyYeSpubf3Ezix+RgIi9fXSvRh55YtYKYmhsrtU0VLwYokK4d/iEItlCjw5irNRlNkuG3jBqpDrdtjC4pZFfzhd5KdcSogQpFeUVG2lY+o0fYhGGZelwOLfUBk+TpTDqRY5hJm/Xf5YEB7EmTAl+JiX0jQ9zP/eBlXQWiMvNf+HbwR/1R/eJ0Wh5ivZuUpSQ4dQ+WPXhkEMAH353BVlPePfmMs1P+NeUCSs4HJTxSbtfpncrHcE/ty2AcCVnqJ3hHPM4IJdVD2Y4o/vpHJPybvSGQpIF+skXyJuvN+OBh0/XTbj3dxKfPaJHTUZKtF42Za3nyscgf1/QGFXlx2DZ8tui1NyapC7DWL+XwRb3bpio/uoz3ndhXoy/5zqUr6BYF/Hcvx9kT9ncTQkiDp0j7EtFmetKNm65e+EYOUE2cVtgyhDmFViojje6QDi6uMcUD0QabRqbehF5FxDmITpybicZflh9FxLSMtLRJ3xlWpsNm1ZMJEQxYIK5jC7rqT5KHK7scKgpGCq/gmKMZUD2o6/XC2KboKEFwGxk1KGkWVcPc9EDP1Y7/1o1o5JvtMMQFM6M+d/ApOyahyFvwp7k6F414uZ+mzSOZsb6FVF1PGPv3cxmnzyZRMM/JUi+b3zzbW2C/NVR1l0mscEXRc/Zlnzw6fECC6fbQ31Jxj0Vh2VU0uB0AuzJr+RoVFTJF390YuwiZ8nocoG4ijFo25zPveo7o3tHaSzeuiccmhUr5B0RpCiV7ubYP75hCzqSTIw eHJUN/xa EH/erlyvFscmn7T8Jbn4+u/s8RDZI49jHbylEiBbijQh05/f6p2Xuu3oGCBtS7jXE4CezILSgYJJjpc9XWg4V6LEZvY55jJ6oMGmUTgNbHkzuUPvAF6r4+V/ZM7T3Oae4cYB8QoDP2TFn8z2elr6/1IE5kUn9qUHYOQm35pP/4RIXpQi2EQoZe6DDsOg3SH6n3m7WXivqSPNo6wJFfHo4/XRojBzd3oV3yKm1Z6+JgpyjqVImabo067vmehYTwrK/kdWYzUwy3/xp6DVFj3M3XhF7K76E3QBqivex4iWtKOALy8dbLhi1EvNhH6fmTk2CYdJFFCzAlSz8MVrrD9mJjwHEGlDgglvnvAfYkmPVhyR8MVBQpt4coMBybe1nApwlyzWIdvEv6iH8+xPMZBs9h0Aw9MKCD93Nmxpu9t+BlglV4WycWrjPJw9qvQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000087, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 19, 2023 at 05:41:01PM +0200, David Hildenbrand wrote: > That's not my main point. It can easily become a maintenance burden without > any real use cases yet that we are willing to support. That's why I requested a few times that we can discuss the complexity of cross-mm support already here, and I'm all ears if I missed something on the "maintenance burden" part.. I started by listing what I think might be different, and we can easily speedup single-mm with things like "if (ctx->mm != mm)" checks with e.g. memcg, just like what this patch already did with pgtable depositions. We keep saying "maintenance burden" but we refuse to discuss what is that.. I'll leave that to Suren and Lokesh to decide. For me the worst case is one more flag which might be confusing, which is not the end of the world.. Suren, you may need to work more thoroughly to remove cross-mm implications if so, just like when renaming REMAP to MOVE. Thanks, -- Peter Xu