From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D09F4CDB465 for ; Thu, 19 Oct 2023 14:58:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 576628D0140; Thu, 19 Oct 2023 10:58:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 526C78D009F; Thu, 19 Oct 2023 10:58:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4156D8D0140; Thu, 19 Oct 2023 10:58:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 329808D009F for ; Thu, 19 Oct 2023 10:58:00 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EF057120483 for ; Thu, 19 Oct 2023 14:57:59 +0000 (UTC) X-FDA: 81362515878.05.AC0E8E9 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf10.hostedemail.com (Postfix) with ESMTP id 3E413C002D for ; Thu, 19 Oct 2023 14:57:58 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=WnyLZzlU; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of 39UMxZQYKCHIiUQdZSWeeWbU.SecbYdkn-ccalQSa.ehW@flex--seanjc.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=39UMxZQYKCHIiUQdZSWeeWbU.SecbYdkn-ccalQSa.ehW@flex--seanjc.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697727478; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NoyDzNpmGMgG5vgnElNw+7wjvKQootkU5+NZTuzV+xg=; b=Cnim6UGNuPk41wYhnQhri9dxzH+BtHjWCJBQgfcz4r+aOKE2yUs1hje84lImpsFI0owFAs VSddLMbGGQlFIVxsUlecnf1CLnl3FIMrCmEHjKX1HmvWU9aRCxn83IFQH7wNbbHB3swUkK HV0cuvU9TnoWdE7by0Xb7vJo/wI0xLs= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=WnyLZzlU; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of 39UMxZQYKCHIiUQdZSWeeWbU.SecbYdkn-ccalQSa.ehW@flex--seanjc.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=39UMxZQYKCHIiUQdZSWeeWbU.SecbYdkn-ccalQSa.ehW@flex--seanjc.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697727478; a=rsa-sha256; cv=none; b=SnKRR94sNT14zUE9h2RqIxfxLhQk/zRXJlD9WMESfdr017mIDp4oylSL1E2WzzMHX9KPDh 1B1ZBm2DSxHRhnpKCe8HHydtI0PWYrN29vcKZ07wpECqZASZxe/FAZPuXxTnZweUtcgfF4 bacm1YPUE7T6qfkKIT457vKgrdLzkT4= Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-d9c4ae201e0so778539276.1 for ; Thu, 19 Oct 2023 07:57:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697727477; x=1698332277; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=NoyDzNpmGMgG5vgnElNw+7wjvKQootkU5+NZTuzV+xg=; b=WnyLZzlUz91q40GON1efHjki13ulBexd/doJSNwHA4KHDrtw7fUod2Nfg4xqJjwL5e c4iKMc4R7HXra+hlv/Ok3yfK1kGlNynbEy+KmA+BBzH0IrE+1WPpfZi/d2RL9A189trM luazrpIzH4nv5UYFDrY/CEDlEd4P8cfo4wvTlByh6kk2PVxNySGE1LlOH/jU+kPP5Zjq DiDx2H6Abf1m1rBv+sqaYPWOgGYqXS+YT36gc8KyFmJu/1blKLZumYNHvndNC7riOXcz irkUjnedgjxynpZmJsiwe50k/3gS9l6+S3wa9G/1yZfLtl79WFH6i3WxW6qKVIDNdvjJ abgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697727477; x=1698332277; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NoyDzNpmGMgG5vgnElNw+7wjvKQootkU5+NZTuzV+xg=; b=DLEdXA27xJUTguDG3AjkK9LAmCtFBS8CWPSq/f13Uhwf5usImWvhJj+i9deVhc+C3i k/kZi+2x9SrEv/aaj6s1f9eJ8mZ1O7QChbPT1XAgz724XTQM8gVa3C8W1mjNqNZ+pr9u Y2N8DzW6F3tI9uxHXkKxKH7DO7KBs6uQCINgGIlgt/Z+YunfKslyXpanfTUkzp3DQbKv 7lDM44dfQGRV4YWORrBSXA4V4vAwLt6hI2Ih9dE67w9nN0Qykl3rHEUQDdGh9iTg8Bh6 EhTvEXobf78HUtOTTKFWhub0xObhje1vhxV3KKAyQZfItLgTuK+b5Z88SXrZOwYlSTit utQQ== X-Gm-Message-State: AOJu0Yyw6znoZGYpDXG7tvFO0UCSieOii5aWvj86EqhzwnAwz6SokY17 I9485BZag/oglTt/djXMpDzvjGCCs7w= X-Google-Smtp-Source: AGHT+IGGSi1A+odVH3et/CwWq4QLFvjNrU7TNfsn6fh/fjXnuZNCRYjqcrZpE1GRu0FMfXKhYQGxJgbQ8Z4= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:1202:b0:d9a:b81b:fd66 with SMTP id s2-20020a056902120200b00d9ab81bfd66mr66949ybu.2.1697727477216; Thu, 19 Oct 2023 07:57:57 -0700 (PDT) Date: Thu, 19 Oct 2023 07:57:55 -0700 In-Reply-To: <924b755a-977a-4476-9525-a7626d728e18@amd.com> Mime-Version: 1.0 References: <20231016132819.1002933-1-michael.roth@amd.com> <20231016132819.1002933-49-michael.roth@amd.com> <924b755a-977a-4476-9525-a7626d728e18@amd.com> Message-ID: Subject: Re: [PATCH v10 48/50] KVM: SEV: Provide support for SNP_GUEST_REQUEST NAE event From: Sean Christopherson To: Alexey Kardashevskiy Cc: Dionna Amalie Glaze , Michael Roth , kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com, Brijesh Singh Content-Type: text/plain; charset="us-ascii" X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3E413C002D X-Stat-Signature: j8cndd1b9kuyaop56au9j9bkauerba7z X-HE-Tag: 1697727478-326318 X-HE-Meta: U2FsdGVkX18GuDLAMlIzPmfFFA0JvEmwHCNSIqS4LyO+9BY9xXdVLPIgfOlAWRJ/tbX2SihZoHxCDNgsK00bjdNBTpRCDdr0ZptxFZIUcqrPPNUFhecuDXBOdXYajxGcuJEj0N96n43LauuYAgjiEcDI8qepyiBu02PPNfxnGwi4RlRbofCoQLe23hziCgyvRKAqqd/WUx/+dl03klS7kdbS1TPT6nY/QxHuew+X+OApIMUDQic4aTXPNXmRF+GSDizNs+j1KKKlzGeThFjBQgMIHXC1Yv/Z0U+3R+RRmDnLTOh+L+5NE79YFUKedtq46eaGDEkpuDItjIxHchUitHla4KcXT/8OxuxnzaT7eR2FZrDBHZdK6G4YAxg3qGx76Q9JXtj2oPakOI0LLhbTm4+8cehkxkh+Csz0aTv56M+vBb2p0+k4HeOQ0juhLZesIoNmPB6A30BrQ+JJ4gkz4fRtNt1hxjZeOtHSqBl7Iv0W2iS9hRHbeZOq4hmg8f2U6EGPQVKjzzr36WyIosbq32twa251TmtSof1Om8I5UgHOWG9aH0SbeHMwJQIDiFixqaCaFSC5l7AOnOl5X4IfD91EGJ6u8P23VdWkgi6TBGZYYhX0Sz1CIXMp9Ime4XLuLL6ExYvnSKPxcmZC6bs4n7npXk6/OvwjveQCEYhEosL+YgDE9kMZ53t/ARa4BbTMGCLq4PtO/9oi6ZcVPOHaV6jjACm/hOYPoGwYRoHbK9KSNT0lw2N1GinJJjT6GXW8Y26dndG58F9Gi6iwYn4+jjRStuMviu0pprDOZZBbZCBEqf+Wx/QZ/vrzbJLLZvMIbVv/0hREfkyJ28BNzAL/Z3ogdhud5l8YYSaT9jM7ypZ48OKNJQdFCTJcduoiYse1LMCOmpzwpP/FI77FjMHVdi1txjwYcZecFBWUmwVxahzPmd5+Jjl7Khoe4p5UseW688Mda83+E/R6pTYSAWM tNo9Nof7 CDAiTyZy2cDjLjVDPJsokUXr2dMd0l1fqz4YAjv7ACC20LPUfua9zO75YGhMZootxUij/tzE2RBB0jQKsdoxrPIi8TCHCOPvU5E1QmoDyrpz9PV+u5rcJJinz+XM9ZxCSPSZ8DfwAeo7KixdrgPSGtmD6hWgKSJ4AUuMQ9XAFaUL8zIGEHseQgEdtF4/bAiK+ZNaYOIBqJujJlvAgTRetSwh8UTDGBVZJ5Dzlagqlz6p+a8ZBbXsttyvhkLbhN9S2BKtFUPkZ9AEywqKUuP7VsmGl3LG6zpKoyiKs9lcBxzQFM34jqUhJCI9PmT9awNj9Y7CKVsbl4lkc3ArDce0KDukWf1xfxrKMTtSBMRsZRF5+FSJnGkqU0bdy8RaVUaNRqfyqj71Yu2RW5S5x1xkDf4anxBGM6uuXKO0t3qjd9JV5eTx+ZBA+WRwlfvBtM6X2LZ+dlzV3LYcB5tOJpvkTWuceYk66f/vL/88umTyz4suX5c3LZQLwi5GYYuX/4oeVmCJzx/yfVvIRbHjuO4hZIMAvHg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000465, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 19, 2023, Alexey Kardashevskiy wrote: > > On 19/10/23 00:48, Sean Christopherson wrote: > > static int snp_handle_ext_guest_request(struct vcpu_svm *svm) > > { > > struct kvm_vcpu *vcpu = &svm->vcpu; > > struct kvm *kvm = vcpu->kvm; > > struct kvm_sev_info *sev; > > unsigned long exitcode; > > u64 data_gpa; > > > > if (!sev_snp_guest(vcpu->kvm)) { > > ghcb_set_sw_exit_info_2(svm->sev_es.ghcb, SEV_RET_INVALID_GUEST); > > return 1; > > } > > > > data_gpa = vcpu->arch.regs[VCPU_REGS_RAX]; > > if (!IS_ALIGNED(data_gpa, PAGE_SIZE)) { > > ghcb_set_sw_exit_info_2(svm->sev_es.ghcb, SEV_RET_INVALID_ADDRESS); > > return 1; > > } > > > > vcpu->run->hypercall.nr = KVM_HC_SNP_GET_CERTS; > > vcpu->run->hypercall.args[0] = data_gpa; > > vcpu->run->hypercall.args[1] = vcpu->arch.regs[VCPU_REGS_RBX]; > > vcpu->run->hypercall.flags = KVM_EXIT_HYPERCALL_LONG_MODE; > > btw why is it _LONG_MODE and not just _64? :) I'm pretty sure it got copied from Xen when KVM started adding supporting for emulating Xen's hypercalls. I assume Xen PV actually has a need for identifying long mode as opposed to just 64-bit mode, but KVM, not so much. > > vcpu->arch.complete_userspace_io = snp_complete_ext_guest_request; > > return 0; > > } > > This should work the KVM stored certs nicely but not for the global certs. > Although I am not all convinced that global certs is all that valuable but I > do not know the history of that, happened before I joined so I let others to > comment on that. Thanks, Aren't the global certs provided by userspace too though? If all certs are ultimately controlled by userspace, I don't see any reason to make the kernel a middle-man.