From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57A00CDB47E for ; Wed, 18 Oct 2023 15:57:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA7C98D015E; Wed, 18 Oct 2023 11:57:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E577E8D0016; Wed, 18 Oct 2023 11:57:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D46778D015E; Wed, 18 Oct 2023 11:57:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C27B88D0016 for ; Wed, 18 Oct 2023 11:57:57 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 964751CBB40 for ; Wed, 18 Oct 2023 15:57:57 +0000 (UTC) X-FDA: 81359038194.16.3D5C548 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf12.hostedemail.com (Postfix) with ESMTP id C9DDD40022 for ; Wed, 18 Oct 2023 15:57:55 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697644676; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WwU138rdae+tnfMoQAzpt6RHFekywme7JqVZU6mXqOM=; b=rCvZXoVUTgCde9E0JI7jO9UYdsUU42KoVo4x9DxogHlSE7vBFQeBCgUugfjnefGwlt/u25 3lkoA3Bysdv7WqfuzIC04UGB2T+xWKnKXjerNSmEYsPUp+jKKL99vJqHAxvg3JWsST/6zE ApV45nN4FEtw29Sihgfw5caUHf+T/kQ= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697644676; a=rsa-sha256; cv=none; b=G/AwcEvsETfKyJvqpXWWegCeHSbFmhQQIziySBdTzqurMCM0umpAZK6wA7KW+SIvgzjbt8 +muT8oreBOas89ZOFJCfYSudemSH2s01zgAy8Z24+g99baCOXL/pXoIjpmmFFSfKAN/XJ/ cKqWBU0acE7G8ykXlu27/rg8gBUvIeE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 4E2EFB82353; Wed, 18 Oct 2023 15:57:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79F62C433C7; Wed, 18 Oct 2023 15:57:52 +0000 (UTC) Date: Wed, 18 Oct 2023 16:57:50 +0100 From: Catalin Marinas To: Liu Shixin Cc: Patrick Wang , Andrew Morton , Kefeng Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 5/7] mm: kmemleak: use mem_pool_free() to free object Message-ID: References: <20231018102952.3339837-1-liushixin2@huawei.com> <20231018102952.3339837-6-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: C9DDD40022 X-Rspam-User: X-Stat-Signature: 7o4bruwh15t5ghhcz13s4q6x84311iio X-Rspamd-Server: rspam01 X-HE-Tag: 1697644675-904884 X-HE-Meta: U2FsdGVkX19+DeA/iDEV5OVdDWbezgM4ufK/eA4O8wMRnPdx2fvmsNL6gVZ9LleACbkqYinR0WDH7mQc2joqsh0cN3UvzLqdROGIR2RZuWndbRyPX5oU6tC8m1/5Hho+JYLXZtDfG+X3NkyIfEHgTNy8vciKvNvh49J8/ibihyJvMx7pFPr+jNwaMDYP0Mdd6qcYmf4lEzNqHvdvBlLrGFEogOuHGu0FP7X7rGLxhbdIgjsBsvbJ8Y9T5lD+zrvI1mM6Tys+qtkk0xlxZRZtOAuKqTibkmi3C4pkVzA6gU+L3N6Hp9XYcUbB3HM5jOjLYOhlBiknaXjeUALIstuTbDexwlYBQx2aghIg9rcaw73LK2wfUCgYjjyMwY7fOQUiCroSAm8twyRz51nQg6MdtOi4P2Ub37+fh48Zi1UJxpAqresi82fLacYidhitbbwIOt7rFFW/pDOqdvcvrKlqa90b4YtVrtSviVRxAnAIDRE9FcYDdMlhcbqKEQVmGXjUGMRj44X8jNdOsL+lSR2qXXd5+ULS/u41zf1pDsGAvtwZBUM/NNAaPUt/ESdkxPDQ89XUbtEHMm14n2KYqhpVsA4I08nUgHorIck+uCYGQQy1AMzgvciu+Uec4C4hYuThJ9gXsAtk3krzeIGI8Ghezl/5hpYnX4wK2KfUJ3kNxDmYX4me9+D58fUSoljN7+SGed1elOnIctDp+hBlugjibQqALerm9Kq09O4zHSDfeZeOCvPNSiWY5SNEAwMAYePowKjxuaBCOsGAGHfm4+EyGRnKyyUGrRtYtSXg1fLb0PdvZQandJSa/ZDdiuS2EBTicaPxZfrpIGe7NNJ3Z9pqR2KdxUIzSxP2D1DL50CRgHCMaOWzTMcFsXP7DwmHDQbg3h1a1TNcQRo71qYRTUbjKQF2Z/fDIh8dAKpDB1G15j2y3PBfDNRWWu/LefnKZKcC2PIXsvykFkMLI8oVbAE TyKW3n6A 8Nd8qUOj7KbM0DOAM2ARUP9fopKhxa6lfPZKSMKMTM1ctR5Q9E7D9enqIgRPmCIdil6AY2qohVdLoX4jYeUnU07ol7/UD9PcpRdQaj/fc3VteHDoPkGCoL3l3tX0VdWyJUfArtGqHiCXrqRQDoC9jsh5lSwqdjTfJXgzm6Ppbg00jm4HkNXRMhLPB1bNRGC4s4OMK4wcvTg5qE9JxOcZyZJyNbdGIa4CelwlmiVcdLgSftqaemCm3OvzwugJq23MLpgZhQC9x/QzzLZSeqQoG3c2GDujnnP/+xtvkqH4qFWDnAoYBY71g/MYbXSam9u/ksClRAoKB7YbGLabNiw3Q5MkOLcVVQCIeurojh4k7V49Y33T2BR+oOoB6PI57xEbGdqHUhYPyhWpe8XfGXONfiblud26nns0PEo4/Agn0XGrdlNhe76ZUBF+gLQ5xo7EboZbGRBEkDky1tC2gzyfnN3DaroQ4B3ft+018F8XJQnV/j9UNfhUmZ84Q3KgZ2dmZcR8E X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 18, 2023 at 04:48:06PM +0100, Catalin Marinas wrote: > On Wed, Oct 18, 2023 at 06:29:50PM +0800, Liu Shixin wrote: > > The kmemleak object is allocated by mem_pool_alloc(), which > > could be from slab or mem_pool[], so it's not suitable using > > __kmem_cache_free() to free the object, use __mem_pool_free() > > instead. > > > > Fixes: 0647398a8c7b ("mm: kmemleak: simple memory allocation pool for kmemleak objects") > > Signed-off-by: Liu Shixin > > Could you please reorder this patch before the previous one? If you > added a Fixes tag, we may want a cc stable as well (as for the other > patches with a Fixes tag) and it makes more sense to backport it on its > own without the __create_object() split. Otherwise: Ah, ignore this. If we want a cc stable, the whole thing needs backporting, including the split which is essential for the subsequent fix. > Reviewed-by: Catalin Marinas -- Catalin