From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E9A0C4332F for ; Sun, 29 Oct 2023 23:32:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E8C26B0176; Sun, 29 Oct 2023 19:32:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8713A6B0177; Sun, 29 Oct 2023 19:32:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 712AB6B0185; Sun, 29 Oct 2023 19:32:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 617716B0176 for ; Sun, 29 Oct 2023 19:32:21 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 13B3D803B2 for ; Sun, 29 Oct 2023 23:32:21 +0000 (UTC) X-FDA: 81400100082.06.01C16F7 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id 5CC3940010 for ; Sun, 29 Oct 2023 23:32:19 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Wo7WerlJ; dmarc=none; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698622339; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=guqQZMi+S1KSEFshVxWJ2luwQG5HPiCtpJaksTTmti0=; b=aWqNDE1lEysY+iNHBNW2Imc8hlhF9Nbav+0nriUzRY+N02iEePODu2vXoPKN4m7PfzEr8m 4xRSs6IOiUNoKA81rVGRXIXsnRcC4IUszt49yw3Ce/dV8Jdlf41qjd5rj5ePi0UAQBv//W gzXUv69x3CeTaXVmkvVOwUafoPz8Sko= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Wo7WerlJ; dmarc=none; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698622339; a=rsa-sha256; cv=none; b=jOhtjim+OZrL9mHeJvxct4oS4A41NMTBF+CW2CULIcOSCzIUTz1DbLOh4DDjBWXx5OF8fz t1JLmoIUeJICcoT6AAfjuG+8Ev2JAEWyeSg6PAuKse+qKZgMrnhj8n+qLJjBD6OoT+dT3G BLSzh/RXWaDreNaehxabt6TK7BXbXMc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=guqQZMi+S1KSEFshVxWJ2luwQG5HPiCtpJaksTTmti0=; b=Wo7WerlJhEgpQrY5ZBqa6AaM+u eR4dg/eHjvkTjQbqX3tLPPXvNPE/bgtdqm1WwiIVWjI11m6B+kDspU0GRBMULp/1I6L+mq3E66aQR G81NXlVt2ghXmGThaHLgGX+uWJWG68FiQYpLF5c/gYQ0+8U9ahKnxx8x7a2/gnce4PjMEvuxF6LcO e6b9sE5jh55LZ4Wic4UMfTL6J6IrCQnWpwdlV5NJfNbgu6FgVRFyhSvzl5p8UEUltyq4aPUR70u/B HeZ/L0OladO+JRwUOK4qruG0SWBCzPxw53IVJ+nOKiXvRld2K/OTG9HZdS2/pG3d/R2jC7WFHuN50 vaepK3Tw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qxFGJ-000jDh-MM; Sun, 29 Oct 2023 23:32:07 +0000 Date: Sun, 29 Oct 2023 23:32:07 +0000 From: Matthew Wilcox To: Daniel Gomez Cc: "minchan@kernel.org" , "senozhatsky@chromium.org" , "axboe@kernel.dk" , "djwong@kernel.org" , "hughd@google.com" , "akpm@linux-foundation.org" , "mcgrof@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-xfs@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "gost.dev@samsung.com" , Pankaj Raghav Subject: Re: [RFC PATCH 10/11] shmem: add large folio support to the write path Message-ID: References: <20230919135536.2165715-1-da.gomez@samsung.com> <20231028211518.3424020-1-da.gomez@samsung.com> <20231028211518.3424020-11-da.gomez@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231028211518.3424020-11-da.gomez@samsung.com> X-Rspamd-Queue-Id: 5CC3940010 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: yt9zhjqgxn3cy6q4p8ukd3rmj1tgrqx9 X-HE-Tag: 1698622339-303768 X-HE-Meta: U2FsdGVkX19gBgKVH+CgdDWtByf5wLLsLBQyx0N7m8yyrYebJsKaWEzuxqVik+m3Ee9wq5PXj/xn/c3nWy3EDCGYBlqfGdfWpS4j3o3a8rtCgL/xWZLmM+HFVgoulHjZl8GYOQP2ih74r0e2MRvmyEbw9b9BkjkK95X0I26OHbowdclvFSI4fRnNRnAuqbmn8t+9m3gFoW4Tlq8fFqI2FV4ZAFu5VC4yHHAOLitBOwP/gQg4Jmz6Ie3Ue6gLKBtk+7zP1Pkk+rvV1oA9O5vHA9tUShYtA1UHbzRg/VxsvEb1m61c4DJPL7payYMb767PcugwyExFfeQA285XQrC/8n3teUBK84TFd2pjQhNwEkBHv4e5bs00W01JEG6CF2hM6/Sez4VXgGps2B5vIu9KrU7UGMGuGS6/HdKoFB4ii6D9ih7I+wKEpv937XvWou0fm2Q240lDRgVqA0JYDf2DFWFKVhXLj2q6zKD2UNDhG/2uyFAansVf6aEhVhDNQnMeSyStRUMm7xCSaYPV5lbkaG2q/a965HcoW3d6Y1mOk0DYEQbML/68LAVsJ4hsWFlNW77jsoM+Xhkzdn3NVGJMsO8wMD/3btlHqpEFZlxb9zrtzCgtuderhkQGBxgPVZAF2p/kmd6iyxgaGd/B425y2+xB/FwfQgObaOulRuZTwRX2arpNWkiahb1znAkvV4R3ov+sXnfNwTyQzxWVsPOMrsIQ7w/q9wFujOR14ZTZ9RYeh7zHXcAbIXMU8T2A9Odda5Qa1oAIayMNK4C4OAMyTXLxP8Ngkg6qbXcGTHlkUlrNPdBGMTfAd+JBIsjyM6cKoFjLjV3vN9EETELc8jSXN9vQ+rj/RkPoVzdbZP6YzQI5CUNSBhp5fadT/gxK1+daaA/mC4dkZt2hhLnXkwkJ3QvwzpxaJQIaEOPPqEghZrvuF9iVbPnXUn/bUicjwCrEMJwfW6dSru8S9QMd2H0 ceXFYq9n Bu64koLogIU0i2CcFA1brmjJWXz0CzMwaOPVgkit36HNNm5WcT79ThFHsgWxcy4v4hTNgEP/Gu1tJK6iMEKET89gcqFGcMIaDd/YiTDJ/0dqBu0idmtqDvJejZH2I62fRbvsCp++DSad9rWfR9lcNMkEGPdWIHeDxw5iWDJLfeyE5KCpVljpuTxeGsw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Oct 28, 2023 at 09:15:50PM +0000, Daniel Gomez wrote: > +++ b/mm/shmem.c > @@ -1621,6 +1621,9 @@ static struct folio *shmem_alloc_folio(gfp_t gfp, struct shmem_inode_info *info, > pgoff_t ilx; > struct page *page; > > + if ((order != 0) && !(gfp & VM_HUGEPAGE)) > + gfp |= __GFP_COMP; This is silly. Just set it unconditionally. > +static inline unsigned int > +shmem_mapping_size_order(struct address_space *mapping, pgoff_t index, > + size_t size, struct shmem_sb_info *sbinfo) > +{ > + unsigned int order = ilog2(size); > + > + if ((order <= PAGE_SHIFT) || > + (!mapping_large_folio_support(mapping) || !sbinfo->noswap)) > + return 0; > + > + order -= PAGE_SHIFT; You know we have get_order(), right?