From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2066C4167B for ; Sun, 29 Oct 2023 20:40:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 15C9B6B0179; Sun, 29 Oct 2023 16:40:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 10D306B017A; Sun, 29 Oct 2023 16:40:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F16B06B017B; Sun, 29 Oct 2023 16:40:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DF3616B0179 for ; Sun, 29 Oct 2023 16:40:48 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 71456B560B for ; Sun, 29 Oct 2023 20:40:48 +0000 (UTC) X-FDA: 81399667776.05.898F66C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id B7DD4C001E for ; Sun, 29 Oct 2023 20:40:45 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Zk7tjG5w; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698612046; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6waNhTR+o+oIxNaOT4t0XGJ4/XH/ruK+m0W6clw3ZeA=; b=0PJKK0wi9hI8NcCV/1URPNOtySHKVRQxkiUVrkiVeyIeq8rBqgMuxR+dJZVcSirMJ3LDht D1K4LKKgcyGiExLCxt3cl+otq3+eLoyU5daF6PUtiLuYsRlzaQ+QtK4lmB/P91eW9N+dji jttq96mXZydNLlSABVXH1uAqRTpe+gE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Zk7tjG5w; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698612046; a=rsa-sha256; cv=none; b=PghkTwQhcz1rGdoJnG2arHZaX75w5925H3YvVG/D+Ngxz3mztFmKCYZW2j0iDCDN55wHvE TkkwbNTbaecmpo0KxMz5Ixqg7wBuajxqwKUEAc/OUcymDHVu6wzIsa0PRmAVu1o87Jn7Po s8ByblVUNwJSG8mpJSQC5i/DmHEFez0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6waNhTR+o+oIxNaOT4t0XGJ4/XH/ruK+m0W6clw3ZeA=; b=Zk7tjG5wKVi6QbIzzn68YStq16 57v23MVZQgD9Aaslc6J29o8nzcPpfIaCNICUhBsZBFWuGIm8XfEb4vxCMaSF+dMJyfRZZi07/CGgV sq9JWVeF3tzdsytUaezhQGt7uEt3kznNRVGydmi4wwesl92UY36yqjC/Y0/egKMQP8n3B2Ox84iJE Lck0evHllaksBJxlVP8BALQSRbqJCSTILL45M6shVjKVkGevDSdjIYf7zH7U6neFoLVVttXDNmj/J GqUIRdN4WvbO8XPzALUPUTaYd/OG6DQWnwXvOBFQ6TZazcr+wnSIt0nL0HzyPXE0cerIxNEfumU2Q FN5UO73A==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qxCaJ-00HaHF-Ko; Sun, 29 Oct 2023 20:40:36 +0000 Date: Sun, 29 Oct 2023 20:40:35 +0000 From: Matthew Wilcox To: Daniel Gomez Cc: "minchan@kernel.org" , "senozhatsky@chromium.org" , "axboe@kernel.dk" , "djwong@kernel.org" , "hughd@google.com" , "akpm@linux-foundation.org" , "mcgrof@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-xfs@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "gost.dev@samsung.com" , Pankaj Raghav Subject: Re: [RFC PATCH 05/11] shmem: account for large order folios Message-ID: References: <20230919135536.2165715-1-da.gomez@samsung.com> <20231028211518.3424020-1-da.gomez@samsung.com> <20231028211518.3424020-6-da.gomez@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231028211518.3424020-6-da.gomez@samsung.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B7DD4C001E X-Stat-Signature: ka3tpkscuos9999houa1e65s4oyf3ag1 X-HE-Tag: 1698612045-345326 X-HE-Meta: U2FsdGVkX19oV+1ozZvE3UITO3LE8xOwhjrMJ3TO5zIkMB3R9x/KE0vfy/eLU0dhsrvinMtHRjorj+J1TUz0H0mvSOBVcK1sELjLBJT5SFH8PvU3VYO7Ui3sn7lCtjbAvYoo+vs+Sokc19vLxSFFbdBbN5dG+QVpg41dGXC98PepPGym5uk4nuHyg+1C0z5SZy0//njMFc5LxMwhqcb76RrXNCC6PUkMvsYZfOKZuGVLVtkdQpVgXGm/GzED3muVm7bqTNyqlPNOJkoBGjkbCUaoFAt09eaUqfKUc3IIrxSAUgl/r9uw6tOAQLsJ/GwnThWn0He8kqpLH0Ot7PmHN8O8oxqqqyA4c2GfrX/6KEa7ceGG0XirTYcuy8ln86Af7PQ8JA57dtf/mRaqInq2J6vLNs3YuwCt6h6uBnJycQ8Cw/fLWj6OFQulVDxdc56af9LFhERNZk6WDun8q2npKx2R+Aa9zSIV6ShCJLbuXH1tTNW1g4EZD9gvH7tqzPF7AxkJm1SD1UJiORcSiFKNKkHqPcZenbvwm8DazgMYfU0dqKEuQ32gDbpz5bWeMzwFRIATTRXOUktoOtrKuq6MtEU9W0ZkRRcUad0/gNyqcjkr5F8QWLJ9ouWqrnYq9L7copy7/9wwtGWURErwA2qq7ieSKI5ES8d+QWyBdthTEWHXGv4/ofnkeloXgb7oSXT21Z1xv3AgBYQX6XYAG8VLCv+9C0H/LDsfdUTt7Fubu/i5F9xS4hVtaaUe6qbkzu/vW7JRWt0xWdpZY9QkcALP2ean1Mbt4tezSGsjl8jRrA7qDxlzzSzDKDvWPHDceEYSeQapEHauNMkTCP+gIYO8LTrKb3tF3i9OLV8kbsm8PoKsN1zKkud5gUi5pIp79Io0x4/0svEYoyWoDCNGMPIqzLXq4bpxVuEHJyh992iksyfMxfU9EuEZAbvdM1INytrl2opCoun0bksorM/Twkw 22+wYFb9 AL6V8IhAp+EhyhWeqzUQK39o0VL7oBOpTnPhBKa1NfLT185wh4XTp3333gllaRUBdJ7r29JNvIk8VTaXNj6QgRShzSpiFkwYsqziJtjfonZQH3dI8a/W4usYTE/oLManbZnagIxhzD/NUPBFujt15EAHo4aMzztERg9G1QqndExfJTtnylQ8sqVohqA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Oct 28, 2023 at 09:15:42PM +0000, Daniel Gomez wrote: > @@ -856,16 +856,16 @@ unsigned long shmem_partial_swap_usage(struct address_space *mapping, > pgoff_t start, pgoff_t end) > { > XA_STATE(xas, &mapping->i_pages, start); > - struct page *page; > + struct folio *folio; > unsigned long swapped = 0; > unsigned long max = end - 1; > > rcu_read_lock(); > - xas_for_each(&xas, page, max) { > - if (xas_retry(&xas, page)) > + xas_for_each(&xas, folio, max) { > + if (xas_retry(&xas, folio)) > continue; > - if (xa_is_value(page)) > - swapped++; > + if (xa_is_value(folio)) > + swapped += folio_nr_pages(folio); ... you can't call folio_nr_pages() if xa_is_value().