From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BE1AC4332F for ; Sun, 29 Oct 2023 11:15:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44C306B0168; Sun, 29 Oct 2023 07:15:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D5516B0205; Sun, 29 Oct 2023 07:15:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 275EE6B0206; Sun, 29 Oct 2023 07:15:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 13DD56B0168 for ; Sun, 29 Oct 2023 07:15:37 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D808DA03B2 for ; Sun, 29 Oct 2023 11:15:36 +0000 (UTC) X-FDA: 81398243472.18.4951F30 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by imf08.hostedemail.com (Postfix) with ESMTP id BDE28160017 for ; Sun, 29 Oct 2023 11:15:33 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=invisiblethingslab.com header.s=fm3 header.b=buFakbTn; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=BfCcUYNf; spf=none (imf08.hostedemail.com: domain of marmarek@invisiblethingslab.com has no SPF policy when checking 66.111.4.25) smtp.mailfrom=marmarek@invisiblethingslab.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698578133; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hG9nPWZ6C6E8JBsR1SCGNCxjbuY1BGNUrELIfEi0QXE=; b=FO86kyw6NZ/E37Bz4Kd3lw1+lkXEHFjjEiF9UNbtW5Af8txionNWuYm9ayEmpXkCu8086v 6BgbNffdrtZ7XXO5hGA89Dp6W6Z4ew6Zs7wjzSPwPojoQgHlQXU+JUVm9Qt8IvhyYFnWh5 dLoOVdSDWSMlQTdhOHcjOGaTQg0JlQQ= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=invisiblethingslab.com header.s=fm3 header.b=buFakbTn; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=BfCcUYNf; spf=none (imf08.hostedemail.com: domain of marmarek@invisiblethingslab.com has no SPF policy when checking 66.111.4.25) smtp.mailfrom=marmarek@invisiblethingslab.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698578134; a=rsa-sha256; cv=none; b=sn90cA1pJV1X4QdOx/S5n4PElYtYKUZDBCRgfoRA9sZ6/l4aryTns1FHJXtjmOt7d6F+yJ Z9TrW6BPn4//QGHb4QSK40YE45H77bQTZwRhG/IdlPpMzlXo9YK5ldb5NvQ2n6QMdRqpre EFGelrcOcSeM3ROrRa4pP0Q0uUgZ4B8= Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 11A6E5C0159; Sun, 29 Oct 2023 07:15:33 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 29 Oct 2023 07:15:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1698578133; x=1698664533; bh=hG9nPWZ6C6E8JBsR1SCGNCxjbuY1BGNUrEL IfEi0QXE=; b=buFakbTnTGDmwsAFIuyj1s2CkemgdADZ3/iAGZ8J3rBmHB871+c 7NJuGK+amNeXCdRkOFop6ZWb91eyxzSs8brwVMWcPpng/KZHQj6zBDYF26ze86sQ ivYXtvCROj5VAm3HilCp/FjLQgf2zDRGq1Ie/lU7vh5ZRO0bhuOWaYoAWNFCeATd sgI5PNL/wwuq6vGX1GYLuqLFQ2AWbLlmP2yZKgKQYGAWnKEU36YUSU+6A1yrXVFj mWNTndOCXHx1NwcRvL3VVUtFy5D3sLO6YPjd5G82ZoKWrifbhgtVAN4xn+F65E6j YJ2bywDYelNGlbHyYFejr5046uoDZgI2KIQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1698578133; x=1698664533; bh=hG9nPWZ6C6E8J BsR1SCGNCxjbuY1BGNUrELIfEi0QXE=; b=BfCcUYNfJ9a0Xg+Ap0fuDlZG26s1m xmDe0334Sxu8cR6X7YwVHVKRovO5tCg0iCy8jFM7luLqdzReFK7Z1wj8unYFSKnb QO4jL/BA0o03H/WF9KLrdTlsXIe4a/+pvVnpFhrBw9hGU9k6yNxPzBXjKk5603+y o6CJJmlL3eWFm4EPMGyLybaJbEI1ky7nizRD18yyg5FQLgJiBfHVymEeiR/rF7CE ESmRc1FwTtIGKnP8gGo9JEbifVQed864TRYXO4ADF4TjGkgvFJ0xUQ2LCenh1lRr UWaAq5TJjsbXAjTEUk4L/SMSge2/Qpy8mQfrW/5A7kRhsyX37PxErea+A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrleekgddvgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeehudff udffhfduheeitdduhfetueehheduudetieevgefgfedvteeuffdvgefgueenucffohhmrg hinhepshhpihhnihgtshdrnhgvthenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 29 Oct 2023 07:15:30 -0400 (EDT) Date: Sun, 29 Oct 2023 12:15:26 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Mikulas Patocka Cc: Mike Snitzer , stable@vger.kernel.org, regressions@lists.linux.dev, Alasdair Kergon , dm-devel@lists.linux.dev, linux-mm@kvack.org, Andrew Morton , Matthew Wilcox , Michal Hocko , Vlastimil Babka Subject: Re: Intermittent storage (dm-crypt?) freeze - regression 6.4->6.5 Message-ID: References: <34f6678e-6460-f77-73f4-fc8d3652a8e5@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JaZFwqy2vaQ13kIE" Content-Disposition: inline In-Reply-To: <34f6678e-6460-f77-73f4-fc8d3652a8e5@redhat.com> X-Rspamd-Queue-Id: BDE28160017 X-Rspam-User: X-Stat-Signature: euwb7hxmiwxtodcu8fhn7rxcfu44djbk X-Rspamd-Server: rspam01 X-HE-Tag: 1698578133-313434 X-HE-Meta: U2FsdGVkX1+GEICTWbs+inQGLQ2FJ13ISNbt04JYU7ipwSptp625942PzOQAg+WrlPLi21zaL+FvMJn2cwpJ2h60QkH1WTVWYpI19t1kamwQFEITKm9hfGCff0LuFNdXQN8XVtNaYQWqfr1KK2YqQA99Rd5jQmPAYTUQMuL6lqdDQ0OGeRwNNNvlmjf+GDY7CVMI7Qp7SAJR5n/oo2MTsHSmfTR87IVYnPjjvGRiXVe5k97QQGZ0C4jkgSIvTyS4nb/By0IjdqHY/z1oznij8hd+t2uXxbEbCFUoXurevPbOsO3iF/0ZEQVv5UhFPwXCrkI44hJkKbk8TNALSf5O+baedSVfP53PnjOGdIfD5q3EBLaic9zT63tmWA6OwaXuHh12Ein9WsD84Q2j58Nw2d4/LEI8hHtpXUeuKi2BwluvVGow/yEs538oR5YRhJJMkAb5iJyvVL0hSv3q9l4Bo0xrAXWN3o1RD8BQPBCkw2lIM7GcqVTa7HmqmihgFsi3ZtlA3NSaEJVl7PTnxh3jzQgKYxzEccJKDM9qsEfCgkpuK1ff2jd7k4u87TROxVhlR4AO57/pH6yWWnvz7CgqG4J2gvB/IAUwyynGB83ImKQgpsA0MghqZ9YLssSknEygnDKFuM/KTRXBxqOllkAJLs8D/SAze2IF87CQhoxbYykENvdfAONbOwF4khxWvcaLfkmKZ1cCfrc1PPpcpBajpNOHZT2DpG45+Td4NY9S420qf8dDBWO5Y+p2e1n8E9OnZ+c7BOvEJvU8O19bpGdE5zgAWbsqBi+9aUVisFS9R/PDdFq0UBglnrZKnu1y3sgp8PQWwF/9mJEfnV2n4M6sIGi7HfYdjiU/ksEgPBcf5KI7Sh9eVoz1KGsBsJIYcMe+rsQwl5cZO52vnZV/RSvhiq87bTvR85X7ZZcKuBRF51ER2f+lWn9icHp3pRxlA23UfDElpAq3FytEYy9fvSD hK3HB6pJ So6GDvk6POQN+jcIHbB1+YbwZnCibuUq93NZ0aZw93zlPov+YHfBiGzZ9wk2z3PdrhzCjJflM1jUpG0RmEq+8ugRLF7wJR8+6z3pSh7RbTehXli8NLcf17CkXx2Pt1L3UGXkhU/VZkhtdMnAhs6++3Ag/62a6hjZELN5JXT4M+QzVs4Jdi5JVm20eTwSDg91IN2K7y/v5unVx6Xd2/EoyB3HCqAydYvhrIsxGLRopUJoy1xilx63ISM+CC2RqTKOPRIpkIGBKjZPk0tcyqcuL+QURHB3dhYmDggLxoJ7Q7NbKaHDWVShKf1ZCQ/GGe4ygfcMXj4LEh0126Zpdv2QT4OQiHw84wsAVD4t2VFi5IStSHXh3osWv2bkVdaLXjLdsoi291QUPpVcg1Bhicn+xzmV7Nx97wGJjZ6k8LsI3TOOBv6xQuz0YZEF1zwQQTF0Vb3BMMSks8LzrvmHRhl+l+raZEbGw2tzQAQ4Wfy6VSoNcTXGlUuhIKMYVH6omm7M2IRpaYRuy36ORi6Kee7dsSpSBHAgCeKVjMoQ14ZB2c8TRLAULoSCKp2/CfazqJJDXXvfU1sIKUa1/razog8+MHBc9I+hcsDy07KKEYV4bg/cftVttZIKTV0DdjtP4fkURj4rQnU6I7T3WhqvF6Ec8hp/7R26XyEL3HkxYi/qLvibzIwpMi8+R2nbLGhRHri1Gn7e+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --JaZFwqy2vaQ13kIE Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Sun, 29 Oct 2023 12:15:26 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Mikulas Patocka Cc: Mike Snitzer , stable@vger.kernel.org, regressions@lists.linux.dev, Alasdair Kergon , dm-devel@lists.linux.dev, linux-mm@kvack.org, Andrew Morton , Matthew Wilcox , Michal Hocko , Vlastimil Babka Subject: Re: Intermittent storage (dm-crypt?) freeze - regression 6.4->6.5 On Fri, Oct 27, 2023 at 07:32:54PM +0200, Mikulas Patocka wrote: > So, we got no reponse from the MM maintainers. Marek - please try this=20 > patch on all the machines where you hit the bug and if you still hit the= =20 > bug with this patch, report it. I've tested it for a bit and did not hit the issue again. >=20 > Mikulas >=20 >=20 >=20 > From: Mikulas Patocka > Subject: [PATCH] dm-crypt: don't allocate large compound pages >=20 > It was reported that the patch 5054e778fcd9cd29ddaa8109077cd235527e4f94 > ("dm crypt: allocate compound pages if possible") causes intermittent > freezes [1]. >=20 > So far, it is not clear what is the root cause. It was reported that with > the allocation order 3 or lower it works [1], so we restrict the order to > 3 (that is PAGE_ALLOC_COSTLY_ORDER). >=20 > [1] https://www.spinics.net/lists/dm-devel/msg56048.html >=20 > Signed-off-by: Mikulas Patocka > Reported-by: Marek Marczykowski-G=C3=B3recki > Tested-by: Marek Marczykowski-G=C3=B3recki > Cc: stable@vger.kernel.org # v6.5+ > Fixes: 5054e778fcd9 ("dm crypt: allocate compound pages if possible") >=20 > --- > drivers/md/dm-crypt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > Index: linux-2.6/drivers/md/dm-crypt.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- linux-2.6.orig/drivers/md/dm-crypt.c > +++ linux-2.6/drivers/md/dm-crypt.c > @@ -1679,7 +1679,7 @@ static struct bio *crypt_alloc_buffer(st > unsigned int nr_iovecs =3D (size + PAGE_SIZE - 1) >> PAGE_SHIFT; > gfp_t gfp_mask =3D GFP_NOWAIT | __GFP_HIGHMEM; > unsigned int remaining_size; > - unsigned int order =3D MAX_ORDER - 1; > + unsigned int order =3D PAGE_ALLOC_COSTLY_ORDER; > =20 > retry: > if (unlikely(gfp_mask & __GFP_DIRECT_RECLAIM)) --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --JaZFwqy2vaQ13kIE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmU+Ps8ACgkQ24/THMrX 1yyy4wf+M/HkjAHUOykzSkcTW+8halVvS2uzcggOdM5RpP9Djo20fE42OqzroPNv Ua36RcxTuODyPFrJksGkrQ8N4HdMhceO1aE8d5xddMrZFnRVngJ0efN9TzhRYs+d fZ0hsRZ78rXlfwVkxugN3clx54gdk3Gob/Z+6Av0d6yT8CQFnRy8X4fVNMFDfW0h PM1FdVNtdMom3tSeEEkFKO/FWi6dEGTcO4C0pNPuoN8q93HGqZg1Nxj4VQD1yGny axCjIJl+D5z2mxiPQaPKOkuhOZNZsPo10iFLV8lwtm7Ge0Q5mWXCt2oDzTGcWdQK v+cA8UEUM+s3Shxt5wXIAoVl28dI7g== =jJmi -----END PGP SIGNATURE----- --JaZFwqy2vaQ13kIE--