From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F419CCDB47E for ; Fri, 13 Oct 2023 15:19:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 748628D0029; Fri, 13 Oct 2023 11:19:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6CE978D0015; Fri, 13 Oct 2023 11:19:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 56E698D0029; Fri, 13 Oct 2023 11:19:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 435E68D0015 for ; Fri, 13 Oct 2023 11:19:13 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 05113C03B9 for ; Fri, 13 Oct 2023 15:19:12 +0000 (UTC) X-FDA: 81340796586.09.629FAE3 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id 576C7C0008 for ; Fri, 13 Oct 2023 15:19:11 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=wYWLKRI5; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697210351; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jtSZR0F1KHMpVPGE+pJqe/+tO1g6GlVRmaItwdLPXhA=; b=VYAJv6GHVf5xqhqMYElq/UHY/T1LrzXY84UUew4uJuD3/JNEhZYOYvuKeV+PLqY88vTpYr yg/j4p1upt4CuPr5TqwAk5kOOPkh/uGeNNZZ4YUdGI4QA8xUQEGv04Mi9DVGTMMcbfLFLk 0ZWABnabu73/DLX1h/CksLh0/rbcwvA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697210351; a=rsa-sha256; cv=none; b=Bc5cMIjlYMZoeUtANJWFK3QcqzrXuhbAeS05q78N8SS/ImnFeBImmok4KJfvmNkgdv/u9g 8kkHmDv756sTu+isEFxg/xfEZXvoSudMSiR2W2/ZXsm0ehEhnkMuYdaU5ulHoX8z54zuL5 jr47Ad7oEFpadWRB5OcCX0rslb9Datc= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=wYWLKRI5; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jtSZR0F1KHMpVPGE+pJqe/+tO1g6GlVRmaItwdLPXhA=; b=wYWLKRI5iAPongq6yhQThdC8/k A4G3V5git/3R0IpNBM8V7UruHWvHlDMogoIuV1N5vXjRNNd3Su+NSthrHyI/WDQ48Flmm2fwvIdp+ qwMx3ZrAdGp0R2roiCR9vWLoxgpoQmfNRO9T1/r7HiL3duUhP7HHoXRmmZf+INJ9gkFZj69lzBmxf ZCtMNc8LTdR7IqTmAsJkbJqPbeb0LXbyCChwiXRtmRTnlTxtsRK32QMRGU3O+PhWK1paBQpd8MquT N/9kUW1XK5aYzg1SY2a0Wuke2jH232VBCJO+dkW13NVQlsyenqMqSn//JrtkHjmnjamLv+o1R7m1+ +cCqxIlQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qrJwQ-0064qj-0x; Fri, 13 Oct 2023 15:19:06 +0000 Date: Fri, 13 Oct 2023 16:19:05 +0100 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ying.huang@intel.com, david@redhat.com, Zi Yan , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot Subject: Re: [PATCH -next v2 18/19] mm: use folio_xchg_last_cpupid() in wp_page_reuse() Message-ID: References: <20231013085603.1227349-1-wangkefeng.wang@huawei.com> <20231013085603.1227349-19-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231013085603.1227349-19-wangkefeng.wang@huawei.com> X-Rspamd-Queue-Id: 576C7C0008 X-Rspam-User: X-Stat-Signature: gkwfc936fiugnj7xawophbwnix6r6oo6 X-Rspamd-Server: rspam03 X-HE-Tag: 1697210351-54495 X-HE-Meta: U2FsdGVkX1/WAq0FAsffy2hFgDheY+MCz5nh9SkS5V4wP4ip4vNB9Hrn9XA4Q1C8uGUI3NyDbDLyjTvEAg0KmlHfolYf5NfHN5I/xzx/QOOq+xOABlboN6C9U0uYT3Em/tdVhyaZhX3dl1DTXgtUqr8o0acmCr9KfZcEJn+JHDdcxL+YHpUrq3AEQX+FfKgqisCay11cw54lCdkzjPk47RAvi94jVGJr+VdQOxNOR3PfvVmLkR6nMDgbKQuHt0zpohCpP58a42uCFE2NJPoqj5bOaXGJ+i+C0yeVU/7gJXTu6SDc3MIlFu/HVAkvf7HcHWwlbs0umw4SBuoxucAf2BhY5P6ortnQ/fyNiF5Nna7iXvx4CNEhZGk7TiyNXX2+dKH3LJoPUqwp+6DS1WKN/Zb8QCmvLvIlwxP8fT6eLNoLg3KR5ZtfHTOfPeAwvv0UH+FnF2JrczQGnkeMyYNlEI/DAWS8Rv8hzn7lCatECXyo5mvDRcaAop0afyWeaTkoYoFdzrBHkASmpB1uH/N9vDNFUMxpy617w0xYxqxdQs8kSzP/ZnNmuxXHgPH7qn+pLDaC8cMWEUGGr+YfLTyDBSiDfeAneBxtLrCVo4ZB+ZrEgn5pphmpjCuCAPFuwGmQgLMF8TdLW3ilRrINfWnSZd8bIC6fwED5Y1tm67ZlXbMhl+rj8BIPP98RpsEunF6pX1nEZ2IZClFaR0+H52ut554eijKSnApoZPsK568D+pefi4THhgWzGE8WSHmtFKtmEPgVlZB6FxlLGKX4nFhFr9YX0MRP3vNRrltwPhUpQ/tP8awYp6yj+P9rKVO+JzSQvntb/8BdA7p1K4co0D9sVqIolyICygSIfyTEAbBB4L7enoia4IGT1Qj9KLfGWOduU+1Ons9VqrKQ2jaK5nK/vLG9LmkGf2WRafm4Pb6ffECitmizgW/sWNhyZrhg77fFARk/OKdfSQGJtmAbtlS RIOxsbMl EA0UY3FBMJW3i9OtQTEe6uDEUDhGgcQp69lyn1tMKBoDee5NKKVyAOmxa81frAZQqFPZXWZv9GEOfh8ZAaLp/nt3pKEqCzsfP6AbkOBZmbCcNQERdOXNrn2yUsAJ2ph1TlY13vvOG6vyIPVLDKWMC7xqBGOpQAOoHjxAmmpWtUbmzarXnLpwrkentvg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 13, 2023 at 04:56:02PM +0800, Kefeng Wang wrote: > Convert to use folio_xchg_last_cpupid() in wp_page_reuse(), and remove > page variable. ... another case where we're changing behaviour and need to argue it's desirable. > - /* > - * Clear the pages cpupid information as the existing > - * information potentially belongs to a now completely > - * unrelated process. > - */ > - if (page) > - page_cpupid_xchg_last(page, (1 << LAST_CPUPID_SHIFT) - 1); > + if (folio) { > + VM_BUG_ON(folio_test_anon(folio) && > + !PageAnonExclusive(vmf->page)); > + /* > + * Clear the pages cpupid information as the existing s/pages/folio's/ > + * information potentially belongs to a now completely > + * unrelated process. > + */ > + folio_xchg_last_cpupid(folio, (1 << LAST_CPUPID_SHIFT) - 1); > + }