From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33597CDB47E for ; Fri, 13 Oct 2023 15:13:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8EBBA8D0165; Fri, 13 Oct 2023 11:13:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 89C208D0015; Fri, 13 Oct 2023 11:13:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78AEB8D0165; Fri, 13 Oct 2023 11:13:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 68D058D0015 for ; Fri, 13 Oct 2023 11:13:31 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 401281203D2 for ; Fri, 13 Oct 2023 15:13:31 +0000 (UTC) X-FDA: 81340782222.04.DF5D577 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id 6C15B180007 for ; Fri, 13 Oct 2023 15:13:29 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=NW+tvKqe; dmarc=none; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697210009; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BOh82QvDFZhJOtnIgbuStQUDwvPFQ9iupCs1NikscMw=; b=AuOsW+qfIeqbQRr8SNg2ejSd53cm3tWIGCgk1Fqo9iWIETAjdDvF00PiWTVLdqo+kZOW6e cXEG4zuC82acgh3+bUK16MpOeRAqUNWG13lfbwMgMmqVZwxY3rmYP9As9SKWUKHaxkCuQU pMOeslFCELb8LgXuE2mTmG7xdIefLc0= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=NW+tvKqe; dmarc=none; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697210009; a=rsa-sha256; cv=none; b=efsucDM9faSZhvynr4HGBFMOoH7ZVr34FnEOEsD+209t9XCCPrvyhYGz7XCXuvYND/+Q/+ 2LMjZgqMg51Cv7v6y1uDvd2s4Xx0PKLesWM7Y1MnY/7hQvmjm5e3nVkL6ygHKUHmActtaN dBGIFM3eQeOWNPHpi+WB22D1Lg7iWrY= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BOh82QvDFZhJOtnIgbuStQUDwvPFQ9iupCs1NikscMw=; b=NW+tvKqeZ0wjPGq7fFq6dMhae3 TS9ygR0E3gU67YisMzAFIgo3fe32bEPTBSQh53LYVPYwLVDmHBxEpYMnBFEdHlHOug4EnBcG0LqHX WCl9oX3bokAQUPTK0jmkt1AATxNuwD/Sh9x12A76R3IFYk0IzqUAHq8ijIUtkUu8qK6B96521FMn2 gfpG/H+9Wpw1xIbsvIP+L+3BUMbtGERHqRbuukPehdqfR1uQm6vcuNtj2m6CYeu3VWKObbnv45vGs pclH9hg6P7q3Rl9YR8ZodXdgKu9X4GWcGXzDr3pHZCYkM2BklT7c2+agus4kQ3zyN9Ax9rLe2IL4N gkvnN5OA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qrJqt-0064bK-3u; Fri, 13 Oct 2023 15:13:23 +0000 Date: Fri, 13 Oct 2023 16:13:23 +0100 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ying.huang@intel.com, david@redhat.com, Zi Yan , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot Subject: Re: [PATCH -next v2 09/19] mm: mprotect: use a folio in change_pte_range() Message-ID: References: <20231013085603.1227349-1-wangkefeng.wang@huawei.com> <20231013085603.1227349-10-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231013085603.1227349-10-wangkefeng.wang@huawei.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 6C15B180007 X-Stat-Signature: gswwwoy4knzps9ceipu99fzisohyzugm X-Rspam-User: X-HE-Tag: 1697210009-667881 X-HE-Meta: U2FsdGVkX18hgr9qZKdJZOaxoLON7Kld9NaLFNWRPpfT5eGdfFwGEsmtP7VBfZ7QnGKfrao5Wj4LlpCwg9DmoM2DScMDptYYhK6Dc22S2dTcZmg0eSoVv3NpVaxBfVxGyrk8yElzR9Yg9fQ9hOebPwOxCDKK2B2IjxqkP5bedLy8xnhrcS4ti2q7sXtxeQ9XvZAdpiiLKUEpIiAumWTKDPYVSfh/bUc+vjTf+rkpo26tkiNayRo6x8BGbPkm940UonSqkL/qlpg1laRmHRGfFB3hlIi2R6gf5jPXwBRwzySoCWxnHNNL2bjGE4buShTwh7frnOjD+1eAq43jeuBXXBeEUnfoDV9X9D6V2EBsQDXRlNJXLF57UIu8dVjgFp3YRrcFMJ7YoOf4HLF9n3lCHPmusczvAKN4IE/vkEae8+Fcay1jX50yT8WEMmBfeTo4dgEtrzukF4suvuFdk6C7ZVH6CsVxOtkisCqiWfTY++ga1Hqld0+l8B9YyLgqQnv4lUS0YtCrLVZ3UmMrZO/smD1UTpjXTAu/FwLHuczCj88sHqOyqClPkmunD6BwqVfXelUYENVj2WAAVGMQFyrIANA6TgxFkY8VeGEZ2N9tEwEgs35b9hGI+Yhc1c/xFF8aBnJRQVO2osZ1phJ2EioUZVgtjlAWZh7F2ncBTC6lont4etIbY6D4ubxVzNggZ/Ff5lLSAODkcSHSOybKHiv4tB11gsAHYHMgld2OOtdt+4FikEpgWiiPosmHoBpA3UGul/gnNJWyKjLm9aMjIXPtZhEm1yd/vIx4F6jfl2fNmcv4yknESy1QyH1jPSWgPl90LGN5V+xnLF4yn+b+oivY/GMbQsFmDbMM3MzZC14eXHf/pvJRU8bfeyVBjf3hgWPbl+Tu3r/WDEdf86vtrJ3KdFT50mI4b+h3HQqPoegTYejxWBgE/g2Q9xvQWi6DFuFSqMPSNx12oIW+UDd7Ivl YJHCT9wj uML5eFCKgR1R8wvygv9hN9pvEGWCd29/mQXCEJ6imcFfCFKLIJLUZJiRbHLnE/Q7KdE/tZrMyS/p7O6Tl451Gpd5iS5WEIianpUFOE/QgC8TPpxI6q975VngMT1bXc7gDvK+MD9NLtfrcLiQ9kbEJqcLrvmrHm2orPePfOUloJxjfAaar/WI58vyMRdtbkd6Mv5fh8buJXu95dGY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 13, 2023 at 04:55:53PM +0800, Kefeng Wang wrote: > Use a folio in change_pte_range() to save three compound_head() calls. Yes, but here we have a change of behaviour, which should be argued is desirable. Before if a partial THP was mapped, or a fs large folio, we would do this to individual pages. Now we're doing it to the entire folio. Is that desirable? I don't have the background to argue either way. > @@ -157,7 +159,7 @@ static long change_pte_range(struct mmu_gather *tlb, > continue; > if (sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING && > !toptier) > - xchg_page_access_time(page, > + folio_xchg_access_time(folio, > jiffies_to_msecs(jiffies)); > }