From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E90C1CDB482 for ; Fri, 13 Oct 2023 17:28:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 54F6B8D016A; Fri, 13 Oct 2023 13:28:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4FFC68D0015; Fri, 13 Oct 2023 13:28:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C7388D016A; Fri, 13 Oct 2023 13:28:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2AFF38D0015 for ; Fri, 13 Oct 2023 13:28:39 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B47D58035C for ; Fri, 13 Oct 2023 17:28:38 +0000 (UTC) X-FDA: 81341122716.20.D5B46FC Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 6FDE91C0017 for ; Fri, 13 Oct 2023 17:28:35 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=LfICwqNB; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697218116; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Imrv7hD55Mkc+SEoB4XVFrWjYvya+wwXsMRtGt0H5rA=; b=gB+RvsC3lxncl1u8aZaHE9FPgiw9rOT8TiMXaOHrm+78YMFtxatsjQUX0n9dVJMDm5XUn5 LUVORgy2yXITg28/VWxpPGz0X2zVqnGmXd2doH8WMZwoj5uvXxmdYCEGmjyHVoYS9Ue67q H/WsHR7+fKL4GXXJ/D+b0F2fTcZwgcU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697218116; a=rsa-sha256; cv=none; b=w/odVW9OmBhPi7P0lE4Bq0+0ICLrUav+UT7yYXDwG94t979fXLOFd1EYj079T8QoHmV8/q A0OxrW4NPHrqMrUejiuJtVqXSl2psvbEv4F4BO1ZP6Ea9cm1oYRzRh5nuOebTx5Gxx4494 EOvt7RJqd8Cj23LvJg/OSHlihc0GZxs= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=LfICwqNB; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Imrv7hD55Mkc+SEoB4XVFrWjYvya+wwXsMRtGt0H5rA=; b=LfICwqNBIzNu3ioIqF7lzF8PE1 DNNDcUO+WN6s+RP2OMkJT/qU5k3RBo3ANrYkhAsydqGKT4ioL2RtakBCc/WjI9nTOwQif69iGoPrM LIItLhrydjykR5FjKmttU+4/HwxH3uPMKcW4OygWjeOzbFRQPkvG/O43/t6okeN2/i09crXEZFKzi k8D4OvY2OQU2yIehhAKYO9ouGdyvJ4MFCcMfiy3X2M3RigM5HJi6BJl951Sd53Ypx8tChN8KFZLHk lxrVWGWMbWdDCC0v6yBYd6sAPv/6oLJTbIGWhm8cJL7F7vnRHhJQBHkL0w7AwREstcKxvFjdi2A5A So6VZ8xg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qrLwx-006d2F-Oz; Fri, 13 Oct 2023 17:27:47 +0000 Date: Fri, 13 Oct 2023 18:27:47 +0100 From: Matthew Wilcox To: David Howells Cc: Jeff Layton , Steve French , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Dominique Martinet , Ilya Dryomov , Christian Brauner , linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cachefs@redhat.com Subject: Re: [RFC PATCH 12/53] netfs: Provide tools to create a buffer in an xarray Message-ID: References: <20231013160423.2218093-1-dhowells@redhat.com> <20231013160423.2218093-13-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231013160423.2218093-13-dhowells@redhat.com> X-Stat-Signature: 6gaizpwgno7bd44ryexpzdgprma467po X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 6FDE91C0017 X-Rspam-User: X-HE-Tag: 1697218115-305961 X-HE-Meta: U2FsdGVkX18x//OoZGMixmD4uQaJ4EHH8BZnzx6TsBWxeADl494+/M+tgrTvtdnW/S+NjZqZYLdOOU/gYpcq9SFvDizQx3lMp7wMY/sl+vlEC+10v9/urQ6gAwHY57yno8TWlm/vnndt959ASkDAYYUMLcI+mYY22kPGMSH2KyQbm339N5WxFIk2KJxy6X1cv0m/RH9hQ9MuZc5JvtF7c7nawidEOW5phDfCHYEpGJLm828vOeY1VqYH2P24Dq44BGxYjiKjI+unDKvIlJYMUyWzR/Rtt+pcY4OynhnRVDDBAolYH3DobArfgqmcMFmJR6z1nYZyY82rT0weE6gUmmKpdLAmYFJeCsas4F1eX+kVhJCNCNFfmLdoV525qP8tUFCEBWAiV5u4YaS3ai8Mw3Wadl4BocoLE6Z2fiXIlqiOe1AqT0+50diC4HoxgCxeotOSBCyK85cAdK6ET9x0fgHIZOCU6ezb9Vm9EuEQx9mQizYYGRuQh/vyZ4L+4oLI/E8T01lCwbJPipcqIN8d8Cd1WIBmimvelGC5zcd9vq9WGSj5gjFiHNiIHxs47O2+NpfGoQkTiI6jRDN9TZlmav64HMZCtAEl55G7OtiaogbDBLKSlCqNi8oFmV7ls3wEhJqFmw+rfFpuTnj0IruubSxw564f+jhZMMEYml6Z0cwuE7wU+RzV6mpdQ39jw/41r2arSFSNlyqnydJfXxXgpf6BO53MQBE9t1PN7iX/u3bKFkxUEcjTEKyvsQ3jxLjWA63w/8Ygpktm9UScjkZF0odHEnU8s30SA+wO6a/ku8sOTuxLYndjFIhPqBCXEO4xSFVQ29ccT6o34VPGeZlwKywlVQ4Wy/vqf2Tbpw52rVS7XW8qMB+6oJMu7leuVE3pvNw+gzzbAc1cqRlN2kZARCLrhzVvNv3s6gIvsq3az8ngWfD1K+FG0RQAgheJYUVflHyMsooVKnd7NZWeFjR t8Vdg6aB +yXi7ZZORnaZjOY4YktFJc5m0pOgFAXFeWU0GGezp1TJgV+5NWpxYCEUvg2WfKTbj26e/mw0DMzPrbjEOVgoGtjoXgcbHnsAA4SiA8q6D7D5Hp8Eu6BBevJ64xcxpfOA6oca0uYhn5PCVbFaNEJzBE1y1/GcsTTqkCd9iMqp9ZeqRGtFIo9Ezir76jRp19zriUV/AJA8aULkL+ZE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 13, 2023 at 05:03:41PM +0100, David Howells wrote: > +int netfs_xa_store_and_mark(struct xarray *xa, unsigned long index, > + struct folio *folio, bool put_mark, > + bool pagecache_mark, gfp_t gfp_mask); Linus has been unhappy recently with functions that take two bools. When you're reading the caller, you see: netfs_xa_store_and_mark(xa, index, true, false, GFP_FOO); and you don't know instantly what true and false mean. He prefers #define NETFS_FLAG_PUT (1 << 0) #define NETFS_FLAG_PAGECACHE (1 << 1) and then the caller looks like: netfs_xa_store_and_mark(xa, index, NETFS_FLAG_PUT, GFP_FOO); and you know exactly what it's doing.