From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F75ECDB473 for ; Wed, 11 Oct 2023 18:08:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E67548D00CB; Wed, 11 Oct 2023 14:08:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E182C8D0002; Wed, 11 Oct 2023 14:08:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D06F48D00CB; Wed, 11 Oct 2023 14:08:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C02E28D0002 for ; Wed, 11 Oct 2023 14:08:48 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 893B1B4E71 for ; Wed, 11 Oct 2023 18:08:48 +0000 (UTC) X-FDA: 81333966336.10.7C195CB Received: from out-192.mta1.migadu.com (out-192.mta1.migadu.com [95.215.58.192]) by imf15.hostedemail.com (Postfix) with ESMTP id C7348A012B for ; Wed, 11 Oct 2023 18:05:57 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=FVSrhZsE; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf15.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.192 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697047558; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CjATHd+PMfSbpzqzLwPd5xrtwunRsm3UnhcKphRYNsM=; b=Jr9I53EO+BhUtmEeohcKShvGN4b/Q+Z7tLwADSih4XDPkIKEVzT04vVwdNMB0P0dmVEfKK Ffb6MKGfK+8dIvhWZ+fSInd/S6wlf1gDBnu9LW75Q5p8kITRhcUj+y7bc6R/h6m74QwV1m cK/1IRBnxGfPONNJJgr2UdKYtHtge6c= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=FVSrhZsE; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf15.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.192 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697047558; a=rsa-sha256; cv=none; b=FC/QGAM3K2AhTI8BV6J9LS2sJz1ClJQQ6iuX5X/xyrsdiLuuh8RbhLA7l/syUm1vNGAS58 UaN/Md3775mkNqCD+TAv6ekQX7q3c4EnxJ7N/VKyS918RIKjPgIGUII4g8llVKEtgQFsos TUcWveAtytI0uyGrmlQjuME87gdZbaY= Date: Wed, 11 Oct 2023 11:05:49 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1697047555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CjATHd+PMfSbpzqzLwPd5xrtwunRsm3UnhcKphRYNsM=; b=FVSrhZsEnpEzGL5LUXJSsCuoYcWSLHxZ91rxb2HjIW75WtaivZUfJ3G8PuwMEfpEv55i3Q l3YKiu1gw9A9dJLekGsmIZJggKjIJbRYNce49GtNxWIVUrdfNhuuM73T5BmVTJr0N++w3h SU9mAOIxwVJXyMN7t/kFnefWd8IJoBg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Shakeel Butt Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Johannes Weiner , Michal Hocko , Muchun Song , Dennis Zhou , Andrew Morton , David Rientjes , Vlastimil Babka , Naresh Kamboju Subject: Re: [PATCH v2 2/5] mm: kmem: add direct objcg pointer to task_struct Message-ID: References: <20231010000929.450702-1-roman.gushchin@linux.dev> <20231010000929.450702-3-roman.gushchin@linux.dev> <20231011180101.o2ha6awrupojcu6h@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231011180101.o2ha6awrupojcu6h@google.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: a15k9xuergna6b7fzu9jaekkfaresr5i X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C7348A012B X-HE-Tag: 1697047557-948180 X-HE-Meta: U2FsdGVkX1/mDPPScFL/2BT3fz4TQUXjFT1MvDM5gFRVJbygrbILQdquwwlUEyoLtQrHi0wgvOuY5ZOf51+J6d28DowwuIm94XClZqdqrxWc9GZ8Kn7EpUkpVoWtAqBruuf1V2TzoPHqUdp0N1auP4H6tfvBZoiS2LQtWzji2tBMFG5ARptCdTh5b6Jahbl1VCnTjpwIUpi8ohtAdNk/sS6guOTSjpDLa/yP78ns/Jq74B5QlyTG22O1OceUwO35LoJlngxxXP5w2pXY/c6eqlYhTEMIoLUfunt8UnpOG9tJeW3iej0cjbEC0NB/6QZsU+GodFfGHcLfPNvkTTxbBAwSrk2BwIhzf5cswtBFcsal/aFVndtT3R7wJxFq2hmk6h/ZWnKfMLagajFLASmF0afIH6CMS6AopW9ZQaOJ5uLO8HDcCUq/bOVVMKvLv4ZcMI8yeOJqZ2daJMYloQRC4yv5Lv1xmx/aRxZdvjkt+K7MpVLjhy0bWNWgQunWTpI8uHnRIzw2vUsZLFlVIlrNkGB/TPlERhNH0a9WU3ibq0WOt1DVEjAyop7Sj+FGWNKc5Vfl3V1Xc67V+DDWMpqmwedAhZA38Rh0+LuhDjc3CN4WvoiCKAhTtGQtzBK3Y9KagKVQl6o/Wsfg/I5q9ohyagBdpCcYm30BFpvVarjotTL+0Vaj5l5sqJCFTdZm39L4ubisI1fc8g9fOQ+NfmtUAaGX7AQU9sGDYa+TLNoL5P5VRnU9B17EeTmf4UwHiadKMWxf3HeG+589d1ux6gUGy80AmJzPSin8lkFDUzB67/d+gsBqF1Izm+eL2GuRm0rBNX4XeBB1rUGSOMB92eKCh9MGoTFHMqNXI/jbjE43apFuBWjg1jUe0NroncgO2yxP5rLaFE+0Ofj3iXsxXZ80H5Bq46AsmTClptah4WccWhEfD6c5EQvTOcJMmLZjS+5sCudag1Ti4/35/Gxvq4G tCExGsEW cnsN4TJKfZim/2vL3Kv7XbM6MD4s8PhPMvprtuH3Rm2eBJRA/2LGPBr19NJPVmmW6zKnsKsl/FQgoUU8MlRJ//yYLcO2tOi5kE1J4S2Fqu9rfLRAdVaHVY+7J9pAVGMCoD7vqNDLGmdeKqn1niL/C0zTtA1Qn5ZyDgE/pnnfdm1mwjr6oprlN3nj2Qw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 11, 2023 at 06:01:01PM +0000, Shakeel Butt wrote: > On Mon, Oct 09, 2023 at 05:09:26PM -0700, Roman Gushchin wrote: > [...] > > +static void mem_cgroup_kmem_attach(struct cgroup_taskset *tset) > > +{ > > + struct task_struct *task; > > + struct cgroup_subsys_state *css; > > + > > + cgroup_taskset_for_each(task, css, tset) { > > + /* atomically set the update bit */ > > + set_bit(0, (unsigned long *)¤t->objcg); > > task instead of current ?? Oh, right, of course, good catch! Thanks!