From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCEABCDB47E for ; Wed, 18 Oct 2023 15:48:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D04C6B00EE; Wed, 18 Oct 2023 11:48:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 37B556B00F5; Wed, 18 Oct 2023 11:48:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2445B6B00FD; Wed, 18 Oct 2023 11:48:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1329F6B00EE for ; Wed, 18 Oct 2023 11:48:12 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CE651B5F2A for ; Wed, 18 Oct 2023 15:48:11 +0000 (UTC) X-FDA: 81359013582.12.91E306D Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf06.hostedemail.com (Postfix) with ESMTP id B4013180008 for ; Wed, 18 Oct 2023 15:48:09 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf06.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697644090; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V5NbIBGT23EyXHwwK6xfr3d9qmNS4jz1Vuqtv5fT9AU=; b=e3UBQVrHCUA01UWRUOpCjOIN77OikSd5gLqyjVXvwPpu1XCqbdg25exyI+4pW//SEBFZIX GgWvK9FrhWJKORhV9gvJ0yrbDzumJGp0kwzp/aP0F7p1lJD+u82HQiNQHzsb7OnpRpS4Id cXsbFCCyjUzy9JmjNbAVfFGt9gUcgLI= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf06.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697644090; a=rsa-sha256; cv=none; b=MsZp/ubzzcyEHozuB/sP2bxzfQR2n32nnvsBhz73AodRT7eDGQN1oDKAoiRcNeyQaW8l84 wwIu3eUoQVIQDEvO0WUrXm3NngQ+CCDHdwwKRKx1zuVnLFGf0jWJ8DmYZDKpGhQlwK0zJU BNypMkG6mfgVNJcIoekH8b9yzx96VWw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 1CD15CE16B8; Wed, 18 Oct 2023 15:48:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10BCAC433C8; Wed, 18 Oct 2023 15:48:03 +0000 (UTC) Date: Wed, 18 Oct 2023 16:48:00 +0100 From: Catalin Marinas To: Liu Shixin Cc: Patrick Wang , Andrew Morton , Kefeng Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 5/7] mm: kmemleak: use mem_pool_free() to free object Message-ID: References: <20231018102952.3339837-1-liushixin2@huawei.com> <20231018102952.3339837-6-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231018102952.3339837-6-liushixin2@huawei.com> X-Rspamd-Queue-Id: B4013180008 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: kkc9855ttca8bfmonxnt51n5r6nio8ae X-HE-Tag: 1697644089-193483 X-HE-Meta: U2FsdGVkX18HsL1MGt3NzP9KustECF95B1nLN68JRGCcJHmSFz8GOyfNSEjR99nIQkElI2N1lCCijnfYeDEffEkfvYR7qzvlaz2RN540dl046XwYmpMdiWFMnu9U8KKgcWi87HurD1X2a3WdzmjuKtADE8O61T7Ct5XiFnyMXLZb+LaSQqyfMaOoqI1SxdXRsWtnao+XZaeDTcmNFEs5lrYKLpdfhZIwXClY9mjrFOpv2L8teqZ6ERB6malNBsEqvHVczWEGL1OseUEKIaJjH0hZHsvPqy7+G7EvrGM7IwpWEFlC0ZYWod3+1Skrv3FVOMG1/F5ewodDLzeP6Xqpi32BZ7kn+yhC9MM67ZZZXjwc3iMt7RY+U8xBJMNmIOEr9Bp2euFoOSPoqhJm/nSqriSp67UiKBuR46TXofI6HReQY2RmU79WOtXRXtRGnl8q7K7311W8FnAVh8OcBbwCNpt46H+wPuIsPzRbqvGQ0vlJ/nipx+7pf3846VDJrWirjNyHbqHgGlPTe47JhK9hVmbne9Ua/2yXLMJzhML/x63xttf1+heiPcEgxB9lRira9goSwLwiSDKrfZqE5XyCSN6rqrNOVSIYR1/CHdhNlgEa0fchXX5kNPMKrbr+bYjp2yr5rTJWhaRnxaM6RksiRYTRwLCYW7tMFIegz6E8xpLnXO8VUkNj2EQMbdVghOLkptDkczaWK1BXkLNS2KUFMxSvNpUcy4DgIhdcQ7knzPQng5z1LiGgFC0Bl2xd1YPKhU367Rfr9NSy0LBMHvqHQmNJNv9mdjpEDvvVTwO8pKBpY8GniquKsaO2BzrjySh+7AUzpM7MVbGqUxaTB4Wg2TEqkxjn8LIPtm1lUGv9wrZxHkXKeblr/t/c3aclFMKBuSEblWEeRQWm/2+f7Qfe7FLq4k6M161YDahUYfCtXt6S56GPVIkhjnzRjwID9v8yhjwiHKAggXr2+FG2geQ mZsv2Nqe +KNkGSJYEOcvuGbLoHa/XSZ1j/dB7V1WPG5TtfOU9j+AS98TmPvjIpjTV3bgFbXKADG8FMABObIJ6uRD2ry6ld9VsGe6TgC9XNZUi/ogPvnnr3eMkYyMyqhSaYHy3n6TDeAC+japUwuu8WdTQCWZMhPL1JJy5HwXrCTNf8QHm010BpV8O3fiztEgq3H+EbJL1cq7XA+ycle920eHfHEcvIQBpODOAaSaVVgLyl/t2qlOVQYfc6NRDIEYMLfXyxG+skxjdAjJyT2SJfPCaoCg/UHJKUDNDkMAvMpDDfikxjdTIOcDUXEuVwnUyshx4ElqJw+M7AVv+INEwCAzolBMa8qcDLlUkYyUnBA4yTko+HAkMi7xPAT9vQwBvOvlH2Y2ifzUxBO1qo3qt0bNLPuOtClNd18kF7Ra1hmsis+yZXPJVi7CXPgWEpAymiIlqHU5HjV7iKLu+kKoaXef9X1dqqHnbNZRc/8mCJrZnuENigwo0gYPrXRoBNck2e/X3WCFCuMLq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 18, 2023 at 06:29:50PM +0800, Liu Shixin wrote: > The kmemleak object is allocated by mem_pool_alloc(), which > could be from slab or mem_pool[], so it's not suitable using > __kmem_cache_free() to free the object, use __mem_pool_free() > instead. > > Fixes: 0647398a8c7b ("mm: kmemleak: simple memory allocation pool for kmemleak objects") > Signed-off-by: Liu Shixin Could you please reorder this patch before the previous one? If you added a Fixes tag, we may want a cc stable as well (as for the other patches with a Fixes tag) and it makes more sense to backport it on its own without the __create_object() split. Otherwise: Reviewed-by: Catalin Marinas