From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B3C3CD80BD for ; Tue, 10 Oct 2023 12:33:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0ADB480044; Tue, 10 Oct 2023 08:33:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05D018D0002; Tue, 10 Oct 2023 08:33:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8D0A80044; Tue, 10 Oct 2023 08:33:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D69BA8D0002 for ; Tue, 10 Oct 2023 08:33:38 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A8ADF80230 for ; Tue, 10 Oct 2023 12:33:38 +0000 (UTC) X-FDA: 81329492916.06.E725B60 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id D2AFF2001D for ; Tue, 10 Oct 2023 12:33:36 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=lSWfStmJ; dmarc=none; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696941216; a=rsa-sha256; cv=none; b=7SRIeNmGCXMUVxlZSv0T0VnYmUyMjcbVVZPy/Ws7dhEZzFIerYhQXojTH4ckWLL0TH7QHx hYsFoLS07o81HQ4Vm1uYKcDDTlsExjzhVsptjMHAdJ4BgOCl2/rdDZpQs+9fOuau56k7tF 64BcbopddVoRlXMrzqS71lR//vssm/g= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=lSWfStmJ; dmarc=none; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696941216; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r7PU9+R9xblJXkgC2lGMjtnDsyoxIr/IU5up/DlfVlM=; b=AdZLAkLL7A5qI5vpUFpuwazs1bZoBJQpblT1aOhAdoxcV5YTgq1YzBIZyLilC/Gl7+q+Y4 ul6oAyhRMIprLSZaSZxGOvwFGgwtVHjvWRqR80dSFAJUSkg1V+N//9v0UR/fERSMrW2SJI kGa+6BAop0aeFJafN/1/9iHWYziPXZE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=r7PU9+R9xblJXkgC2lGMjtnDsyoxIr/IU5up/DlfVlM=; b=lSWfStmJe7ptbqfMebM6DRSv2N FhFEOV+LzDWnrXag5p7bAqLzOJ7vgZW3mrtLLcKOF8h5ZaK50Tx1HVN91MmfG7iRnHnStsIo3aOAT IU/qg3IXsEFRtKq3xDAbIS/H1+fuxd+oANdKeVyWG8nq5yMVnrZkD2GihWUKIgsW0836WSOQfnUdc jFAoEDIRio54X6/xO5nPts/QapctehXsKCNbfuV+ZqnyyZVUvDJQCAZREOBJgRYd+L7LizQVBk5u2 /2SwPCluhFgtX9VcBB0/DGGMAzweN0hCeCOwlkADeDXZc1tSTGq+BZQbmu3F9dA+vzo3o1al0GvGd uS3q4Z5Q==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qqBvW-004c96-FT; Tue, 10 Oct 2023 12:33:30 +0000 Date: Tue, 10 Oct 2023 13:33:30 +0100 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ying.huang@intel.com, david@redhat.com, Zi Yan Subject: Re: [PATCH -next 1/7] mm_types: add _last_cpupid into folio Message-ID: References: <20231010064544.4162286-1-wangkefeng.wang@huawei.com> <20231010064544.4162286-2-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231010064544.4162286-2-wangkefeng.wang@huawei.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D2AFF2001D X-Stat-Signature: 8ywk6tgzn79r5cmwsmuk8oiw48isyrhn X-HE-Tag: 1696941216-702782 X-HE-Meta: U2FsdGVkX18W+tu6oecYBV+5wXOxM1aV12QXH7zryAEXcWaZRF9H5yJjGlnWHMOipg8W3gmO1z98Rgwmr1MgFKECwqHxuQnB+htk9IWyVuWfYtSHdckWfBnExeL6/OvqsoZyf3fNoScFMbweDi1xb3/TlPuXofXmqLuRe9POU3xKzt39UiN5OlRVyH7lP7ZQ9XhkGxqDp4EjD7p35F2fR46n3zMfC1BlIKo0SZIch1opNQ2V2fDIelgtcZaFDWseWbj3ytqro2n9oBm0TV3rB6nKtblmrrSiKHCcx/+fCzefHAu0iMaz1fW30t7MpwRqnFyXRKb/3XrlIF7cBEP/VHyYz1yEKE7S1uHQ0GwGb2iRvOaz5u9mauUMymfusX7zQ8GpK8dSurox+m6h/vK8/q52XqMRgOhurENBm/4pcRNMdS5uDCxJRxmz+oGsg2W918hMk5yokeUj4UJi2+42aROz6T/TqpmwbmqqNfVghpa9X1LbsH+zOApDx86GbEGKfNiEgzVacHyVS4oG32X7rLECN7gI/lCMofdBi0bJtzv8ySGpQFo8wx07dqOiIn/WUVZphy1bIytuLe3Xv/RBHJNzdeRF9L+cR7GkXD5f2u3H+gqIG3P1HYP/uPdbOgj8yEpahbIVxOB6pAaagMmFzmM51GXI/n3Niftr7gJ5SY2e/JRZM/TgBp5ZjItIeVe8IGDS0NnSGPaLlV6bxlIIK44ihxRpkdZcjplhsOS8e5CJyRsPkWB52ciiIy8dVkHB2OmvoaIxqddRcInTObZ4f/o2f0IQFKpIdC2Obb6yD1bnOheD6BxtFhxadNe/h8+6lwE43gLsXzuKYH1ZveBwNp/Lu33blagilMnxlUl5TOuC+vK2gyq5t4lmmnAt+4UenWq/1q7UoTD2W6a+sevJxx20dmkRx1vLz7qG1lqXj5GRaDiaz84zBwTsZGdNNZc4IlqlnamaN7sB5AkJ3Zr 4yaYc67m 5dMUuBSwX43uOOeBDHrYSEzBmeSvFytrUWpJGIcR9kJAQvryr6sic/81CNkkJKeOa2JC3PLaCr6cif8qI1DDvXa963jrp2vOVX76Ec0v2zvH/wKtpZ3RZppwq/7Vf2ucinfR+QF0hsmFTYcN0yI5HqhNK0ardMNQJ5Lp0bmlY/LjFyI8DpcT2JPCy5Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 10, 2023 at 02:45:38PM +0800, Kefeng Wang wrote: > At present, only arc/sparc/m68k define WANT_PAGE_VIRTUAL, both of > them don't support numa balancing, and the page struct is aligned > to _struct_page_alignment, it is safe to move _last_cpupid before > 'virtual' in page, meanwhile, add it into folio, which make us to > use folio->_last_cpupid directly. What do you mean by "safe"? I think you mean "Does not increase the size of struct page", but if that is what you mean, why not just say so? If there's something else you mean, please explain. In any event, I'd like to see some reasoning that _last_cpupid is actually information which is logically maintained on a per-allocation basis, not a per-page basis (I think this is true, but I honestly don't know) And looking at all this, I think it makes sense to move _last_cpupid before the kmsan garbage, then add both 'virtual' and '_last_cpupid' to folio.