From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 868C5CD80BD for ; Tue, 10 Oct 2023 12:27:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0596B6B01A9; Tue, 10 Oct 2023 08:27:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 009906B01AB; Tue, 10 Oct 2023 08:27:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3C416B01B1; Tue, 10 Oct 2023 08:27:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D58066B01A9 for ; Tue, 10 Oct 2023 08:27:27 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8B6FC120110 for ; Tue, 10 Oct 2023 12:27:27 +0000 (UTC) X-FDA: 81329477334.23.7E18D1C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id 47AED16001A for ; Tue, 10 Oct 2023 12:27:25 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=q7a5l0pS; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696940846; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QqtFP4AnazNzdbPfmHwCNPWa5514KWnpnQevKgu7Ie0=; b=JbhvI00e9Of+gkicMeT3T1aHvu2k81PuMejlowMVywFRg/nr+dBuGnTaKNuXWAMjIYDn0K B6lSwG+cnvcT6opswPfWjiofC+Yq1hZcimQQfkufU6iPN2hOW7TRsdZs77ug8d3R96bH8n pUVTxboTMBkgC3WcwKS6DhnDQ28fXkE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696940846; a=rsa-sha256; cv=none; b=DQ8bmDP7gBPekmdBJNfTlKzFm5+6JDJyfGtzFwSRwL85IJ6dJAx1zq5Jle+ciFpnjixqSu Sl1f/IqQRFajY3HRPyuflogbqHKQr8fhQQZ6/Q9fClwfXxq3BcRupPxOdbrgrPxfbChklx B4hT8STS+DjjzH1Zb05DgHr2Bi1CF9c= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=q7a5l0pS; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QqtFP4AnazNzdbPfmHwCNPWa5514KWnpnQevKgu7Ie0=; b=q7a5l0pS32MVrOxgHE3VPNyiHW g3To4SpGohUEIWFWIpbCM55wYeWEpjo9KZ6AuS+A3u8k4PkmwmIcvIevsQ4A/CeFuY92kV0aXw+UA i4/H7Dd6ssaitk3xydL/4GmKFDrf4ljfSSVpvlDt6tWI5UHywEzNSBoCInE6TaFkRdLkZtJyKbIPr bdkDYgXUCTrmINQ5Rfoav5KTPKGYFmRD+Wk7IoIETWbFy5TfnVnm0SXq2HmsjJYYe3bBCCn7UJRM/ xq1dM1wodXboJ+PnQmcR41eEJKNx2uWjOU9yABHyNaMwVEj510X9NtREAxJHYSyPg+gCIwHWNE44p +kka9kYA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qqBpU-004ZaS-9Q; Tue, 10 Oct 2023 12:27:16 +0000 Date: Tue, 10 Oct 2023 13:27:16 +0100 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ying.huang@intel.com, david@redhat.com, Zi Yan Subject: Re: [PATCH -next 4/7] mm: convert xchg_page_access_time to xchg_folio_access_time() Message-ID: References: <20231010064544.4162286-1-wangkefeng.wang@huawei.com> <20231010064544.4162286-5-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231010064544.4162286-5-wangkefeng.wang@huawei.com> X-Stat-Signature: 3g9xr14e375hxk9r64b7jgt44768ds5e X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 47AED16001A X-Rspam-User: X-HE-Tag: 1696940845-253353 X-HE-Meta: U2FsdGVkX1+N87/kia6hfBY95FCPSMs4L52ctu5xUAbBWqmrd0WjDo10KJwrSyx7smbzQW5u06N4SwqEYXBZeJ8EsWeguvwtBe/7NnmQhrwJrI95QzIhUX5redYU/ozveD62vODw9ldukms0w5j6KUmTLWaQGNsVi4j9c2lqXKguuGQo7yeJivarK3sfnH/XAnbKFHXMjOueH/I36xcslBXybwL/FlqyGHOS/DQ8Vq0iw1r+hvzcAappPyiw8ffPcUmEfEX8Msz9zFPDznPQl7B49mIAthrtAP+JRxJHB6gP+TCsBl53WAf2jOo5QikxRdXWVYCg8niWheeUMwbgjqkZUfXVBe4OJ0NwBYWF9YFy4AwRUk9u4S3/O6JadDPSvnkUOqDEd4A3VdsPwWenXm3G5Q61IKMKo2JqR1kyKlyZ7/3mhaP6/mYMQtTV5AP9IzHBIjao82zxtcBWLwJYcHQ0VwIvzd3ZQ7jG94sujX6tUpT/vaYjDfEWeu/8nzeGmCXrgLFg3IiT8KT42Ruju2cRBBVkHV+IJaWsn1EAzC4oLzPF2SGIP+kAZeMe2rTZU1QcgVRpjdSTSMDJkr6JsEkQ0/DrLMLbzP6/ePi/f29gq6yIgXHgmq9o9bMp/EtGuhepogebrglB128cvsyxsH1a8n0AMfFEnJiMlWh+ckgMPPoOuVszLSIjRacaqMQzYcIlnrIx3vTGZ/BJJflEU/MVgi/VO+YND+d424AlnnDxmLg4X5ouM02JO7U7IdEMcTq9PafDJw0wZ2g+zo6XlCFH+0//CxDQ1cvtFqf32fsCtnZpSDh2OzFdp8oRyxWd8R8PBLrF/Uy9TFoFxE3aAy7hPzzOVx8xTRIi06SMZDEBMWxOBPqi/nj+lv1EVcWqD8UtM/8/C36CB3wLrQkzeyb0yNqMDZgmkTGLK/NZ5lYDS3WEGR/9juk9hr+RCeUGP1dM8X3av4tnVlcAD/a IeVGF8Ao KJWo+kbZwiSrClBivXEKMdn2hYdWd9tFi6tZ2wiAC/2puayauon79OiPkzthbtuMXhoBUTLcD4Qnhb4hzK4/seRYgv4k3hqbis4U6BpfHuWSA7ZjECQtUMuTHuR4aX18VeqXDoyb97yJDeL92mGqaHEQz+t3BzzxVtW7a7yWCa+9d4LC0bGeuO1/hGQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 10, 2023 at 02:45:41PM +0800, Kefeng Wang wrote: > Make xchg_page_access_time to take a folio, and rename it to > xchg_folio_access_time() since all callers with a folio. You're doing this the hard way, which makes life hard for the reviewrs. patch 1. Introduce folio->_last_cpupid patch 2: Add static inline int folio_xchg_access_time(struct folio *folio, int time) { return xchg_page_access_time(&folio->page, time); } patch 3-n: Convert callers Patch n+1: Remove xchg_page_access_time(), folding it into folio_xchg_access_time(). Similarly for page_cpupid_xchg_last / folio_cpupid_xchg_last(). (why is this not called folio_xchg_last_cpupid?)