From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9CB2CD6106 for ; Mon, 9 Oct 2023 16:28:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FB588D0085; Mon, 9 Oct 2023 12:28:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5AACA8D002C; Mon, 9 Oct 2023 12:28:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 473048D0085; Mon, 9 Oct 2023 12:28:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 343718D002C for ; Mon, 9 Oct 2023 12:28:59 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 00EA9120342 for ; Mon, 9 Oct 2023 16:28:58 +0000 (UTC) X-FDA: 81326457198.22.498565E Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf27.hostedemail.com (Postfix) with ESMTP id 37EBD40008 for ; Mon, 9 Oct 2023 16:28:57 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ki451z29; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of 3SCokZQMKCF0N8ABJJBG9.7JHGDIPS-HHFQ57F.JMB@flex--sdf.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3SCokZQMKCF0N8ABJJBG9.7JHGDIPS-HHFQ57F.JMB@flex--sdf.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696868937; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=19HHGQ3oNEnnEVZ/ClG1wJq3/mmndqDn49m0nA/lXo4=; b=TF3q+FsqH9o1M1q+YB1y9ZR8o7T4fMXIbBKIhGzQNo53EcUfqcDaghLAXCCf3ub8z9F2H6 /kffE0XjAWGTfYkBHokt1UfV9cNl1+0T+rDeymjVl55j5Bi93EDPNug4F2RCh36+23HvtB dwzzcDuS4LWRaFHMq98f9IzhpT4DcoE= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ki451z29; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of 3SCokZQMKCF0N8ABJJBG9.7JHGDIPS-HHFQ57F.JMB@flex--sdf.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3SCokZQMKCF0N8ABJJBG9.7JHGDIPS-HHFQ57F.JMB@flex--sdf.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696868937; a=rsa-sha256; cv=none; b=PSPm2Ts0z7HldrrOyLuw+Bc0lCEJxysiFsM1yYRH/rqD3qEqXD+myOY4+YjGZkKBnL+ywd mQBv3v1rgpC/O3OrOg518mnq83x7FiihDPGNvYkx/4fMrqAmtV6CVJNOD6vy6AMtahzIEb Yrp/+aeqUHwah+MYT9iIcjlc5fZPyyg= Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-d918aef0d0dso6552391276.3 for ; Mon, 09 Oct 2023 09:28:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696868936; x=1697473736; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=19HHGQ3oNEnnEVZ/ClG1wJq3/mmndqDn49m0nA/lXo4=; b=ki451z29G2Gr6W5XEA0pNk0TMnrk7fiblDQsgGwkEmdktwNfyaJh+YxvnhrM+NAoLl EWfs3U9j8lAZLa3UVUI04u4PoElHRM8XylfOtiP+60sKKLbplhZKPqPpfImD5lXFWi5q ytsRsTTSpiPSVsSvVYPd9Lg2L/r0G9y/majGStQrs5b+ffxPhbHKcmDsKDvFyacBXkQ0 aIIDYATPz/qY9FXv0piG6VeFy43pTdX/OPZ+yziu9FkW1grGvfNeFGdqgrpTsx46YYOd K7XNQ5GS7SHk6sekOWRKWvAV0jZDFLK/969+PFXk6T4yn5tkbA6lm9Wh9DZTSMmLpHdW bMvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696868936; x=1697473736; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=19HHGQ3oNEnnEVZ/ClG1wJq3/mmndqDn49m0nA/lXo4=; b=Laq3iEdvGxXRrTQBXdkWNrvVSS1hAGM2zliYzPIYKXpX+msjSyFoPZv8rC37KSojc8 m7YhwspgIkGHW0Q1fD8Q7DAbW2ZfgVOFfFkodEJRpzC3bw/GcFB/ufYbQWVquCHcyJzw vGEUrxTlh5teV3S0z3xGeQxWJskSK2nb0dA03oNGxSGUQgn9jwdrjB9eYQOttF4lx+Kw FUhiji0TNLeqph50bQ3thBeHxT8THtBOj1XibwdILcSvP5cHBhdH5SQPdIPwmnS0WzWd IKi464IWKNYnodkPZ44sMPr8Jo6oEfONpkQWhxDaPbKrF1YTIaOjACs1TQFaVYL7vKQC pJKA== X-Gm-Message-State: AOJu0Yz/BOxSmmQBB48GcJ7aXuZlDAlzvd/yUHnIMmJQtCb3XoZLPu9A J4ngMu1P+FiWP1Cx3rKQ9HIlMmw= X-Google-Smtp-Source: AGHT+IH+W9Z8tYIhdCRB7tkdQG5zQXa1wHNLY5WwOHgAwb2hBJXRjyZxkKCgLWY92fImc69hDjbHv2o= X-Received: from sdf.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5935]) (user=sdf job=sendgmr) by 2002:a05:6902:990:b0:d89:4382:6d14 with SMTP id bv16-20020a056902099000b00d8943826d14mr256390ybb.6.1696868936283; Mon, 09 Oct 2023 09:28:56 -0700 (PDT) Date: Mon, 9 Oct 2023 09:28:54 -0700 In-Reply-To: <20231007135106.3031284-5-houtao@huaweicloud.com> Mime-Version: 1.0 References: <20231007135106.3031284-1-houtao@huaweicloud.com> <20231007135106.3031284-5-houtao@huaweicloud.com> Message-ID: Subject: Re: [PATCH bpf-next 4/6] bpf: Move the declaration of __bpf_obj_drop_impl() to internal.h From: Stanislav Fomichev To: Hou Tao Cc: bpf@vger.kernel.org, linux-mm@kvack.org, Martin KaFai Lau , Alexei Starovoitov , Andrii Nakryiko , Song Liu , Hao Luo , Yonghong Song , Daniel Borkmann , KP Singh , Jiri Olsa , John Fastabend , houtao1@huawei.com, Dennis Zhou , Tejun Heo , Christoph Lameter , Andrew Morton Content-Type: text/plain; charset="utf-8" X-Rspamd-Queue-Id: 37EBD40008 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: umoybd4tcfafk6f6eaxxdiiobz6bbsae X-HE-Tag: 1696868937-415628 X-HE-Meta: U2FsdGVkX18D4f+cc5MUYriv5+kIbg25ZjV5EFsL0o6GHJj48UQNtjpKTpLndD8HSFmMSMu6HgUdFSgPdj9BEgDnPZUKSUCtvC2mm1B3F/C6P+UB5DImoNfTmW6coAwpG+d69mhjSalT5ugQXAtR/mME7Xte8s6qy55s0eT6n1y2ev+DHyNi6/W6PPGE+0Ju1Cgn3+gzJMZAMmyEvPvPrhAR9uTCNp8F4lINTEOjLKO86/RtBzTzWv+iIyRzXEdRgf1fSv8TwYEhGs1bbHSVPjYrOeRhaQNsVdDBrws2Wxfy0fmGmF6vqvkb1zDKWsS1wEVCt2LfXPX+BOucPVbVmPlNG0hZti2Z8naSUkvy8+9Q9MrWadxqBTaZyD67dW9iLJDQ612w0wMX4gtDNBASHPgIxEp4H23MYdpdYa7yAjMUL5WULJWxG3H6/FQeWmfXk0F2NfXfaIYmZdCcFEswaSugqBtTIckzlukjH/fkU6C4+3Z741MJXFkjaJBnKe0/Hv33CKnQ1svviWlf5/MdilE359GuENs3i7LwBAZ0pf+MLXfhjHr/6z5Vcu8rYd2mH7SscW0GCVeHTZ2GzZsohJB9K5ye3C8Ij1kGjK+x1axenKW7e3egOcMkOBCnDX4TWcJNNV1tS0r8x5LhJIYXFFlkT/SIOYN4yhuQirLYuTYwCPpcVOJi6RwpakTEiqkMcvAGLnUFpZdgZGTVKIUfrBVW0obFi9Ei8nLE3EzDC2extjqWh2uAfwBMAbs/E3Yssf8XHsY6twzxxAaVGhSGIUwKQVtTJiQd3Yu135fs8lCTS7wL80eVxiTiPN0pDacTrOeq3Xr76bdeeThtvaQUhFphwcUIFO7Q8xnCpYfN+UUSYRe/eiJBVFd/kAnmpSUDR3Wiy9j5A4ZXjvQmBxbgJ3ZRQEUzSTEQyox04nWDEcOAyqYq/S9LvqCpTHmftpAhINGaoouc0G9hD6F19i9 aFk3Iwfe QpKhSgojo9lmy4bEwCVkYcUUX68tt3K/Tx5XzTlqzRH4D8rZwWX/fpq3aLcb2x3BdpatBIrItHYuE4SpknoGetxgyPk/XqOAHZ/1E2lMCF5yGFwiEQo5dnQ2NPBUOe8mOvZRBuWq6p+OdOov2lKCzrhVaH6XHwKx8rnsrTixxtgiH3eT56xEp3AEIvvro3/k6yl9NJ6HUGgYLTRnq+rqzGUsTHsvrrzTqnFupIW0Pkzld3KYBtvK2h6ENdwEhexU3+4rAmYJ3ngrVoNKOsTS3tdBO/CzqrjBGAJ3UEG+RCWbz1kiaQPjRP7eTW20j8u6/EObSmYrKn9Z10rj0CabiPEZ6lAiYs5rS3ZwvkAFoEpxMMqxzdrQ9pX128EHwteitJD005dNayJnDpHHSFnXZjoRsgyiWX5TIJIC856Bnt821em4aoiAClbRfKQIDc9WsZ6J7Lzq3GZ+oJm6yXlB5dXWNWEM2dKfzaoTYSWMEXrdcSXDdOKDAkQmCr3oc/5B6xgxcaCFlkb4y0r98QYaKZjOty/qMl9Yw2f2RLuZ46EJtOIA1+l6Tx0QtzZRd5RZzmG2ZAhsgzm4zex7v2UwNUZnjxjrf3ofjnJn+TaCzSuoLMjKFRs1+f5hpC3oRCxVeWDDSL8GMifq8reE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000038, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/07, Hou Tao wrote: > From: Hou Tao > > both syscall.c and helpers.c have the declaration of > __bpf_obj_drop_impl(), so just move it to a common header file. > > Signed-off-by: Hou Tao > --- > kernel/bpf/helpers.c | 3 +-- > kernel/bpf/internal.h | 11 +++++++++++ > kernel/bpf/syscall.c | 4 ++-- > 3 files changed, 14 insertions(+), 4 deletions(-) > create mode 100644 kernel/bpf/internal.h > > diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c > index dd1c69ee3375..07f49f8831c0 100644 > --- a/kernel/bpf/helpers.c > +++ b/kernel/bpf/helpers.c > @@ -24,6 +24,7 @@ > #include > #include > > +#include "internal.h" > #include "../../lib/kstrtox.h" > > /* If kernel subsystem is allowing eBPF programs to call this function, > @@ -1808,8 +1809,6 @@ bpf_base_func_proto(enum bpf_func_id func_id) > } > } > > -void __bpf_obj_drop_impl(void *p, const struct btf_record *rec); > - > void bpf_list_head_free(const struct btf_field *field, void *list_head, > struct bpf_spin_lock *spin_lock) > { > diff --git a/kernel/bpf/internal.h b/kernel/bpf/internal.h > new file mode 100644 > index 000000000000..e233ea83eb0a > --- /dev/null > +++ b/kernel/bpf/internal.h > @@ -0,0 +1,11 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* Copyright (C) 2023. Huawei Technologies Co., Ltd > + */ Don't think copyright works this way? You can't move the code and claim authorship. In general, git tracks authors and contributors, so not sure why we still keep putting these explicit notices..