From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DAEDE95A8E for ; Sun, 8 Oct 2023 21:54:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E7E136B0191; Sun, 8 Oct 2023 17:54:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E2DFE6B0192; Sun, 8 Oct 2023 17:54:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF68F6B0193; Sun, 8 Oct 2023 17:54:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BC94D6B0191 for ; Sun, 8 Oct 2023 17:54:35 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 84CFB80209 for ; Sun, 8 Oct 2023 21:54:35 +0000 (UTC) X-FDA: 81323648910.04.BAE9BC0 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) by imf05.hostedemail.com (Postfix) with ESMTP id A2CDA100013 for ; Sun, 8 Oct 2023 21:54:33 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=P26BmMkr; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf05.hostedemail.com: domain of david@fromorbit.com designates 209.85.222.178 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696802073; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2lF92kcVMrLRaxlLOpuuihR9KaLnr39sEQyi5og8S4Q=; b=0JQvpNL9P159tL9ufoY5VnvNzRiJIwW5xQ5/IWW6+5L+zyz5JwqzlMyQFRupgnTZJaeT9/ vBU5W0CJnheK1TCV4Ix7UKR/7Fxq06oa+URzzY4jmVgXEVvVzPwIvdpigSruU5ImH7WgrN 0ecVMryKRKY9qVNWac/oYlzzMtE/PNc= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=P26BmMkr; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf05.hostedemail.com: domain of david@fromorbit.com designates 209.85.222.178 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696802073; a=rsa-sha256; cv=none; b=ofLiCyBzyraN5nh5GxWtuXdrhP9xYurUtOPKkKhxDWDzB5DGJHjBYlEql6rjaE5XBRlze9 i06IDY28tJ09zXzDbknRa21nHx/AXfAvl8H93L+w5ySgH6mdFJhx/Pz/NB4cShg1Y1NRS+ X7e73YRy2Vsw92JSJ4AkKMWNXrM2ntY= Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-7740cedd4baso287842585a.2 for ; Sun, 08 Oct 2023 14:54:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1696802073; x=1697406873; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2lF92kcVMrLRaxlLOpuuihR9KaLnr39sEQyi5og8S4Q=; b=P26BmMkrzPE6blJ27ImQddg2ZrAIxnlabpyKlBtBT/Midu0UDt0qCHLz3t7pqZZH2X JtqWRAQ+tAZ6h+0goRKRNoV/35ktoLnFeMLBG3vVmsMCrkBgPTxH/I+fJBARiMWdSJMA cJPAbAjZOx0szO8Y9kVcddOvyJhPTzQ8cO/+Cq5vBkImPV4UaPMy2bmUkBERujNzOsym Pu9Jy1Atajnv/v154dsFlQo5Utj/46ICwfrbKa6XSm4QA1GO3/LtYPFXtcZsT6/UnjMQ l2Kzx7hWF9rn27G1cbU9N5Wk0g+pXWntMj+uZXILn41RUhgxMKYotaqt0ZVf+w1V30p0 3/VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696802073; x=1697406873; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2lF92kcVMrLRaxlLOpuuihR9KaLnr39sEQyi5og8S4Q=; b=XIHkyvg/i0a0PXI1XQfrkaGHOE19dbAhrDCCEdeuF3ZaDPa2TvPls7MuzlPNPw95gG QYCgEth8WR9PWE1cjmLXUvHKex/Lx/VqhSzqsj+WUT9YRgg84lbv0CmJnnlQT8hgBo+6 ZufGPY3ZPkk1H+oIjh8dvFYfoNxbr4r+g2aXrwqokUtyEgIuf8zl06vCRTzohjcSVrcG Ei0R4wmNjWXjyJr2Vn+ani//xuzOsHndBaDkaYycWAr2dvIFtSbsOdzOaJhgwYejcuOu xJyAa9YpXeM6Xc4YNRvOdJUIOczluh4ibiIlC17NLPePevJxyRnPeSeaw2PN0WbfO3FA Cseg== X-Gm-Message-State: AOJu0YxgDtO2nXHLwgN/6eSxXEBE0w91NjSdnJaTFfGGFHtUKb1NSysq fKAW5CXApL98JC0BexqzekGg2w== X-Google-Smtp-Source: AGHT+IE9uk2jQHbCBVxRhP7NjawRCWYl0XIv9gecaHQ8PgPtfZNgekIL319uoZlVT8luWtvfdncaig== X-Received: by 2002:a05:620a:410a:b0:76c:bdbd:c51d with SMTP id j10-20020a05620a410a00b0076cbdbdc51dmr18146770qko.66.1696802072815; Sun, 08 Oct 2023 14:54:32 -0700 (PDT) Received: from dread.disaster.area (pa49-180-20-59.pa.nsw.optusnet.com.au. [49.180.20.59]) by smtp.gmail.com with ESMTPSA id e18-20020aa78c52000000b00686b649cdd0sm4991103pfd.86.2023.10.08.14.54.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Oct 2023 14:54:31 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1qpbjI-00BFzX-19; Mon, 09 Oct 2023 08:54:28 +1100 Date: Mon, 9 Oct 2023 08:54:28 +1100 From: Dave Chinner To: "Matthew Wilcox (Oracle)" Cc: Peter Zijlstra , Ingo Molnar , Will Deacon , Waiman Long , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Chandan Babu R , "Darrick J . Wong" , linux-xfs@vger.kernel.org, Mateusz Guzik Subject: Re: [PATCH v2 1/5] locking: Add rwsem_assert_held() and rwsem_assert_held_write() Message-ID: References: <20231007203543.1377452-1-willy@infradead.org> <20231007203543.1377452-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231007203543.1377452-2-willy@infradead.org> X-Rspamd-Queue-Id: A2CDA100013 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: abp4pzg5rwtm5uc1txfazzjgb5k5b74m X-HE-Tag: 1696802073-632519 X-HE-Meta: U2FsdGVkX19MBtH6SKZgiO7bIV/45dBJxzrpoRQXzFskqopzap2IjQS4DMkUbodnL9ErOk+mSE619wV5L64Ol+Dbom6ysg7Mv9EDnTnsrFbTsYdiUAzvqYKwlbrEy9tn2KvbOAnPTjL5kmhfT+rdb+fIR+K3Zhhar9+05kcfH4CJDQZI9xZ48J8RWT1CAHbXJEKPx2hcIDD6bqFVK3UB/SfwCUVgj2HflyWl2hmNvS09+nf4Hp/44ux2AQ+lVocwk2dgIv9cpMIMAWtybQqN5I+Bpsc/RMMknZXSHaoITdZnKvWz+QmbW0l6OTrGwUCJ9yVoQBBvVF4sG0DIUCDEX9tgwuex5FuRozjuwyySOEgn/OOTza9+zJ5S+fQ27AOxGiyNxxbgPO4fHTDCk2gFSw5RukSkSTavZDnpD/gK7ytYpTuRMWFhzP6q2xSIJcsSRvY0iR7AkETyfz/+P3BSqIiUdw7RZAmuA3jdE3RTxxIm0nk5VSW5b29J7RgXHNjN8jFDujHpbYpneifxTzi0ipe+7bTEIEY0XxuLb3FxpfMHGe2knBDpUQ3EHzzLWGCelrsH4cbZ4de36rQGdc0+yJtrjhd0M6xkAY5UjArP+Pe/U4fQKwgotUKuX7f+gcKQ6bUud6p6a8prnzRaW2MMfQuEQyu4E6ajbmMphagaS1nl4oLbVdUbVncPYCYS4llGvAvFh1rpO66Fwc5MqSO1nf5Qans6wWldbKZq1Ahd33cqskXnZUkKhsJZQxF/V2m8qhYiojt3PalTusqmX4bMvzrXMkwBvvYuG0FkygYd9WVKB8ndSJw4LpK8c/fgDijPTS6OEBkTUCCrJ2cz3eNTKuM+dGx0xWqQJtu7i5FlzX3iYyFRbmIz0kCnFdAL9HUs+bzZM0a4Q4mUDQ5Re/TpJJXHt1IPK4nHQJuIFBYW1Zpm2sdv8oTE7j0nRjV/R+Lf5IkMHOkA1UAecVo39ne hAVFP0Sb dGSDrziB9ZWyClXqeRB4JSUIBjytcNrdnl0zTFQpwFohb7LjxKy3VL484qR1P4VllzOH2ZSSunqFgugxmxbgZ8j7GFKGFUXwRHP6QypONxRf7p4bsT8bgj2GanVlTyjMOlgBrc5Bh/k8fDiBw/5gkdkj/sok7RZNuueRnk1jFxgtx00tMvsKSdmwZl9wyhhM3PEnhVjAp+URRsjr/2GF/iYjcVkJ/kj5LQyXJTcVhRnlsHfsA3VhTNTx/uhDLfZQosG+nzHgfu8hyZY7aG2/r5KZoL8P1cwu6Ns8tB9HdV/sksnb7D9LIvF8TpVXMP4kkApKM7530lsQNqkOJ9G+yB/9ekj4bzno/BoKN/PkPFPrNNl357uwF6sgXJNV/8k7mfRZo9aWGk6m+MhZMpvA6I4JnCbxDmj2Ln3F0xxp6r9usaVVlorG7SRunXz1pbrJOdtHkOZlGK9XAgpRMRipKwAnT3YlMyOAx0d3T23/s1pNB5bbh5VSqkY0SXCyBOvI7Gj7F3GEykQh4LJvJcuec0wmY2mR6oQnALgjrgfEaDNLGrrk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Oct 07, 2023 at 09:35:39PM +0100, Matthew Wilcox (Oracle) wrote: > Modelled after lockdep_assert_held() and lockdep_assert_held_write(), > but are always active, even when lockdep is disabled. Of course, they > don't test that _this_ thread is the owner, but it's sufficient to catch > many bugs and doesn't incur the same performance penalty as lockdep. > > Signed-off-by: Matthew Wilcox (Oracle) > --- ..... > @@ -169,6 +189,18 @@ static __always_inline int rwsem_is_contended(struct rw_semaphore *sem) > * the RT specific variant. > */ > > +static inline void rwsem_assert_held(const struct rw_semaphore *sem) > +{ > + lockdep_assert_held(sem); > + __rwsem_assert_held(sem); > +} if (IS_ENABLED(CONFIG_LOCKDEP)) lockdep_assert_held(sem); else __rwsem_assert_held(sem); -Dave. -- Dave Chinner david@fromorbit.com