From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FB3EE95A67 for ; Sun, 8 Oct 2023 11:08:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 394156B024A; Sun, 8 Oct 2023 07:08:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 36B756B024D; Sun, 8 Oct 2023 07:08:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25A3C6B024F; Sun, 8 Oct 2023 07:08:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 124066B024A for ; Sun, 8 Oct 2023 07:08:32 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C75C4401C0 for ; Sun, 8 Oct 2023 11:08:31 +0000 (UTC) X-FDA: 81322020822.29.112C9E2 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf23.hostedemail.com (Postfix) with ESMTP id BA15914001D for ; Sun, 8 Oct 2023 11:08:29 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Hh6kLE76; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696763309; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oTvayMyjZo46AUHzE0UGk+kG6LLog/ryuQyAlblwuSY=; b=BwRTWAgB7OREGMuCQ39VMsewWCFS6JIBYAT4R7h/T0Ly8FtOLIgND/naVpo70wJFfk12CU 01kt+gJMYSqDWC3li1Vzl4q/Ks2ls4SPjAjzqVQ77lVEjoT+REYswHrDvMbv3RoP0QJto0 n8IUnMMr4cOnMZBB7O2ENj4fLcsRn0k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696763309; a=rsa-sha256; cv=none; b=PRtbFoBl/3dP8jVQI5hqTcsmrsKNuyCgJ+x1ShzotxkGBbi9u9mMx8gjIKBwSuE0SYz+Ns I2ATHFfTxCkwUPLZfvvv9UXfq0PilBZSKFZ5V62X9fT90v1xaBtmBwYxXdXATngQK/95oj 8T/wYktNtOYA//58x+og2peFrgamyR0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Hh6kLE76; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oTvayMyjZo46AUHzE0UGk+kG6LLog/ryuQyAlblwuSY=; b=Hh6kLE76ItQrwxVzXND+nZwmEB GmbATU0ZUEzitwFxti1OYJ/vSZ3UJnRkSgR1AfuHSC8OfwCtcSr1j4Zkpp45C5zt2eQRmt0HO5IKw t0BmlxIQjGkhHtFrQmOwg/2b1gBnG4nls4unkqK+5PXhOM1AKlvHVl+eveAUH8ahxEOD7Sh0QQGrx 7Jjt/QI57Y9pllTZyYcCLB6JFCBw9coioNun7uguq/hrLP/gh0wPlYYiQAT55I6lt0vrFK0eSltfb 9Gb5ZIM6F/DN2DH0X+aVUcsLrVDLZ6K3GEnvCF5WSknJNngQdYCbr+NAOVYjFZncSpu2UgCeL79RF 19GMkYGA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qpRdV-009RlG-4b; Sun, 08 Oct 2023 11:07:49 +0000 Date: Sun, 8 Oct 2023 12:07:49 +0100 From: Matthew Wilcox To: Lincheng Yang Cc: akpm@linux-foundation.org, rostedt@goodmis.org, mhiramat@kernel.org, hughd@google.com, peterx@redhat.com, mike.kravetz@oracle.com, jgg@ziepe.ca, surenb@google.com, steven.price@arm.com, pasha.tatashin@soleen.com, kirill.shutemov@linux.intel.com, yuanchu@google.com, david@redhat.com, mathieu.desnoyers@efficios.com, dhowells@redhat.com, shakeelb@google.com, pcc@google.com, tytso@mit.edu, 42.hyeyoo@gmail.com, vbabka@suse.cz, catalin.marinas@arm.com, lrh2000@pku.edu.cn, ying.huang@intel.com, mhocko@suse.com, vishal.moola@gmail.com, yosryahmed@google.com, findns94@gmail.com, neilb@suse.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org, wanbin.wang@transsion.com, chunlei.zhuang@transsion.com, jinsheng.zhao@transsion.com, jiajun.ling@transsion.com, dongyun.liu@transsion.com, Lincheng Yang Subject: Re: [RFC PATCH 4/5] mm: add page implyreclaim flag Message-ID: References: <20231008095924.1165106-1-lincheng.yang@transsion.com> <20231008095924.1165106-5-lincheng.yang@transsion.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231008095924.1165106-5-lincheng.yang@transsion.com> X-Stat-Signature: crs7gbn7b45b3kzj9g6f4hnicnaaw7zq X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: BA15914001D X-Rspam-User: X-HE-Tag: 1696763309-193315 X-HE-Meta: U2FsdGVkX19w3Wo5IJu3Pvvkc6K4MudlxOLfjdXey35PzkKCA7xyoxdxTrdr2ZyuR/+ZVapw34S2cfqycItEperWSykpaGS5KBGau1kTHG0uET7rWXDaf6RaM5j5e/7oldHSAc28ilbp8fqbFkHq41gq1m8VMIAhySiiSsgUmFRAIJpy2Jv9HjpIL35WCfTFLM+fEoo9ps/vZhkxACtBS2ZF0kO3noTTkx90abpvxw69fA2EII2/lCKmPSL9GAEJlpKwWLUZ9C5XNos5h61S8+RjUWbsSpQvh+NfDFb71pQxj26OIEtk9HSuHQwICjAvLVs07nEB0mQhchpDMGt6Gsoy54MELmHMAYTc+uescHK+FXBzOBVVVm85h7krmSoqWKXc+yP37x7c2Q4iNFhxb/4pUiXUiKQf76PwiY+jFeiadFjvrCXjzIAsUJsMi+Q8vW6sTfKH7SgJH/hqZFPgGpAP0QVhX/qGCXh1HrHyqtRPJJ9bYuXPsN3UgBBBOX7+hmCav2ca0LkmSBckXjCTNhJUd11ZH29+MJWz0C1XWST8CgetdenXlPcQ5pXMJZHatJabq0TOQ6Utu/HVEozsGhI/y5rHvGGDQmpICajWx6SDCHkaTa8460CxBWDpC1ym7XCnUjiClfVMeb/7speuSuh+UZ+SxjDrrl1embZX5FQdTEW+b3kO+fmAOPQfbrIlrVQTiId2LBGz1noRHHF+CuhML4vF4Hyx6q2wDWt5rB1ib/Ceia+IuG3iEM4xrVTkaHJl0QXrjPFsvLJUfJQzzBtucpeybh/xOE+p4fzf0oSRmAb8Urhs4zAJ3WpbSjMJ/9roCyKGu0sF9ZQWcFBTTolUMoHQp6rC6BXZseGZfaY1SEKJXkNfeECsWhRA+R2L8k67HpvW/AwF9yb9r5r/FkEjR+OFrGEazsh95mtLAp8xbKRBHftKUgLHXbTsMR41H09HbqQzAnN4ZW1O+E/ GJv14YSj U4kbUy0h9toPMEdFz2MPHXpWzUxZ+zfZYD5bIJ8rrazyw9sK5U9ooWY8UMVzDif87cxjNDvBR6qcVfqkoaGMpu7LONTf8zelPRrj1DKpPPfSykk6JrxLXG9sywJewvcvbYjnvFG0bG5wCDmWOP/44CWVJvc50Eas4fjRVZJofWmEBW98k8c1205+2fFdAQKkBr7yocr5zkN4NzENPPdtpTgjN5A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Oct 08, 2023 at 05:59:23PM +0800, Lincheng Yang wrote: > Add implyrecalim flag means that the page is reclaim from the user advise. > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index a2c83c0100aa..4a1278851d4b 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -138,6 +138,7 @@ enum pageflags { > #endif > PG_hot, > PG_cold, > + PG_implyreclaim, > __NR_PAGEFLAGS, Can you do all of this without adding three page flags? We're really tight on page flags. At a minimum, this is going to have to go behind an ifdef that depends on 64BIT, but it'd be better if we can derive hot/cold/implyreclaim from existing page flags. Look at the antics we go through for PG_young and PG_idle; if we had two page flags free, we'd spend them on removing the special cases there.