From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23484E81E02 for ; Fri, 6 Oct 2023 14:41:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 97F028D00C6; Fri, 6 Oct 2023 10:41:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9085D8D0050; Fri, 6 Oct 2023 10:41:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A9568D00C6; Fri, 6 Oct 2023 10:41:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6BCB48D0050 for ; Fri, 6 Oct 2023 10:41:41 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 405D01A0185 for ; Fri, 6 Oct 2023 14:41:41 +0000 (UTC) X-FDA: 81315300402.20.18B4A5A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf02.hostedemail.com (Postfix) with ESMTP id 1F41080026 for ; Fri, 6 Oct 2023 14:41:38 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=vyVGILvY; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696603299; a=rsa-sha256; cv=none; b=VEBLRnjvbcsXT444EA7dpiJ84zz7J/CwMTJtH9Hu/gtIurGfzlEJ0fPkXW5sBV5no0FQE0 rwKLl/AiWjGanVqcpXcI0jrTFCxYyG2Y8P60hs6saC2LtSoSEvRWtxuXfncT7/GPz0H5NE oFTbiWI9l1O/m+Ll7+D098b9gH7vIkU= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=vyVGILvY; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696603299; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Kz0MyaGCfhSoACpQk6IQSVxzrVBlg/0Wg5XzExLzRJA=; b=OzCVqygwu+/gShsRBumICIwJ2pl2hBN7+ilas2SS09bSFraOht/kwgCUgwzHeJzAsbE98U yrcoEI+QodIEahQe5cjv7Kc/38xmyLygyqj8SE/zF7RM5YQphKHBIav3Uz/o2IeN2Vz1Mi xt5U5dKQVBs52TFbIz5Q4wZAgOv2Zk0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Kz0MyaGCfhSoACpQk6IQSVxzrVBlg/0Wg5XzExLzRJA=; b=vyVGILvYDUxK77TznDGevX+p6+ QeB3UyVYGG8z6uY8GfJUrVbceGW071wpmajsdgoky80NKhEJyy9wbt2HGIVvYK+V34X/xcZ7M88tO uv0A8F97qeYjl3j1wXTJ37tgEpP6bzpv0QeCjQfyLHCVQSrkDrYuixC9k1VwkKgD7O/aDn8K4oHEu aLBRPykgQkjRXYvNQg7Rvb3sYtTZ9ATM5boFOzN5hvaDmbVb9FPzFNpEbzgW0gFqTRukUUuq3MIFW 1g2dA6Ns4ySooj/qULREI+uxM4kG5aT9g3OTf2WvqX1Z3WFRAc8Vexl7STBLjJ85GDuxLMFsKshej LScv7kIQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qom1A-00FrAt-MO; Fri, 06 Oct 2023 14:41:28 +0000 Date: Fri, 6 Oct 2023 15:41:28 +0100 From: Matthew Wilcox To: Pankaj Raghav Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, linux-kernel@vger.kernel.org, Pankaj Raghav Subject: Re: [PATCH] filemap: call filemap_get_folios_tag() from filemap_get_folios() Message-ID: References: <20231006110120.136809-1-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231006110120.136809-1-kernel@pankajraghav.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 1F41080026 X-Stat-Signature: jr8hdfyjy8jwxrj3h5kfnnzbhoo3cmx4 X-Rspam-User: X-HE-Tag: 1696603298-788117 X-HE-Meta: U2FsdGVkX1+C87gFcWXihv8tt5NJV8RtIeTI9bOhsR3G9PGZMhTxebwUaDMxXko3OCbntihcP4PYIwvt+IlbHhsN4KScIDsn8LkqrIYhciyjbBkEjjEbSYgYgvzAtSFJPwtsNh6+GWjBpjtfqmYAf7Htaz5GRenB3fDepQkO+Mmuu8CrbwgLSvtOM09ucKJqE/cEtot8cVf12C4DCwBKHgiBY7WsL3ggG5UmlzK5FOsGwCShO8us895kIWbhxJk2ql7uVZ6s2aYrUTkyBiOV77JQzjLrbyZqpWtldkUsecX4/FInNnAM5+7t4HZvz14QcWmNDfay2+29J4oJxBGRz5DaVezQOIq12T1wfoKbCVo1ZRVj3b6z3g3i+oZpyuVwxa6MlAOyfCYCY9XK/uR+gsnaEoZNQpbm3pbdG66pZJ6WlT2+jett3qNrO2luvNxjhav7wkes6YpZG8c2j61IlCespiH+ntZYW6P8WmcRRXEjVZFdPkMhsFtdrIn6SZezM/6AoexTZ3OiFcJ/QhlSxbjl4/d6zNyTKmdmHcb9lw3EKd3pn08Kkfcmkr7IHT4XDNfEA/SD/XcftciWpLAVFcxj7xse4wvtJJ0LW287oJBl3VTySGaNJI8cVoQbQY+IRhG+HpHs5wq8GJDnISJV3OneSHHTEE4OmcVKF/MqH+P18mvOU7xNwbzcKiOlDv99t57U8cqVfCT4l+OJt3g7D3EiaWqyzyoV63Nrl2uM6CLU71nbncgonKYyeWVo700cTs3NoUIuzTPYK59e/d0CHSCLpyuiAVNBdBAaI5CRifBBgHKblzBibcqWX0CaoUJFQ71JBDpJViFug2bxCglYebVXXeA1q4wuNPNRJCKMLbY3AruPIxeKgkEykuC3miPwC0kTNyr5vhCf++QD8v6cVbhoukr2HT3KbkaP5wwJ7l7HKbVy26L4vQYkG27wD0UknKdvPPb2b31NKhKcnbw u9kpvEWq uK7SA2Hxth/ZWRZb0R14bwZgm9rj1lom2+PMEL0dB/zETNMAZOGGMEhlTK/rbdc2EOejfK/4cdvOV19R6xj6QD+7PhKfIE8JMYROLLr8Q2VLHtE7q5DCDtFcV0MQVUzxEq+RBVTGIpZy/c/IEKU76jXv3rpiT5hMtOVaGHxYD+LuKErrakyBgANGI9wBd/x/2soiQfN3GTvS5FH+BgAg6r64BQr1tu0vzafAkh4hjOzo9bidXnsjgV1EMq3FqHIZYC0Zdig+J6eyeFFk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 06, 2023 at 01:01:20PM +0200, Pankaj Raghav wrote: > From: Pankaj Raghav > > filemap_get_folios() is filemap_get_folios_tag() with XA_PRESENT as the > tag that is being matched. Return filemap_get_folios_tag() with > XA_PRESENT as the tag instead of duplicating the code in > filemap_get_folios(). Yes, I think this makes sense. I was consciously trying to make them as similar to each other as possible. I hadn't realised I'd succeeded to such an extent. Reviewed-by: Matthew Wilcox (Oracle)