From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97DA7CDB482 for ; Tue, 17 Oct 2023 23:23:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 347C18D0120; Tue, 17 Oct 2023 19:23:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F7DF8D011E; Tue, 17 Oct 2023 19:23:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20E018D0120; Tue, 17 Oct 2023 19:23:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 12A948D011E for ; Tue, 17 Oct 2023 19:23:58 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D6C94A0D59 for ; Tue, 17 Oct 2023 23:23:57 +0000 (UTC) X-FDA: 81356533314.04.EE8E85B Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf16.hostedemail.com (Postfix) with ESMTP id 9228A180010 for ; Tue, 17 Oct 2023 23:23:55 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=STwpUSkG; spf=pass (imf16.hostedemail.com: domain of alx@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=alx@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697585036; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IgU+yViSCClg3JuiR+icfU73AXmkBZEIzMLrW1TDKwc=; b=bGbAWUjohGwWm2vQwwrL54BmjW75P/JFNJFUfguyjCTIKKWPNO82rDLlPhNUiwNw3FY+6/ taudssfTNZIAQS67Rmq7gp1CkgZeceRbQdPckJSK4p2XnT5Nfi0oD0bH4N7jBpzp8kWPNz oPmTe57oikW+8NPowgiVykXTgdBNSMg= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=STwpUSkG; spf=pass (imf16.hostedemail.com: domain of alx@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=alx@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697585036; a=rsa-sha256; cv=none; b=KxEKeSzEDWbe8VeNMJIbZDuhba3zGTx6bo0BeeCfuRSNCzFRnzgHvWmK5QIeN95kIakFVZ DvKnuxiVEpGppr6//zmJsziq702aZ6eL6ava/XoVBTtinE0b5ll5CfiIyK5/cns1ULSJ/m 0Yvs3RUMQC47s/hVNHJvZSFcEC+5QxY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id E9268CE225F; Tue, 17 Oct 2023 23:23:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2EE3BC433C8; Tue, 17 Oct 2023 23:23:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697585030; bh=qN2ECKk/Cxny8jJMFG/9Fq46QS+Q6UKOKWNC96Q0tdY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=STwpUSkGknWcmTQ0Ye9D79+LBBNd2KWCDK8vBqmq+OOe0v3ZFC/+SyBt6WE5BoC3G kn1a1/JvL6PQdMzqIX8HMZcFCX7a7eBDnQ3zwYWoVMBKVDrjrZhcngcjFynYSGfcXS 77k9vlQQDoQDTnP1tvlrZG5lv6E9xt0BIBIFdLMZ/pxOYscDedtBJ04QYzWvH236p/ qCl+GHIQGbZijukhcObO2QXP0tfLSrGCiengsytaGlZUoUHaiRvH7SAJSmlnJcjIkn nwKaH4j/lutkv4UlHuOf6a/9i+4UqkIAIdP0E0M73jnakugD/zSFQ+QGWCa1MutCgK 2k0d76TTPtDzw== Date: Wed, 18 Oct 2023 01:23:46 +0200 From: Alejandro Colomar To: Axel Rasmussen Cc: Mike Rapoport , Peter Xu , linux-man@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/3] ioctl_userfaultfd.2: fix / update UFFDIO_REGISTER error code list Message-ID: References: <20231017230110.3170850-1-axelrasmussen@google.com> <20231017230110.3170850-3-axelrasmussen@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1zR/LIJPaF8GvZmk" Content-Disposition: inline In-Reply-To: <20231017230110.3170850-3-axelrasmussen@google.com> X-Rspamd-Queue-Id: 9228A180010 X-Rspam-User: X-Stat-Signature: kzbdbwmgr1xj5q91g9jnwfe6be8scddw X-Rspamd-Server: rspam01 X-HE-Tag: 1697585035-672384 X-HE-Meta: U2FsdGVkX1/Lq4ATPBnTz4Y/FVY4vcOTgqyYDyJw4fLmFAwHmd0urdi9SK/5Qy9gqSEM5ZPOl74ZeVyM1L15srST8mvFy12L33jTA2btsWceqAgYNMx5X3X4INUZFPeryNQo49X8gDKeiYEkxbsDLOu3gMGjEF5+l3vA75w4Vsl2n8OSkHdT1D65sYtyUz08OQWjbm1IshDWQFML/MNrfAW2Tz0N8gyi1IXLBfVj64+mKYfJFo7tgcaIksQizCiq29Whj6t9S03Cav9qBase4UCU9RgXZohmwfs3T52YEWMcJYzafUJYwxQU7zEL/EIjom8Jy0tBR64BE2LPsfpjg7atDbrzpQ8rgDCVWvkLx1B5T+idhDtSC/+Sl82e8N07KugVxWpiDsYTJMv1WiQ7T+IXla0cwrWyyLtE730ZjPGHTsbVM9BB0LHxfixj3Sw/4SFEMrw6j4Qg0GY9jqjI3QElMNC+vW9pIhfbcHbjqD9T2+xuY6lwRk+l/WlOtTLZfnlePezhoDxPrqQ3gljcMPhbtJPouwWQ/k4+CcImOS4oBafg8+8vZMwZMtv00qhNbbFjZ5yf1/qLQ9KmSzpgLK4xEyhAs9ZvLEisG9Ma/Gz/Szyj5NblFKVkW9qD18pDtGBs6p5508Ri2XWdEDyE9oJZfgoad3mC34kO5d+Wkq1y0NfOEuti3z+JEz5Jj3PUsmPOpaholz7fSxTVXyMbRGa1ujgHHJZkFE52U8fRD1lBH5En8SrRAUhr/0ER0JGH2Ih+ARILaddlxWnflngoifvSfi6756f5nnPxIe0wHmHMcFcz/T8JRbBtynkSzddar2e+PMmUR+FXrlLrCnd7l/jzbYvS5S2rqYiPePGkakqJjJ45EfuLgYUwZvtJQg5N8OTeIAwGPLhamgsemwVMFmj0flQP7OB9diQ0ZvaUH+afwHwW9Dl+bvj9YVY273QZNrokQY+RT5TtGV1SdGf OpoNmvZv 1ZBeRRcSjMHsTY3J14PuJpfmh0yp9B+lw+QUuo9tFXI0KdR5iYSQJqbJjThZx0+UwJCkdXklOrCyFiBgqwpuOzYfb/1CGlrjH71wv/u8LEUP7SKZNjsgAbS9fs4R0RTMF7cd2tm3QWbTKLjQOSfKCpxd1vl+J5NZIa3IeaYRrnawddmB7AGdFgdV1gR3v/ES28DRYUp7Fl36ZlMc8OUYeS1gP6jix97v9AM5Wmq6crVB6t2n3VKbcOiScNQ5jJqgOH7sMACcCnea4eSKfpFBbLbZq135BgJPjSwtLeA5uibWvlE6jPvtP9c9Ii04B3A0WCEdCYxyMc4C6fTmtCB5ZqfgO6NYwhAs2ql6St4w/MRrdJkIkOB5XMwmdl+DrVO9fBIKU3rxCfPASmY3uRXg9oJEr4YASsrv36wL8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --1zR/LIJPaF8GvZmk Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Wed, 18 Oct 2023 01:23:46 +0200 From: Alejandro Colomar To: Axel Rasmussen Cc: Mike Rapoport , Peter Xu , linux-man@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/3] ioctl_userfaultfd.2: fix / update UFFDIO_REGISTER error code list Hi Axel, Mike, On Tue, Oct 17, 2023 at 04:01:09PM -0700, Axel Rasmussen wrote: > The list of error codes in the man page was out of date with respect to > the current state of the kernel. Some errors were partially / > incorrectly described. >=20 > Update the error code listing, so it matches the current state of the > kernel, and correctly describes all the errors. >=20 > Signed-off-by: Axel Rasmussen I'll wait a bit before applying this one, in case Mike (or Peter) want to review it. The other two, you can find them here, as usual: And BTW, while running `make lint build check`, I caught some accidents =66rom a previous patch from yours: Cheers, Alex > --- > man2/ioctl_userfaultfd.2 | 33 +++++++++++++++++++-------------- > 1 file changed, 19 insertions(+), 14 deletions(-) >=20 > diff --git a/man2/ioctl_userfaultfd.2 b/man2/ioctl_userfaultfd.2 > index 82aee667c..40528001e 100644 > --- a/man2/ioctl_userfaultfd.2 > +++ b/man2/ioctl_userfaultfd.2 > @@ -413,8 +413,6 @@ On error, \-1 is returned and > .I errno > is set to indicate the error. > Possible errors include: > -.\" FIXME Is the following error list correct? > -.\" > .TP > .B EBUSY > A mapping in the specified range is registered with another > @@ -433,21 +431,28 @@ field; or the > field was zero. > .TP > .B EINVAL > -There is no mapping in the specified address range. > -.TP > -.B EINVAL > -.I range.start > +The specified address range was invalid. > +More specifically, > +no mapping exists in the given range, > +or the mapping that exists there is invalid > +(e.g. unsupported type of memory), > +or the range values > +.RI ( range.start > +or > +.IR range.len ) > +are not multiples of the relevant page size, > or > .I range.len > -is not a multiple of the system page size; or, > -.I range.len > -is zero; or these fields are otherwise invalid. > +is zero. > .TP > -.B EINVAL > -There as an incompatible mapping in the specified address range. > -.\" Mike Rapoport: > -.\" ENOMEM if the process is exiting and the > -.\" mm_struct has gone by the time userfault grabs it. > +.B ENOMEM > +The process is exiting, > +and its address space has already been torn down > +when userfaultfd attempts to reference it. > +.TP > +.B EPERM > +The userfaultfd would allow writing to a file backing the mapping, > +but the calling process lacks such write permissions. > .SS UFFDIO_UNREGISTER > (Since Linux 4.3.) > Unregister a memory address range from userfaultfd. > --=20 > 2.42.0.655.g421f12c284-goog >=20 --=20 --1zR/LIJPaF8GvZmk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE6jqH8KTroDDkXfJAnowa+77/2zIFAmUvF4IACgkQnowa+77/ 2zIhGA/+MK4uCVY4B5Pzdede4hVOluo1X1mpyfxn13Sn2XIsl5HK7Ofu/Z6tlZIQ NmSG9z0BdvmwzhfWP5dkE9s/bRayn8mIr0i1F0GmqH7jBzgLSkPDSg12+lJ5Vikw 30bT5APaUTG/SWQtsgNkqksJfBB6r+x4Mp9FllryxvbKsNxDJn6tXyuARSrlLhlt tPPzjSm6S9ZPytyZPHkQKpzKIUNqalx20VWiLhXiuw2zL3ags3DNyyg3tvnOG7yS 4sVpxI/pm9ch+I+PPJCnXIwVO+20kG7NZqOso1Uuny2gQ1/Nk5XmhgXos9KmrIhM GUcZ2ZJ/4JlOX5ISOF3uGMxknRyqCqM6MrH6rFH46Hmvct1ZPoyLCsqkhctxvc1b Rb/YWk9y+1cnVPJCsVLz3VwWAOrtCKwr+xUO+Upjy+KDX7k50MkdRpUNsHmtAH7n Bpkj57JWfsUUsZTxy+2KwPRNdp+KuG5W3/iUestIw/6wXEVA3DKHfF0+or9lQwkf tIiaNbqH3+i9vJ1pyyuXZTrKYFzzdharCJTs8ZbIvva9i0HQSy0kfYnc1laPabGg vlgMMJaLG+ZkafWe8LYTmUJmrawaegkwA2rxhdgyNZ09NPCMrcLCW7yEKnQXA3+s F2rTVrizUtVYWyQa4gvfntyuW4VQL2RyKwQcvSFmfUp7le3FdQQ= =irXp -----END PGP SIGNATURE----- --1zR/LIJPaF8GvZmk--