From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBED5CDB474 for ; Tue, 17 Oct 2023 21:42:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 600608D0011; Tue, 17 Oct 2023 17:42:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B07F8D0005; Tue, 17 Oct 2023 17:42:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 477CB8D0011; Tue, 17 Oct 2023 17:42:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 35DB88D0005 for ; Tue, 17 Oct 2023 17:42:42 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9CEA41CBB6A for ; Tue, 17 Oct 2023 21:42:41 +0000 (UTC) X-FDA: 81356278122.28.4C31465 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf28.hostedemail.com (Postfix) with ESMTP id D61DFC0008 for ; Tue, 17 Oct 2023 21:42:39 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MoaQ3Ji0; spf=pass (imf28.hostedemail.com: domain of alx@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=alx@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697578960; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1s09wWZ/X+MM4abcpHd9krW5JMfcU1OclKuhRlLlmbs=; b=gVdHMtimjZ+7JdNbpADPheVyveZz5TFvRZE92qQfoosZ+R9dPw46WKYDFEP1xyuJM0wGON uWlvyspMeF0tzRnHMwZSOREd5o5FguRK1KRTK0A5J1Xytfo8gV6bOEWd+oSUxio9gavqux HKVwzw9GlSUdlII0hPy1HPumXeh48X8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697578960; a=rsa-sha256; cv=none; b=SXapOiYBhyX6eU6jBBKOd5L2olJYy0DV9hOr7KhP1dlnSugv9FSncc2GR+0oiLfiOzt6jD JfbMCTUBpDoMUeeegi6Q7N9vEWXM1BdrK75D/DxFnkUyja/OZPwJd4GlIwMqPcaFu7Fzoi hkyx6THNxt8X2AdB8O3LBpBXktnNaHE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MoaQ3Ji0; spf=pass (imf28.hostedemail.com: domain of alx@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=alx@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id CF7E9B8206B; Tue, 17 Oct 2023 21:42:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9FBBFC433C7; Tue, 17 Oct 2023 21:42:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697578957; bh=bEJk/El5S1sh0NLlwpXelLcKGL2EcQlfohD4j75wrrM=; h=Date:From:To:Subject:References:In-Reply-To:From; b=MoaQ3Ji0O3v7mU1S5rtTGqSlenPQZPxf3wArcAU0R6jMnPuNoJ7M4ULHv/ZAekdUu nuxnxm1oV9PxCEke3tCAn6qtwnw8PqaK/eygeiNHqEyYIVmNCfycaHXAv9djqNDdyX 3Q9Z8NyrVtvQEGRYzocWD7YqijYwdEmqWkRqg3l6QR+p89pL3JlpsBhaxsxtAYfSM5 48MwCJvJS9ZM50mzUDBXwWk/zxPC5QmhF7WzXMgNbQ2L5oCXSQJV8Boifry/U+2DkF hzpiAS2DUn/RtM7uBlCKvnuVkfTqLfJSjnch7Jfxx4mMl/XNW5BI9a8+RSUYkdynYn GLU5VjQK+zmkg== Date: Tue, 17 Oct 2023 23:42:33 +0200 From: Alejandro Colomar To: Guillem Jover , Axel Rasmussen , Peter Xu , linux-man@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mike Rapoport Subject: Re: [PATCH v2 4/5] ioctl_userfaultfd.2: fix / update UFFDIO_REGISTER error code list Message-ID: References: <20231003194547.2237424-1-axelrasmussen@google.com> <20231003194547.2237424-5-axelrasmussen@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qDHSbjq1ltIB8fn+" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: D61DFC0008 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: w144c4wqe1uoxy3sp7xy8s68yhmkpzgd X-HE-Tag: 1697578959-699868 X-HE-Meta: U2FsdGVkX19/h2V7h+iYzH5K2MDixfOZcDVdJ73t6uDf9dIaORBELecvynESGA/5sfDYGCigHhfkAgjXaEGFEkyCX2+UAMaAsPoE/ceaaizdopGUeohuwSFrqiF3tpToyaUwByoLj637QdXAWuoxOYjoPOOZYNb15kGr6tifIQ3pPAgau3kdgX9dZZ6W7MsSNz4pzPZbHon2wrDnebglD4iz7oEWwAIaymFpKMXndzbzNUkE5A27mhruiAqZAsfTddZ/JlMZ9fCwaoOc2QCEtSu6nIkOSyLY8RSMbbHGwjCEHUiGqhYWGyLL8PV6S5qpXv1f35zGplcJO9IFGLymE9h/+4R9tR/8TO9sf4tvcDpOgUSh2r518ZKBjNLU9oQq9yyKceiXw7iHBMTxC/fRVhjLvMEBm1y+YdIQY0hY/cDJDs0tZlup5mGEbTMLNASR3JLgKk+dmKWeXKrIRiQg476xNC/kxb8NoNE94HnSG5x1QmGQ6isQbK8eh/TngzMS9XCIyTd7KpXzJ54CfEECF6ieWdLzpaCuvW6WAeelD6v1N51ETd0IYFgZRGe2uZbtcwn7Cj7+0SNd6dWnbFbbDcm4Z1vfZb2xIAE93F0LrjHtYcfbi2y5smj56Akb7P1eW9kesrQ2DUY4PGKPzcVTe1oLqmcbh4nnnzCgrKsS9Aaw0hICC+RcjJz6iEsAw++4abaTgC0EYaGzhoWWpgpXP3O5a7NOJz98CpZs5aQZgyHHHF6dtZgZAll0kgATTi27R4MZqAjiRHiCakxRf/NH7QWAvpeSTTJLjC2TWLf9p3AXthIeH1r42RxkkBuwQ1vfk10L4kXzLSI2PZ4Ik7rtRM4mSnWZHG/aFL80DRpx1M4K504r3r2RQDAGf71UIxlkBG4Drk+RwXDHVA/GojqJ8vTlAhQ75rIvukYa4lYY7E+qL4y8NGaTtdHKY4OuxndGzyp9HY3IH8BkpIDFjG6 5EtaulV2 ynueXqhwVgiYzr75i4b80z+pEQ8ZOh3GyVcY1iTpPnvoy1vYnA9fZN4QmkeJy8BfPwoa7tOj/4LLLGq6bkoiNE2TtugDolQoKerzXrHcAgBk3pJfvl0qRM0vhzfAlm85J2FcbV0xXEwQNb8Q0o6TeVu2BbuOEuADMYz3EevfOiHZTffagwTWei6Y4rvSd9N7xIf29mdGjHHlGxuw16L8CcoIoTh8kueTkGOYRJVcSCNzrVYaNViWMH0ZH77GzVyVZkNOxIKLxvynMYovZLubf9hZnDpMafGozxhp8QLNzYqZJ1xQO0p4q9qprSZGQ2b8T/VX937sGitseVfIynwwkbJ11yTz3UxN8cjwQHWBzsiya3+KLo209fxtEMoPxrxGf6+6RgoGln+xmzcQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --qDHSbjq1ltIB8fn+ Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Tue, 17 Oct 2023 23:42:33 +0200 From: Alejandro Colomar To: Guillem Jover , Axel Rasmussen , Peter Xu , linux-man@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mike Rapoport Subject: Re: [PATCH v2 4/5] ioctl_userfaultfd.2: fix / update UFFDIO_REGISTER error code list Hi Guillem! On Tue, Oct 17, 2023 at 11:23:10PM +0200, Guillem Jover wrote: > Hi! >=20 > On Mon, 2023-10-09 at 00:06:48 +0200, Alejandro Colomar wrote: > > This produces some unwanted space. Please apply the following fix to > > your patch. > >=20 > > diff --git a/man2/ioctl_userfaultfd.2 b/man2/ioctl_userfaultfd.2 > > index 6e954e98c..795014794 100644 > > --- a/man2/ioctl_userfaultfd.2 > > +++ b/man2/ioctl_userfaultfd.2 > > @@ -432,11 +432,11 @@ .SS UFFDIO_REGISTER > > no mapping exists in the given range, > > or the mapping that exists there is invalid > > (e.g. unsupported type of memory), > > -or the range values ( > > -.I range.start > > +or the range values > > +.IR ( range.start >=20 > I think you meant =C2=AB.RI=C2=BB here? Yup! Good catch. Cheers, Alex >=20 > > or > > -.I range.len > > -) are not multiples of the relevant page size, > > +.IR range.len ) > > +are not multiples of the relevant page size, > > or > > .I range.len > > is zero. > >=20 >=20 > Regards, > Guillem --=20 --qDHSbjq1ltIB8fn+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE6jqH8KTroDDkXfJAnowa+77/2zIFAmUu/8kACgkQnowa+77/ 2zIIsQ//dTvOtN/wns4bqPazY5U/kGVNLe9Skp5b8vVRVSvVQyevS80tzbOQsAJ/ pMyqAyg+SV/ou1VyPrnhKoUkCm6fJUPA1PCG164hbkgND64PKSSkU6fpZW58ZmTi XQyq+DasxjEwlqbSCTRPUqslpugmNuaOVwtmDT3ggFoFHnwEmGNKmjvYBqWrM+S9 6MpJdh5JaIJGF+MY3rcgwCfwYuO8Jr5UFXV8YWCZqK8gdJT/70l0p6orptFmcMt5 dpqU6oBslTq3Ho01yTMyn4pVsEnHzPMg6nM4cXzOFI+gJPn/4SGe1PCq1YlCppOJ sZlEo7+GEzSUBq+wXF99mhI17qWgdq1IxFRy/Srb8/egwhBhVFjsiFBK9AgKD+O7 /MvOHXwafDDxvtz4xA6mBCSCjb9a6OeuxWAWRTi693nDQxe6zHuIqABz13VPYWKW X01HIgzMN5FRHmKJ/1IRy9cNCh0mRHJaTO6ICbVH6/HXUX+SOTxtKA47dv73kSf3 8NftmUXKYO8h4zbaDBx7sU5ZXa0G8rSKPJTQ6sZbdwdeejX95r5D9YJ1n8CSxu5t YQzktCzPQu4yLKxzFjni5lJ4r0bxOcQzC6EKOclISGkymAv5hAWE4DozQvX+AkXl q8/lvUylvTTn49undQUQP4MgzRvEtEGfE6RV0YD+9Dk6TVkGMOo= =C6aY -----END PGP SIGNATURE----- --qDHSbjq1ltIB8fn+--