From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F8B6CDB474 for ; Tue, 17 Oct 2023 21:23:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DC068D00A8; Tue, 17 Oct 2023 17:23:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68ACC8D0005; Tue, 17 Oct 2023 17:23:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 579A48D00A8; Tue, 17 Oct 2023 17:23:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 48E7F8D0005 for ; Tue, 17 Oct 2023 17:23:16 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 14D381CBAC4 for ; Tue, 17 Oct 2023 21:23:16 +0000 (UTC) X-FDA: 81356229192.23.2643322 Received: from pulsar.hadrons.org (2.152.192.238.dyn.user.ono.com [2.152.192.238]) by imf25.hostedemail.com (Postfix) with ESMTP id 16702A000A for ; Tue, 17 Oct 2023 21:23:13 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=hadrons.org header.s=201908 header.b=pmjaTy45; spf=pass (imf25.hostedemail.com: domain of guillem@pulsar.hadrons.org designates 2.152.192.238 as permitted sender) smtp.mailfrom=guillem@pulsar.hadrons.org; dmarc=pass (policy=reject) header.from=hadrons.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697577794; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rCrmn9y03CfqjCPi53Ca1ph8YHiUpD5hgaahZbYtSmY=; b=zjoFTaOGHhu7HLwoLHpBWSnLBF+NU7Wfsd9K323qA/BikM2Y3mQz2fBD9Lwvn2Z5tknpp0 uxqtEk6ahHh2bYwkqGR85esYvHuLybfCk0eBF72BLfgTVYNVO8354zJ7cmzvBjCALoETtQ /mHqgYE1TNtVsy4UacHpzgVMSelXoQY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697577794; a=rsa-sha256; cv=none; b=xWF3QkJTbXTCuMs2/k+awdUNoSkRxOjfNyPhNh+82hNh65za3E8liHK+qtIgCHNlCv+1FT /MDdGWZcL3nShGVg2075yTZnJKyv4hl443ro1NoJsga8A8Opwds51CHeF7ff2HaEfJh2H/ 2BQxHO4sKwLfOHjXR1V4dQpj/kNsM2E= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=hadrons.org header.s=201908 header.b=pmjaTy45; spf=pass (imf25.hostedemail.com: domain of guillem@pulsar.hadrons.org designates 2.152.192.238 as permitted sender) smtp.mailfrom=guillem@pulsar.hadrons.org; dmarc=pass (policy=reject) header.from=hadrons.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hadrons.org; s=201908; t=1697577790; bh=rCrmn9y03CfqjCPi53Ca1ph8YHiUpD5hgaahZbYtSmY=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=pmjaTy459tR1za0fQB1dwq0sKNqW94wrmvEt950rPRUSLFFE3pLumuJJM6CAQD6RX XqwyVOjoz420fxDL3PcUIsf03hoqRmRBnbgzLwr2erreFbJlrUENXHdh6hMSAtPElC AYIWSWKrcrUTvi+fetC7Y4gHWV+fqkrdCiVX/VvUE0TUXjx+BoRPv7xPGstEierJTA CEWJdsu/RXYseQ+wdBODvmad5SFvuBotI/7nWhzRV3PdzfENr+L382NQWYkMWR5FvW wW6yqU53bv7z/GakDepw095XbWw5mfWL0b1Ydxw+6YRitigoyW4oYnr3Pr2Luk0C9J uuYFrrjIEGU1g== Received: by pulsar.hadrons.org (Postfix, from userid 1000) id 77FAC122CA9; Tue, 17 Oct 2023 23:23:10 +0200 (CEST) Date: Tue, 17 Oct 2023 23:23:10 +0200 From: Guillem Jover To: Alejandro Colomar Cc: Axel Rasmussen , Peter Xu , linux-man@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mike Rapoport Subject: Re: [PATCH v2 4/5] ioctl_userfaultfd.2: fix / update UFFDIO_REGISTER error code list Message-ID: Mail-Followup-To: Guillem Jover , Alejandro Colomar , Axel Rasmussen , Peter Xu , linux-man@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mike Rapoport References: <20231003194547.2237424-1-axelrasmussen@google.com> <20231003194547.2237424-5-axelrasmussen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 16702A000A X-Rspam-User: X-Stat-Signature: 133ed93bmhdhdqj83uhnm11o19sf14je X-Rspamd-Server: rspam03 X-HE-Tag: 1697577793-807558 X-HE-Meta: U2FsdGVkX195t1E6vVo+2rP73984sjzeuUbEu80YI9QRnhZsQuW47fpHzHRpsAxzz8shEsmAHsjUfcUcPaHjy0U11TneFFJh6xzZu40p6/2ONMTS9fEKk8xYk/iH+JTSqOWwSX39J6LVMvIO15jj5hDKhkJNCxYN4Sokg2A5DJytoQDBnA8rAwyc9m0BdigDTAaGOVVCBFby27ZkUPFIAxWlMC9l0XG8HaFl2KMPdYCqZR6mfQouBF003HzWT/IbGmXq5BSqxF8saiZY2jjLVZpidtkTP2eUnAxNyopZe8V8/6XkqrJVtjrvwP3EPYwIydZG4LB2Mct8AH8u6QTE4j4kit/VzsWCKSq7152m8q10A+Y7/WugDqe3m3ayWTPAvnkfLWqjozRA7buQfHB4OD/aqdpinituroC71FS/RmQHZxHYaslehYl0N6Jrj37OHsLwQKxkYTA8528ujBdIX2kgxcgNQNmDLC78qnYQ6EXhX4jDay8CNAcJy6fy3nRV3nD6CqdSQRpW3yfUtYXw406YA0E5xE7qOEyp+zY5zrH2crwDdYd69RRehCERRSscp2svgyZDHfi3PDnPVbmn4O9dKsJoOKrW+GtSq5MZaa0uWxfS6CvuG6DPri1Ul2037oCjwfuZi4ueKggXWuYDKbw0T67i609Q0lIRfX9ovYW95HuuL52yikqIePC6H4ybum1l0J1aT+oAZFAD1eOx93NfD9eyHwpXKn0w78MTABI8aTJa+6wyyIjKiqlI+eicBZYo8cuLVfFvm2OFPmGs0TCUX/ir3fN9K455EyRHwoU1XXitEAGybVl6+YKsnpWhHUiz43kcXZeE/1elmJj2t044SIfwyhAtVVvI5OAafnddO/vtG0aHIBejVLckCeADUazjwsD1WUelBDeCWebVkUh+sDSEjttw/ljVb61XPX4n2DWoJrhyiUlmZXY7dUHngr+2KCyVLTuym2vklBl ApFlnZbA TpZFQJOPY/v5r9elbGiiIcGcJzbsTUNj0klPZFmcIMDGWxhYThoya8uN1EEik12zPJDZO6RRgX6iz+ZEgmDAOmXjnZZRg3+ugDWJpyxwlwneqWTHK4vi1kjds4HhSbUGQS5UCjwhSyGePpdENzPkvFMcRXHy9/dt59whUS+d1ZJ2bMV2tdiH/T2pd0BiGEsAVmZlADGh8samATNrlUFKoO7GZbuC6NR2OEsAb/CV4YP6lh100KP9yTFH1PsYcb4pnqhNoDH9jLnaH5iFEKVfazK437/BcLyeIjyUhI6oWHXRP5YjIRnHCsjnCmnqgHmsQL3xuWYGxk5zzJknE2mx/28YEj69bRAnmGFgDnAEQwhu1ujG86CJb3UE9/rb+Yos1IxtF+gIxA4QUj+Xh4JKAjkhRV6LKEATRgJ2S X-Bogosity: Ham, tests=bogofilter, spamicity=0.002172, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi! On Mon, 2023-10-09 at 00:06:48 +0200, Alejandro Colomar wrote: > This produces some unwanted space. Please apply the following fix to > your patch. > > diff --git a/man2/ioctl_userfaultfd.2 b/man2/ioctl_userfaultfd.2 > index 6e954e98c..795014794 100644 > --- a/man2/ioctl_userfaultfd.2 > +++ b/man2/ioctl_userfaultfd.2 > @@ -432,11 +432,11 @@ .SS UFFDIO_REGISTER > no mapping exists in the given range, > or the mapping that exists there is invalid > (e.g. unsupported type of memory), > -or the range values ( > -.I range.start > +or the range values > +.IR ( range.start I think you meant «.RI» here? > or > -.I range.len > -) are not multiples of the relevant page size, > +.IR range.len ) > +are not multiples of the relevant page size, > or > .I range.len > is zero. > Regards, Guillem