From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20DE2CDB474 for ; Tue, 17 Oct 2023 15:55:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7713D6B0254; Tue, 17 Oct 2023 11:55:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71D7D6B0256; Tue, 17 Oct 2023 11:55:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E69D6B0257; Tue, 17 Oct 2023 11:55:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 48C9F6B0254 for ; Tue, 17 Oct 2023 11:55:05 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0B3C880D6F for ; Tue, 17 Oct 2023 15:55:05 +0000 (UTC) X-FDA: 81355402170.08.ECE5D10 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id A9703C000E for ; Tue, 17 Oct 2023 15:55:02 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=hjRhzilX; dmarc=none; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697558103; a=rsa-sha256; cv=none; b=gkG7PzLMBCaU3L+Ee0PP1hSjCpTCEmAKtX65MCxEApZnkv//4fjBeFTaJHVw31s2w5ovDv p6WG1hktRS7oZi+FqVuV3s2QYp4ZNav2kTlj8vlp6DxMzNocZ7p4VudWdXIc8UgSHqv0jD +29+h9qw7W4QHbcQ6xEVBHnHaZQxMUc= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=hjRhzilX; dmarc=none; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697558103; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VrFoNcC3S43mjlhiW+V1SrfZF7QU7fgttASsi6ItKq4=; b=TmMh0l+thvImDNxL+tb1UDcbAhay3VrzUUAB0GSZjGNi1PXuz4aBTy/JywarEUHAv1KWuE +ftiqntF7HsDmDZ8AJih3izetqIrP01V5XUtifZIwa3MMa11x0Rnep/I208yh7eB5pdXKN YiY44GEVIQz8eQavbnRop7/FGaDKj/k= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VrFoNcC3S43mjlhiW+V1SrfZF7QU7fgttASsi6ItKq4=; b=hjRhzilXs9do3FEcDzvCW+Imvp Kj8KQc8jeg60DnBVQtHAcMXdFlsIxZytVDaZQup2T2gNqsyHXgJC4I6+st48eu0Lz97hk/HJ15kZy Z5gl0f1zMdBTsVZGi8kXKfsVLNMq/+qZ3I6IBrF0biOmtfJ73gB7B6mf0cRx3+VUlpRA6vkxGOsvP PzPm/9L5VXiH3TGQ5+fN7fRtirYvRdiwiK3XzhRzmnvmU/+W+mo6VD9zuRwFDSXMjUUp+HAvQs4vl J68RL5N1pfk/odu0M4vv+KRz70MCWXuXk0LgCh8Yl+4gWVuswPlusELy5riGd3NOPULlVkLmBKWOx mvtPKSSA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qsmP0-00DCyk-L8; Tue, 17 Oct 2023 15:54:38 +0000 Date: Tue, 17 Oct 2023 16:54:38 +0100 From: Matthew Wilcox To: chengming.zhou@linux.dev Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chengming Zhou Subject: Re: [RFC PATCH 1/5] slub: Introduce on_partial() Message-ID: References: <20231017154439.3036608-1-chengming.zhou@linux.dev> <20231017154439.3036608-2-chengming.zhou@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231017154439.3036608-2-chengming.zhou@linux.dev> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A9703C000E X-Stat-Signature: 3ab48jq1499fr6yo9r1beuqxozr3wps9 X-HE-Tag: 1697558102-918128 X-HE-Meta: U2FsdGVkX19wPyq+3NZObYQN1oL81R0k0mqe+uv+Ek0aQojnMhgXBYraTtoQ075yE8R8D2nRTKGvuf02IXTK8U6YVnfs5LMyodk2WJQ6zL1diCbGEzRLXE3dONVq2yiGVQ9pL8ycpTGVVj02JHSw8nyR+6sPsM3NiRStmdrH6A8auUVhAuyHzo0TM02qjc87xe5tOz3DGbH9fVaekaPJ+IPuEpEDvMKziID/zPlJqKhuZptp+QqzORJvUbYtryNXMb09NkWJ/U8OdQD/UeDZzvoBnhij5PGJK2y57UcJYmACM2I8/nddMIn/PpBBD55hgGgjC7L4svVXv4W21h06zG2DS+ztVa6kgDWLiFEwyCrQc2pJE/dnA58kt6xPhzIVXfiz/hiGf0r3kQ01tlsrt2TJwIJQ5zh/W03RH6BqESPk3GhBg6oKG7l0CBUGQo9SEfJ+657IkYqcMW6DmKWzbRheKDTKe9HxDPyEJT+hIIB/IHyBa+U5TT7MhrajoSU0Vw14S4owk/EAar759S/pbt731DMTgUCuSMDoFcBt2aHyYK5k4JLmzlZql//K96LTjD+e9c1Hf1fBr/8OMnKeh40KW7P1k7Y85U8vvxGQIeR9UhYtsBYbE5vHNPJ+cw7cAnQy32qiP46Xz5oKMirDmnZ6um1W0hXiYiNcZt6mTOkpiji7AAluWeuWCFeIEOIULhsbcvTIInDdsvoHDGe4M46Z2f/wQlhARRrCILiyGe8aA5Xzhdg1Ld4pEs9eeQ6EyL7AcWPotpabNFhAvz5rU47UOey62xWsk3UFxq35i393SyTBha00lmKe5rTg4OtRlejcbCxlpDWQM7IHanVzelwm8DgLCVefRCfE6YuFW1pThWQ2SdPLxO+cnLxhzIbyneg2+pmPCzE5HqDszjyd1/WNHKzuukqniWyHVsAffMSDeM6aROnPEFWnqZDow3wvVSeUvF2WHTXTqEgRknu I8avb8CV bnYPjuQwLG2Cyqv6yGmLGQLkoGZk3O5yVpufnY4DmA0J/Wv4glj8TR4HyPK06pdBYEyEx5zQdAYxJow0wpSU2sqFXBcDRDrgD4Osfy83qTglRz7WyH4Mqfm8pZNhb1cy3iHdJuvOZFC6A1Lp0hAW+XQnkDRy5NcI967gTAhaHM+iy5CSHXG+tw4CVPo+hlVTl6Mscx7OxF/A4FiM9XEn3lHtXEgBZSx7U0dOqrZ6VQ0dksvBm2/FcA50WUwr4IfdP2a5v X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 17, 2023 at 03:44:35PM +0000, chengming.zhou@linux.dev wrote: > We change slab->__unused to slab->flags to use it as SLUB_FLAGS, which > now only include SF_NODE_PARTIAL flag. It indicates whether or not the > slab is on node partial list. This is an unnecessarily complex solution. As with the pfmemalloc bit, we can reuse the folio flags for a few flags. I would recommend the PG_workingset bit for this purpose.