From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD1D5CDB483 for ; Tue, 17 Oct 2023 10:26:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 76C3C8D000D; Tue, 17 Oct 2023 06:26:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71BE88D000C; Tue, 17 Oct 2023 06:26:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60A8B8D000D; Tue, 17 Oct 2023 06:26:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 512B08D000C for ; Tue, 17 Oct 2023 06:26:49 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1CF2EC039E for ; Tue, 17 Oct 2023 10:26:49 +0000 (UTC) X-FDA: 81354574938.13.B603157 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf09.hostedemail.com (Postfix) with ESMTP id 686C1140008 for ; Tue, 17 Oct 2023 10:26:47 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf09.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697538407; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=igOicrJvnJr7CKWsaEkShUy2TgT5ZY4do4G2bRlQorU=; b=tF2J62GDqVCeeNysHK6IMXZDKL6bJIQAzN2frieRh92OJzJDzPzGp3t4Ntb5Kjvuh2MJAq OudvS0So/famqGoJ11Fvb35SauKcOSe/+j9GfToN1Q4SAjsw91K3WX0Jt6SktfR8qNVPZj jXkFcbuSKJ6Gq6MZxmjEx4aY9UIOQ5c= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf09.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697538407; a=rsa-sha256; cv=none; b=LPhGkkJw3YmXy6ePr3X/CrFhvmitpeZzdswUKfixFMhc/DYUJvnWmkhiN0FQJ16ZoKFn2V itJGY/6TVLX+w4qq1385EkDrYsILiQ7tqPMrD3wJHhk4PpFPSQzm3rvgcuxUKpVt6NtqT9 M2U0Qq6W9GOnyaDtPAqKIcPDevzPjqQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id CD983B81D03; Tue, 17 Oct 2023 10:26:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20331C433C8; Tue, 17 Oct 2023 10:26:38 +0000 (UTC) Date: Tue, 17 Oct 2023 11:26:36 +0100 From: Catalin Marinas To: Alexandru Elisei Cc: Hyesoo Yu , will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com, pcc@google.com, steven.price@arm.com, anshuman.khandual@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH RFC 06/37] mm: page_alloc: Allocate from movable pcp lists only if ALLOC_FROM_METADATA Message-ID: References: <20230823131350.114942-1-alexandru.elisei@arm.com> <20230823131350.114942-7-alexandru.elisei@arm.com> <20231010074823.GA2536665@tiffany> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 686C1140008 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 9x4g43k5f66zhk3j4p36nfo5p1p8nu3w X-HE-Tag: 1697538407-449047 X-HE-Meta: U2FsdGVkX1985FyoQAUogPs4iH0lY24g3Ep4/aaJqGYEEPLFvNSqKHRCdLPlBXINR1gj3I6Ls197JJ13Y0OB62BoaRS2LJxezsyVm9Lm8Wx+BJCBuk4Zkz76e7fqLoiXGfuL0Q5nFvaAslJzy8xP7wSTQq/RPM0HBk9A9wS2P1v8eBDObT0isackTvXHxVu3sH1yBssuzbPlurJ5O+guS6qTYXwN7gp8dLxF4+0Wx5GjsEjjYqLESPVfIlt9dzK/Tj34dyZ7vBQstrTCbRVxoRiJ/GbxEHljclpjXV4lXeLmbdCbBbaiIx4OS/eURtnpJZwhkgDeCZaMrPBEn19QofLSbSrvt1QBvfnXpnSFiuAVzgvGr3QR/C5mHTf5kI3tYqmYqIvAAnEmkJMyueRYhNbPW7kucNXHE9nHne2tHl6OIR/4KQdYurA0UBE26rkjn2B6A6GQhWuTmeSSXxl6loJuql5yg9cGhTCByk26X0keDJwjAF+LcI1fMwk4mK+JvIcc1x3/MgycvPnvrTpDKmtm6Ydd2Y8qzA2gaMVTTCXEw6dwzWZvxbXIHtyjkifQsKboGr/YquyFonSWHCP70Lxs+cybTx+NLg5J5WW0ZKcVQM5FK/tJlsTwt32Q7vxHtP7euwlfk2I/sfcvE9J+VdtUmm91J7pnH9HPEbGaseMd9fHSkjstoDDHGtvzw9c9EonTim3nMf+WkP/musHxh0d09C4/A8krWC5Zporobhf1gq8IhYnmSLv0G5vg/iNtoRUWQRyhcR/k50b+3A7i3EBXtVaKE5Ltw8j+QCNuSVAEoSq2UmF1B28/1qQypjoBJwBth8jovxexCG/cBlVxnBp7n6p2j7fuOOXWlIxH8arBgfANNnI1ssmnW42pEl0crUcpMCjbEBDHA4UClaPL1PgWzpZNzWga9tfk+XU5rI0KlQzczMKeuuLGIo2Xo+Z/KTdjxCqBTbbdV5RvPZ2 7EvVXFTi bKCsTXGnK2AezwkNCfYFK/k3lE3PPF2948KZzgdu8gUd6HJa7SQKCRPeG122ibqrE74k/Z09OJ4Vl4igaZZGZBcUJal3xC5fxvU37qYgEqWam26KVj14c80JfLyyFOrJiaD41nm0bRbm5eh1A4/VTNnN/5cVtqufpI4mVpEwUM3nCpIq7KDkKb3MmrhmrI6AkYBTXv6l4GvnBxmAyCGRZ1+8feZMmTTfr9LsqSM6ZoHsujadC6r+LqzfhQm4Ff2YRX2It71vqYhZcVnQjOahmcr6T1JmZHpYqEaYn/2GWewuR5GFP9mnEjY7NzRjSVA+Qs1rmE/dj8oGY1jPnizj+1RlsOuPtUBLKCjZJiBtmV2XkvV0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 16, 2023 at 01:41:15PM +0100, Alexandru Elisei wrote: > On Thu, Oct 12, 2023 at 10:25:11AM +0900, Hyesoo Yu wrote: > > I don't think it would be effcient when the majority of movable pages > > do not use GFP_TAGGED. > > > > Metadata pages have a low probability of being in the pcp list > > because metadata pages is bypassed when freeing pages. > > > > The allocation performance of most movable pages is likely to decrease > > if only the request with ALLOC_FROM_METADATA could be allocated. > > You're right, I hadn't considered that. > > > > > How about not including metadata pages in the pcp list at all ? > > Sounds reasonable, I will keep it in mind for the next iteration of the > series. BTW, I suggest for the next iteration we drop MIGRATE_METADATA, only use CMA and assume that the tag storage itself supports tagging. Hopefully it makes the patches a bit simpler. -- Catalin