From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38C81CDB465 for ; Mon, 16 Oct 2023 11:55:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D328F8D006D; Mon, 16 Oct 2023 07:55:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CE3258D0001; Mon, 16 Oct 2023 07:55:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BABCE8D006D; Mon, 16 Oct 2023 07:55:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A69318D0001 for ; Mon, 16 Oct 2023 07:55:26 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7846BB5A3B for ; Mon, 16 Oct 2023 11:55:26 +0000 (UTC) X-FDA: 81351169452.24.21156FD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 6579140011 for ; Mon, 16 Oct 2023 11:55:24 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZdAON8LQ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of aquini@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=aquini@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697457324; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LMLuJaoV57Wcr8aZZNrwu7qwYblvpG+Vtuy3ujdjNsA=; b=tqUhHhxoWUkrMNjPR2uoHxqoSrn0GQt4kRcn3HNgf9LdHKRi4KmJnQWOcGmPUDp7xCrmp1 UkPoDMLvBC1/FlNJ0VJDrb1lqWEYm0B1Jr2ibxUbZT4ht/m458xVzfk/3Cyv8MPQpTolOZ swWzYVeicJhAQ0028KFoDiud8z35o0Y= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZdAON8LQ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of aquini@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=aquini@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697457324; a=rsa-sha256; cv=none; b=k2f8LvNCGyrCrfEGeWEG4jOGtIcIaGP9XUa/VxytQzUd/uGp3w01/bxyYOy2rwKFuXJEYi E16HqReqp7pQPAj3aguWbOZJfVy1n8CWUJuCOps0KhYDKcs8Su5DGuvhNtMc8pqdipAegc dYasnQwYb/NevwvSGSXHJtIhf9xeQ6I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697457323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LMLuJaoV57Wcr8aZZNrwu7qwYblvpG+Vtuy3ujdjNsA=; b=ZdAON8LQtd6Bg9eIj+eRyQaEntGyxanCmT/4ctlv5HRyts+mWiLioJFJ8Ik3TBMjPPKQ6E UnmMUeP8DUivJTgIphOmHsprwXi9NPO66uyZRddUnjPCXDrlhbGEpQ0k+ZfhkZMWnkvgdF JHijadzAtvL0S48i31Y5DNENrLihb8Y= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-Yyzh9DrXMHGzIWJ_lppDEw-1; Mon, 16 Oct 2023 07:55:22 -0400 X-MC-Unique: Yyzh9DrXMHGzIWJ_lppDEw-1 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-418225fb5d6so50919121cf.3 for ; Mon, 16 Oct 2023 04:55:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697457321; x=1698062121; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LMLuJaoV57Wcr8aZZNrwu7qwYblvpG+Vtuy3ujdjNsA=; b=QagyWtJuzBPq8WR1LQvuFRXO+rxZkcZCIx/oNiE6vTBEfYIzWe4Njt1jEuQKdYY+LS KzdnrpS4QX48fTH5V1VApNRyNsZGtfpVRL/7iSPxDdEmMkNDTUd1UTLK2JDQcFRbDHxk d03LmSznQxEC5DVdQkaRhQPkdekt+92esNj9NNqgoQZR7gpt9/sDGgAl1s+YFmCYTCsH G6Oc3k2c2NKDLLTyN40FwnZrY/K4WyaT6b2ZXZe4/hXu9IiMtsGLU8x7GnnMgjcA1VWh 4iOVrCKPASi6vscHP15jYurFN3QL/f8T54Qqf2H3LQvDgeo7UGPI+M+T+amJnn+cd0+E 5Vwg== X-Gm-Message-State: AOJu0Yy1xXvL8RXtfilrmE5Qa4QIdfFiIPedqBPttsMtsuLbmk9Qdt8J lHrKLTQX0gJH+6nRepVv41QEQ3a65XNRlcqIYdINfUd4i0DN8U/TpflrOdqU6E0pRnPfqr3kNnA nN1E6h1qu878= X-Received: by 2002:ac8:5fc1:0:b0:418:162e:6a5d with SMTP id k1-20020ac85fc1000000b00418162e6a5dmr40355021qta.67.1697457321731; Mon, 16 Oct 2023 04:55:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH7bKAHQAoDbs/ePFybLjdjR4Sjj0jshB3lRwoxAg6H5eTLRu5GFAyFYQWGQ2J3u86nt8HUmQ== X-Received: by 2002:ac8:5fc1:0:b0:418:162e:6a5d with SMTP id k1-20020ac85fc1000000b00418162e6a5dmr40355007qta.67.1697457321437; Mon, 16 Oct 2023 04:55:21 -0700 (PDT) Received: from optiplex-fbsd (c-73-249-122-233.hsd1.nh.comcast.net. [73.249.122.233]) by smtp.gmail.com with ESMTPSA id w42-20020a05622a192a00b004181a8a3e2dsm2979923qtc.41.2023.10.16.04.55.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 04:55:21 -0700 (PDT) Date: Mon, 16 Oct 2023 07:55:18 -0400 From: Rafael Aquini To: Audra Mitchell Cc: linux-mm@kvack.org, raquini@redhat.com, akpm@linux-foundation.org, djakov@kernel.org, vbabka@suse.cz, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/5] Fix page_owner's use of free timestamps Message-ID: References: <20231013190350.579407-1-audra@redhat.com> MIME-Version: 1.0 In-Reply-To: <20231013190350.579407-1-audra@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 6579140011 X-Stat-Signature: snthbbgk5xaj9xqp79usk4e6wzm53epy X-Rspam-User: X-HE-Tag: 1697457324-359555 X-HE-Meta: U2FsdGVkX19vIme3LcCNihw2r0nFZYWzZira2uN8ouQrU4Tiro1SmoJB5dQVhMuU3jFf1S0cN0peB9H8DDDkfDf3zVDsoT/kPYEycX6p3JuLa3ctf+BJPMBLY4mF5Smsnr5RmxE/I/PJMYVe2sQH89freccWyIM5VBee+5eXtLqQ/gE4zfP3fdwy2uFPqCHmkSMy0qzaRwEp5uzJW2wPUfXahvPIno7tdDJ6O28a3JeOWd4TMHW3U4kFlKg8KkZXsPJWb9knvZhb4X79MX7TnxY0P5GXOfIOcmdV1ZAaCDd4OGg0fYiyyukVDbj7NEIvz6i+ZKifAFFyXl5j0FksXWbMaBTbQesQW1dBz6AcHBLU37oKmb/B2Rx5whs1BG8oN1ShKf+MXnno+w/N/PUeRF1ttioTv1bMVi3mYmxk/w5INzu29k8Ys69OaNy39DAXbGzWwEe/YONuu/Jp8XHi+WM9+llmhu4LvJ8zqNm7ZkGx9xdljNflrPqDPrDMLTMZHOLMKDAv11qFyzkypjXclGnWVM2mMQWGuGI6mHTuRTYnyg8lPpfwjW0SxJa7I9Sq+9xxPlftQT+ZwdLBheqDHp/DJ3wq9sfLNy83a8BvJbfn9bDim0HOO4hE4LAqOzu4vpVRFC/GGV8Vbm6cXVbl1yRPJzFRHzhVIIP2WAWurzanqxB1TQCwza2l9FCtQdam7BnJ/XxvyTKdx1bqg7xOZcpPnJE9W/x+rR7gE6H9QlFn26yAApupJZ+0YyTfiNXTttoFcbfbtvPsUxI2RapLqjG9sp9xzAdepmmTDBP/znYCMH76JIau85Fy4MSZv4WroJXFrvm4DKpaEwCfUzJNLJzVE0n4uW7ZeUy6GYC/dzwiaFAEFFE6eRM9uF/x6iZtrGgz4Ah3/KBAkLDvKCWB/AdyI3jhPdNcQSdyZbkLBeeEQx6trStETKZhJOTH9Jf5KDXuIuowf7eKqRYGTrQ NU21ivyW MD5LEfxUO6K071qFVHJ8hE5ML+H2vGR0BZlgto5GrRBOeR/JhoIyejFQj2Gqp42MpcGjazGFm5LZUZzVr5dA21I9RIJ/Qozu99XJW6QHSSHLW6RRv4vsDGe3bfp5tL3AKcAbNJaD8P+OxvboX5JI8/zT59eAZGShrwn0ElD+lyCi26OQebIWsqMMgOKVJA4B5MAAu03FG6bDBr9dVDk1N4+uo/j8dZ0ue9AMGq1u2o9xSMbGgOTWZengp/lRX0eeqvKRxzbKiyOf/pdGileqL2IYvBNv18pwwBbwFg4WbwEmod2GXtzHzV2e64Kj0fvoWgkPBdQA2GvGOLR1W4YwjVqnBwAV1nEexVSwi6RB3/YQfv/rwSdmBMemWv4utpE/EQYzQ4LgSxXrwqyzy0HT6hYeyP357BnypvBy6AoRGfac2QCve20mfbn+A+w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.303348, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 13, 2023 at 03:03:44PM -0400, Audra Mitchell wrote: > While page ower output is used to investigate memory utilization, typically > the allocation pathway, the introduction of timestamps to the page owner > records caused each record to become unique due to the granularity of the > nanosecond timestamp (for example): > > Page allocated via order 0 ... ts 5206196026 ns, free_ts 5187156703 ns > Page allocated via order 0 ... ts 5206198540 ns, free_ts 5187162702 ns > > Furthermore, the page_owner output only dumps the currently allocated > records, so having the free timestamps is nonsensical for the typical use > case. > > In addition, the introduction of timestamps was not properly handled in > the page_owner_sort tool causing most use cases to be broken. This series > is meant to remove the free timestamps from the page_owner output and > fix the page_owner_sort tool so proper collation can occur. > > Audra Mitchell (5): > mm/page_owner: Remove free_ts from page_owner output > tools/mm: Remove references to free_ts from page_owner_sort > tools/mm: Filter out timestamps for correct collation > tools/mm: Fix the default case for page_owner_sort > tools/mm: Update the usage output to be more organized > > mm/page_owner.c | 4 +- > tools/mm/page_owner_sort.c | 212 +++++++++++++++++-------------------- > 2 files changed, 100 insertions(+), 116 deletions(-) > > -- > 2.41.0 > Thank you, Audra. Acked-by: Rafael Aquini