From: Rafael Aquini <aquini@redhat.com>
To: Audra Mitchell <audra@redhat.com>
Cc: linux-mm@kvack.org, raquini@redhat.com,
akpm@linux-foundation.org, djakov@kernel.org, vbabka@suse.cz,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] Fix page_owner's use of free timestamps
Date: Mon, 16 Oct 2023 07:55:18 -0400 [thread overview]
Message-ID: <ZS0kpkHkmaAQStV7@optiplex-fbsd> (raw)
In-Reply-To: <20231013190350.579407-1-audra@redhat.com>
On Fri, Oct 13, 2023 at 03:03:44PM -0400, Audra Mitchell wrote:
> While page ower output is used to investigate memory utilization, typically
> the allocation pathway, the introduction of timestamps to the page owner
> records caused each record to become unique due to the granularity of the
> nanosecond timestamp (for example):
>
> Page allocated via order 0 ... ts 5206196026 ns, free_ts 5187156703 ns
> Page allocated via order 0 ... ts 5206198540 ns, free_ts 5187162702 ns
>
> Furthermore, the page_owner output only dumps the currently allocated
> records, so having the free timestamps is nonsensical for the typical use
> case.
>
> In addition, the introduction of timestamps was not properly handled in
> the page_owner_sort tool causing most use cases to be broken. This series
> is meant to remove the free timestamps from the page_owner output and
> fix the page_owner_sort tool so proper collation can occur.
>
> Audra Mitchell (5):
> mm/page_owner: Remove free_ts from page_owner output
> tools/mm: Remove references to free_ts from page_owner_sort
> tools/mm: Filter out timestamps for correct collation
> tools/mm: Fix the default case for page_owner_sort
> tools/mm: Update the usage output to be more organized
>
> mm/page_owner.c | 4 +-
> tools/mm/page_owner_sort.c | 212 +++++++++++++++++--------------------
> 2 files changed, 100 insertions(+), 116 deletions(-)
>
> --
> 2.41.0
>
Thank you, Audra.
Acked-by: Rafael Aquini <aquini@redhat.com>
prev parent reply other threads:[~2023-10-16 11:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 19:03 Audra Mitchell
2023-10-13 19:03 ` [PATCH 1/5] mm/page_owner: Remove free_ts from page_owner output Audra Mitchell
2023-10-17 8:07 ` Vlastimil Babka
2023-10-13 19:03 ` [PATCH 2/5] tools/mm: Remove references to free_ts from page_owner_sort Audra Mitchell
2023-10-17 8:10 ` Vlastimil Babka
2023-10-13 19:03 ` [PATCH 3/5] tools/mm: Filter out timestamps for correct collation Audra Mitchell
2023-10-17 8:12 ` Vlastimil Babka
2023-10-13 19:03 ` [PATCH 4/5] tools/mm: Fix the default case for page_owner_sort Audra Mitchell
2023-10-17 8:13 ` Vlastimil Babka
2023-10-13 19:03 ` [PATCH 5/5] tools/mm: Update the usage output to be more organized Audra Mitchell
2023-10-17 8:13 ` Vlastimil Babka
2023-10-16 11:55 ` Rafael Aquini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZS0kpkHkmaAQStV7@optiplex-fbsd \
--to=aquini@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=audra@redhat.com \
--cc=djakov@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=raquini@redhat.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox