From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBD9ECDB482 for ; Wed, 18 Oct 2023 14:12:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 565CB8D015C; Wed, 18 Oct 2023 10:12:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 516238D0016; Wed, 18 Oct 2023 10:12:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4034C8D015C; Wed, 18 Oct 2023 10:12:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 30B038D0016 for ; Wed, 18 Oct 2023 10:12:08 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DC541B5EDC for ; Wed, 18 Oct 2023 14:12:07 +0000 (UTC) X-FDA: 81358771494.24.DD44BF4 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id 0F4734001F for ; Wed, 18 Oct 2023 14:12:05 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Bvthg0jT; dmarc=none; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697638326; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=41esCbpGOiNvuMpXdu5kkIly6/BMtC7WI0rjINadEXI=; b=DpmXYb8VM8735xsRdqbL5AON79ZO0PlHnFCT+OkBXAzicATmngx2EfL2AJz27jSYEQqobT xDpiy+hsnGPbUhWhLCYZ9LeLbA/EcIC9OQoI75zwsZdwLPaHgA2fL9PZ8/6o0/2NE3pS3M BHLm3pUqliZgAXK0tW+xTD8gBcZahuU= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Bvthg0jT; dmarc=none; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697638326; a=rsa-sha256; cv=none; b=o2Zbq85fB+85iPzXql+oPt+JwaazzvddGR3Dnxogx5IS3XekytfjO8UNCu7NKMmQjFjpvP eVLRfztR1ZZaWFLHRc8P3FRsYl5bm+oOVhlBGMtjeeoK0nMTJIVRd65VkrBp+mSmA3VuRP fy+To6ZcIzEu9Dd8aFMqRqLNOhGPWIw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=41esCbpGOiNvuMpXdu5kkIly6/BMtC7WI0rjINadEXI=; b=Bvthg0jTiYmJA89rusISVNCnk6 FkTOdcN2gYyU3pDzIHF8P8VpC/HpVYFqx3DuGjYDIawfW317jAjZhhLR35rNhrh6LD1oUGlmP3cFQ DJRLa+U0VQHaU+Sty0TFWGsfy76Rsrb6Kh7AWHba3q7iT51H8vK+0JHaCMLM7DzHUUcalGO+NTeQJ yGvSh7lB9E3OY7/QZ5tDvXUq2jV5DQy/xowRGaaTEVcJETyj/W+GSlCBrwJFz9yN0ikPzExYl8SDg pmPbV/6T+Xk7hTF0wWKgzSvhqOGv2k6nQKXm0sfzKXDrBzqV984frPnrdbA3losZDx650PwaGK3tf VfJx7Trw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qt7HH-001Key-B3; Wed, 18 Oct 2023 14:12:03 +0000 Date: Wed, 18 Oct 2023 15:12:03 +0100 From: Matthew Wilcox To: Zhiguo Jiang Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com Subject: Re: [PATCH] mm: vmscan: the dirty folio unmap redundantly Message-ID: References: <20231018013004.1569-1-justinjiang@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231018013004.1569-1-justinjiang@vivo.com> X-Rspamd-Queue-Id: 0F4734001F X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: g5sqkihoq6f1mkwmcogid4gn7uio1gch X-HE-Tag: 1697638325-469122 X-HE-Meta: U2FsdGVkX1/rgArAvbG8gRJ2pYYhmhJ88j2Y8etTd2cJD/+7esjmQt/0gJM5pBHOvnsozR4TALn9c775T1qQRZdIa+6+8v1csv34EmntAAss4TujJj+ophIu4+4krc411WD0wYpxSDjUbHA82+KJqPmI3CNcixytPtF15KC7l9SZ5tN+kDuZd9qgcbFAHaZIeaAxU3UnOp8mGJ9OpSwNaiXVYE8fL3zttCi5eytRJk3oF8g1F0ZY7sxp+AqaYan7Mgyd6vcAw+SGMxaCnem/Tn2/8c0jqDEp4HLZrdFTgGzkPChnhzwE0Oly2mVNHQAw8MEDsAuGzwgrMQo5R/4vkWBg7ppcdGcvqMLOFNcs81X4nBoj9b4FOSwngn762VY1zvm2AUofy2KlUJv83xmpk8GkgitFxOnhQpaZAxEWvttDT4PJrSMsd1qXIfhv92kHe7QSPNgdAF4q01dNHS0OnF97BL9xn187O/Ut24aOk0UwSCrjZslDEtBhvYo4zsAOcAIhfFPqtWUhHkExS+p1Muofm7DaUeIWMWbYcl1QUDc45HQeIX6LcnAnt9urn5veIp4nT1NQpQ5EcXEPnRaNV1V4Ox2V8+QaD9Q89xKsTi5sSUBlN38uhDTceq6CTk8F+iPr080D28wEzOzQpzRaklEoV1pvGsH3rrGanytule5w7HKK53YTe6GroIuTV37MZJPdeXlr/p857RsEu5HxNg10PIZfohjPlB/ciiFxMKln3Yi/1zXR2CxhgOilDX+F0bPFMSKeCF0oW7b5yP9E1TUEtqxhXxA1xrgMmfgLZDTPUV7swQdsZwY2Mm0kUi48Idr5U3upWV2hlH6U7Joc3HEZPccqjCF+q5p/hVK/+durUPYKzmWr4cn+MFjmMBm0pSuHrkuRXxOrH1pq4Psc4F1yBTg/Qba4e/URZLDLNbdoq7fAnObtBdlPI8OIQYMi2YnMr5zTfAoX0dtvURT oAr/wkCF tTRV0xQbFQdrFpwGuZraR/WjOa0i+WTcRTG51v9xLpjzb0fCIPmv82GzbFeQI4Z8ixitCPc7wMXMOC4WeYpGMfUOg2RG+11yD+xdidsx29mLEjEFfLNgIMkGMwctKnab7JJ6stS3HHKPYV2rF480irt6B/MSEBZMTRH5I X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 18, 2023 at 09:30:03AM +0800, Zhiguo Jiang wrote: > If the dirty folio is not reclaimed in the shrink process, it do > not need to unmap, which can save shrinking time during traversaling > the dirty folio. Don't we have to unmap it first in order to make sure that all the dirty bits from the PTEs have been transferred to the folio dirty bit?