From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CA3FE784BD for ; Mon, 2 Oct 2023 15:23:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F4AE8D0032; Mon, 2 Oct 2023 11:23:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A6098D000E; Mon, 2 Oct 2023 11:23:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16E218D0032; Mon, 2 Oct 2023 11:23:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 04D6E8D000E for ; Mon, 2 Oct 2023 11:23:16 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D948B80315 for ; Mon, 2 Oct 2023 15:23:15 +0000 (UTC) X-FDA: 81300889950.23.7F54DC0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id A0E9C18001F for ; Mon, 2 Oct 2023 15:23:13 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=F0ggXDV0; spf=pass (imf16.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696260193; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4O1ESocyKqwozJC+Tl+xGGPxeQyAnmMS0aCpZFUwmKo=; b=unkOAU+SzD6kTe7XOkgdS4PNzqIC0SWCnJvSgGYrq0I0dvJDTJwy/6oI1EmjPDloa/mE7v /d/KR7O4uV7IFn8VjAH+qnB6DosHmPXvVsC4+1AnG0jVd5BLXLIDNkrcnqZlctShNlbVdZ ouJC1e2pBX5mADr1wYVFPkH35fqgqJE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696260193; a=rsa-sha256; cv=none; b=EA0HbzfQXyd3Mv77/lEIPpFl5wj+cLhHx7m6pKPGiwD6w39FnZkLv7GoiLDNXfgljWITwh AC7aXGFchcvK6bjz0jpMTH7Qes0jGV79Izv5S0H9eHSZIHwfEzUbSvaLHryA6JA865NCcp /LxSW3ebVuqMyR8jZSVNsPrU6AdFtQM= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=F0ggXDV0; spf=pass (imf16.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696260193; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4O1ESocyKqwozJC+Tl+xGGPxeQyAnmMS0aCpZFUwmKo=; b=F0ggXDV0L0TXSHLI+YX3g0SmuR4dyWsrbluV44bhmbmyre+ApJVJfRvi+tPde7VGZZPCSV /ot5HRWPdQnlA6dk5ZeiZWEK8VDslbN01nbyqP5lXgotOVMTu7PsQ7/4W97rKCQewZvlT7 wiYd2SZPtq8LMTusoV9Nf+ds+Fq47j4= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-496-G28ocLeENoqPYrv9FrgB1Q-1; Mon, 02 Oct 2023 11:23:09 -0400 X-MC-Unique: G28ocLeENoqPYrv9FrgB1Q-1 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4197878ffe9so12668041cf.0 for ; Mon, 02 Oct 2023 08:23:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696260189; x=1696864989; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4O1ESocyKqwozJC+Tl+xGGPxeQyAnmMS0aCpZFUwmKo=; b=FqHqg83D6QLoySe/tqwZCh1VZfK3/N809Col7AU2Gtpl4yHfvZN8YwIjiwj2QjLANZ xIX34Kh3I79ypENqqkApZDB/XnuZ6nSsb2oQZdX0JRaVC0VQb/0A0HHHyIawT5cslbY3 qHMak7ug0RGv0ZHANDbz8BCTbkq9Fz40hUmX90/PdlJxA09x3UAMI+1lWv2riqYb5QWe Mcua5DNXb86f3Kii6bn/NfAeksMwgs8AYtEZ0+LCusnFexdFhTnCJJz34VaPcKds/WlA 527bZfKlbwHA1F3os8+fPPHDpbdC1j8HEUWl7ae8z0UI0bjrQ9t9bS9mSuaGwHR9aymC Z+bw== X-Gm-Message-State: AOJu0Yyrcvhd1uWjykgruyzvSRFMKgungn8YzSAT2OkzeZv78e/TaFaT 7hx0ON1cV6F/Vj+qpEPlPhDYQtZTvNmoj22eNZJJSIwLonq7fYsPrNccfzY1SEoJu0mg4QoaBkd skmjG3UwcsT8= X-Received: by 2002:a05:622a:1452:b0:3ff:2a6b:5a76 with SMTP id v18-20020a05622a145200b003ff2a6b5a76mr13928220qtx.5.1696260189221; Mon, 02 Oct 2023 08:23:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFMkfW5qwKvmskAcRJvzl4ek6148BaomL6ar7scMW39LWBMgkGSUsRlNgp0NyH9ZUc23Gd1Fw== X-Received: by 2002:a05:622a:1452:b0:3ff:2a6b:5a76 with SMTP id v18-20020a05622a145200b003ff2a6b5a76mr13928199qtx.5.1696260188907; Mon, 02 Oct 2023 08:23:08 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id c21-20020ac853d5000000b004181d77e08fsm5406196qtq.85.2023.10.02.08.23.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 08:23:08 -0700 (PDT) Date: Mon, 2 Oct 2023 11:23:05 -0400 From: Peter Xu To: David Hildenbrand Cc: Suren Baghdasaryan , akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com, lokeshgidra@google.com, hughd@google.com, mhocko@suse.com, axelrasmussen@google.com, rppt@kernel.org, willy@infradead.org, Liam.Howlett@oracle.com, jannh@google.com, zhangpeng362@huawei.com, bgeffon@google.com, kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v2 1/3] userfaultfd: UFFDIO_REMAP: rmap preparation Message-ID: References: <20230923013148.1390521-1-surenb@google.com> <20230923013148.1390521-2-surenb@google.com> <27f177c9-1035-3277-cd62-dc81c12acec4@redhat.com> MIME-Version: 1.0 In-Reply-To: <27f177c9-1035-3277-cd62-dc81c12acec4@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: A0E9C18001F X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: bbi7t8haygd345dejqw3qgwzpj1eiofq X-HE-Tag: 1696260193-867681 X-HE-Meta: U2FsdGVkX1/KOXpxQhlMfirei2AQ8O7GmpaTsnFM1aGr6u8PbuGOBK8OM5Y4CAfqVRsuzNHHoB0YAIQbeik9GWGHNNGr1k30yfep07I9WNQu8+aQfiwDV2SqHtSfijNhRJpoNCK0nlGRZHDZu2FRtuN6MmG60HwYIdfPhC6IsyxJyiXCuxqaDsUyvdNMMQ11KQIj2mCpPgNZ+txjTRq7y8GTgIaW0l+zibYLzNF7kkm3YOEGZqO7y2ZSjEEOsIeucvjJ2GFA8yNc4aFwN2YYZM47c89VxPScaFBLrkwR95JShokPZsPnNZa4saOMF1KyfphSEgKJkDwYjFcmc1Yc+mBDW8weZmelIAJCx6bSrG8E6cu3mSjilt2o4H0Lzw6f9opRxQEe5T6fovdC//8ES4eWuf7+CPkMg9/lCHGT+ChoIm2dTOmtg04weluzWGJ+HEmVNWRe9nzpV+MAsPADmpowvKdhYHxiCxjaTtwQpOax6RfkTG30JTYA2VJ6AlbTfj0OUiVeWVU+/qZNIFu1FbFBkTJ4x9qDS1Kt5E1QtebKMwxqGxrZ+LBDSyTAxJ8+wmjW5ViUzBWltBzqsByW8S9+YdLUmlXJEF7I+Ac/V71NEQbvkNhPo+AIvN9aEya8ARTzIoUkqRTd80gARVFMbnDiRJH9MbSU29hiS5w2bhgYdoaSwwBUQKGRnjjldNtVDXvhrj4iiDjwhJaZPRcrKMj3Xu2Kgmn4FC9KjucT+buCic5lVF09CNoTwH8RKpUoR1WDdIj8EI/Hr25TZymVT+xjbVcmx4YN4lc3zRNnINxGiZAttI/veVBp7WaeOVJK/axc4AUyyKIcGs8O5fSQcJtDsLE0iaSPsjTTcUtvcRddWQvI8uucAk2k4DrnLltZsV12plt2wuY+b4trOEb19DeN2fxu541nHxBrSb4cygEepK2PGDLjset0LguOB0iQe6CuDHMK91WV8j9p05M CHbwQbLD 8WikLCjyLBxmV7aU/mzUJc08c44BqYPeyzz/Rn/ELW1RJ5P0yVNKON6uQnoe1WQ83v/eVQu7OHRAgY6EWPwEZQzZEqLkVlK5AQCkc7aZr4MMvqKtZ9MbI3dutqJTUlXBedclpwcsRBzsiWgIAJ4f/YWxNKNrMvmmwjVgopKmUo2hkSfGp6VEWcveABWLCIEEuRP1M2W7suVdWzWNrGLFGgNojjrQxfPOHB4pRqRRRprTmK7R5VE0NNgeTg6DDBwCGP95d1GU4Ie/QP3+oTB7nD0k5aXQThH9aJ4InCGiEo6e9Ct3jpcUhe5oIyM1dobGruZ8SxDcxj0PpLkM3Y/se3jd+H3kZnjl6PqxfV2GZVy8kDHQVMOz8IZLp5uoQKYV3SkJmOXn6tdrrJHwVCEQd1zJleWNtr6KRtuoBdhC+gfA5ku5/G4/eePnDvkg0bU1B0KekFl14s8v7DP4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000030, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 02, 2023 at 04:42:50PM +0200, David Hildenbrand wrote: > On 23.09.23 03:31, Suren Baghdasaryan wrote: > > From: Andrea Arcangeli > > > > As far as the rmap code is concerned, UFFDIO_REMAP only alters the > > page->mapping and page->index. It does it while holding the page > > lock. However folio_referenced() is doing rmap walks without taking the > > folio lock first, so folio_lock_anon_vma_read() must be updated to > > re-check that the folio->mapping didn't change after we obtained the > > anon_vma read lock. > > I'm curious: why don't we need this for existing users of > page_move_anon_rmap()? What's special about UFFDIO_REMAP? Totally no expert on anon vma so I'm prone to errors, but IIUC the difference here is root anon vma cannot change in page_move_anon_rmap(), while UFFDIO_REMAP can. Thanks, -- Peter Xu