From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65B64E784BD for ; Mon, 2 Oct 2023 15:22:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EDAAA8D0031; Mon, 2 Oct 2023 11:22:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E8B2E8D000E; Mon, 2 Oct 2023 11:22:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D53F78D0031; Mon, 2 Oct 2023 11:22:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C5D4D8D000E for ; Mon, 2 Oct 2023 11:22:01 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8D42716033C for ; Mon, 2 Oct 2023 15:22:01 +0000 (UTC) X-FDA: 81300886842.12.AFB2163 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id CBA7B4001D for ; Mon, 2 Oct 2023 15:21:59 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696260119; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XG8vYlWyeeEeg5ObGmyyGlLeWzwOyaV1Hg+C/3syr6c=; b=ah8tcIJZMrco1InYO6xn0vptAogg6fXURzCGr2i0BbRVnkkX6VkwTPCzUktJnPFWxVqihS vi3rRVGUOeRh0mMBOjj4/qtgYqgYaN5IFlLNlsJPgaumsl6N0D1GjM2BKsmj4A0we6EdqM 1sEy8Kyt35WQDZbl7zN5wOUlM67K0qs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696260119; a=rsa-sha256; cv=none; b=UPnkBs2sLthfF95v+wd/LWGKNkRXqvffTBJ8GOnUT7G6I/6TcCR5XIVtky9AKc68aAApx6 AH2JuMevKI65n/pKse2XSaz4n0S3tY+jEeKqqwq35CjSF/MNwLQgr3NJnbIPz5corbszlh zw07i6aQWd21S11dkPU2KrZCZ08V3P0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id CA8ED60EC6; Mon, 2 Oct 2023 15:21:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F149C433C7; Mon, 2 Oct 2023 15:21:55 +0000 (UTC) Date: Mon, 2 Oct 2023 16:21:52 +0100 From: Catalin Marinas To: Ryan Roberts Cc: Andrew Morton , Matthew Wilcox , Yin Fengwei , David Hildenbrand , Yu Zhao , Anshuman Khandual , Yang Shi , "Huang, Ying" , Zi Yan , Luis Chamberlain , Itaru Kitayama , "Kirill A. Shutemov" , John Hubbard , David Rientjes , Vlastimil Babka , Hugh Dickins , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 7/9] arm64/mm: Override arch_wants_pte_order() Message-ID: References: <20230929114421.3761121-1-ryan.roberts@arm.com> <20230929114421.3761121-8-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230929114421.3761121-8-ryan.roberts@arm.com> X-Rspamd-Queue-Id: CBA7B4001D X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: gkeyqcah5uuea13i8cj7uczit3um1877 X-HE-Tag: 1696260119-317793 X-HE-Meta: U2FsdGVkX18rzO++qmmrqhmOF/5AyLLiRvhWJfnDMuHmJPOsknq8oQnN67EaghA8mM5Pc4YIbTlzutonzde1S6TMJyy3EIqObQMngtH/uPvVMRkc09qb0cvKaIUg8NaduvQaIVvrYeiists/jpSq+odum2TSJTwaOiRM0DSKS79toIag9HzeBUH8s19If2b3GOYMH3Fxv1N9prlcDj2uKCFn0JpQulVFZ/Duyy8248mHGz0nliTCtuTZrhvSK5LA9ZKzzseXllKopdGaJUPCZ2obFMsaUReFx602XEqn/qLiLRvacEPAvcHuv+5olCUtIVwc5LQ+I8XLeuSAp3A92ToSIAMHP3PVNCRqZgQkZlohDD34D/BwlGcHHY2tGMu1bMZEXa9dQu5Nt9MzHAK/nb4tckgydN0fRlFuFYozQtfbskmlsmfQehND1tp8Jh3s7IBwZxkcFteXe0+WP5FjOkeZlFk7bDnd3iWQVTZ3a5lPqTPxwAp+yNI6KzVI8fuIgnSLZc1gA8b/8hpKtlTkFUbMj/vCP73RSu6mD/OM9KOw11RatE2swIGXVnWyh37pvi5qaAabP9LdQAs80UcBagJUeU/2xkw2PrT3H58LRWqYdRWgLAqkCmIY5WGcvkQEuXGaZupf7kp4ZgFTdCvbPcgUa/JMKAeyYOn5MCE8MTUUlGlVDULrxXGvw4MpSRsWCP1JaIS5xW9vb0L1twT3JCXLtXxz/7vGfE7BXBjn2HQDdcWMGBohN1Ew/x+Wh2V+Rkz+0ylg9JOTqRz70bHw6zjAvnVMHIBdqqYiKN7PUB27B/MNXJ71qM5WPjis0kcW8QI8GoY0YEoKiwGMqGzMayZME7LZz9vA0yX5/Tm+gg/hLLinGvSSS3ojNX05utSCwSJVzIAxNBy2N0DZgwAGAWY41X/jvSr+qeVZM/BN56ZCIf2fPQEt9mIuQBFkP/Ztz4hvghctiI0S7UEYY49 DcZlFs55 4KEK3uVmJ52AeNAIH2ImfSSyByMlb6WcE5AGr0xRVRvn1X2jW99pPNxKsM9r9/gGXZ6PqA35VVglyo6iE4ok/jcZwaDbfpsWCGETPSm32fiTOTMJljoGzvBtWf+DxmlfhnMRATsJzMoopHqS5i+lJk4zJMNVUPHXpnHvYk2F5EdP/ArzVPeVl+qmMhQLLud4h1FMo+D6zrjfogTS3cKDs/7++UYSVywf3OZL2G+/35QCQLVKfJz0ZNRa8RCrZwo/DkuLBManKgE6TnT4hIcB9fU3iQxdwND+95jV/zTmYoEcs2yYlNP216Cu2GIRoA6HgkEO8PnjgBwLR5t4WcVXVZUhOBr9N70vmIoshj6eNgfoUPnMmVtS8DJNtYjDAYsSGnDPOGG0xwdyQ4hej0Q3BFQabd9DUz78sdy7hVqEu3TMiq3XuAw1KjuxIjVp6HXc4U/FQXri8D3qghixU2Olg8R0QXb90QmO56/V+/+3bc5Kd8TW+dkiXEEWNGzPgYYNXCi5tjH7J6Jm3BEM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 29, 2023 at 12:44:18PM +0100, Ryan Roberts wrote: > Define an arch-specific override of arch_wants_pte_order() so that when > anon_orders=recommend is set, large folios will be allocated for > anonymous memory with an order that is compatible with arm64's HPA uarch > feature. > > Reviewed-by: Yu Zhao > Signed-off-by: Ryan Roberts Acked-by: Catalin Marinas > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h > index 7f7d9b1df4e5..e3d2449dec5c 100644 > --- a/arch/arm64/include/asm/pgtable.h > +++ b/arch/arm64/include/asm/pgtable.h > @@ -1110,6 +1110,16 @@ extern pte_t ptep_modify_prot_start(struct vm_area_struct *vma, > extern void ptep_modify_prot_commit(struct vm_area_struct *vma, > unsigned long addr, pte_t *ptep, > pte_t old_pte, pte_t new_pte); > + > +#define arch_wants_pte_order arch_wants_pte_order > +static inline int arch_wants_pte_order(void) > +{ > + /* > + * Many arm64 CPUs support hardware page aggregation (HPA), which can > + * coalesce 4 contiguous pages into a single TLB entry. > + */ > + return 2; > +} I haven't followed the discussions on previous revisions of this series but I wonder why not return a bitmap from arch_wants_pte_order(). For arm64 we may want an order 6 at some point (contiguous ptes) with a fallback to order 2 as the next best. -- Catalin